fix: drift test null map handling #287

nikhil-zlai · 2025-01-28T18:24:21Z

Summary

fixed null handling in drift test code.

Checklist

Added Unit Tests
Covered by existing CI
Integration tested
Documentation update

Summary by CodeRabbit

Bug Fixes
- Improved null handling in drift series processing to prevent potential runtime exceptions
- Enhanced error resilience by safely checking for null values during data aggregation

coderabbitai · 2025-01-28T18:24:28Z

Walkthrough

The pull request focuses on improving null value handling in the DriftTest.scala file. The changes involve modifying how null values are processed in driftSeries and summarySeries by introducing Option to safely handle potential null references. This prevents potential NullPointerExceptions by adding null checks before accessing methods and counting elements.

Changes

File	Change Summary
`spark/src/test/scala/ai/chronon/spark/test/stats/drift/DriftTest.scala`	Refactored null handling in `driftSeries` and `summarySeries` processing using `Option` to safely manage null values

Possibly related PRs

metrics fixes #78: Enhancing error handling for null values in metrics
fix: handle Infinity/NaN values in drift series #281: Handling special values like Infinity and NaN in drift series

Suggested reviewers

ken-zlai

Poem

Null values dance, a treacherous game,
Options wrap them with careful aim
No exceptions shall break our code's flow
Safely counting what we want to know! 🛡️
Drift test refactored, resilience complete 🚀

Warning

Review ran into problems

🔥 Problems

GitHub Actions: Resource not accessible by integration - https://docs.github.com/rest/actions/workflow-runs#list-workflow-runs-for-a-repository.

Please grant the required permissions to the CodeRabbit GitHub App under the organization or repository settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 01a2f70 and 5842560.

📒 Files selected for processing (1)

spark/src/test/scala/ai/chronon/spark/test/stats/drift/DriftTest.scala (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (6)

GitHub Check: table_utils_delta_format_spark_tests
GitHub Check: mutation_spark_tests
GitHub Check: fetcher_spark_tests
GitHub Check: join_spark_tests
GitHub Check: other_spark_tests
GitHub Check: scala_compile_fmt_fix

🔇 Additional comments (1)

spark/src/test/scala/ai/chronon/spark/test/stats/drift/DriftTest.scala (1)

114-115: LGTM! Verify null handling coverage.

Robust null handling using Option.

✅ Verification successful

Null handling verification complete - Implementation is robust

The code properly handles nulls at both the series and element level, with logging for verification.
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Verify test coverage for null scenarios
rg -l "Option.*getPercentileDriftSeries" | xargs -I {} rg "null.*test" {}
Length of output: 79

Script:
#!/bin/bash
# Check test methods and null handling
rg "test.*null|null.*test" spark/src/test/scala/ai/chronon/spark/test/stats/drift/DriftTest.scala -A 5
Length of output: 303

Script:
#!/bin/bash
# Find percentile drift tests
rg "getPercentileDriftSeries|test.*percentile" spark/src/test/scala/ai/chronon/spark/test/stats/drift/DriftTest.scala -B 2 -A 5
Length of output: 568

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

tchow-zlai · 2025-01-28T18:25:39Z

spark/src/test/scala/ai/chronon/spark/test/stats/drift/DriftTest.scala

@@ -111,8 +111,8 @@ class DriftTest extends AnyFlatSpec with Matchers {

    val (nulls, totals) = driftSeries.iterator.foldLeft(0 -> 0) {
      case ((nulls, total), s) =>
-        val currentNulls = s.getPercentileDriftSeries.iterator().toScala.count(_ == null)
-        val currentCount = s.getPercentileDriftSeries.size()
+        val currentNulls = Option(s.getPercentileDriftSeries).map(_.iterator().toScala.count(_ == null)).getOrElse(0)


should we be fixing this somewhere in the code itself rather than the test?

the code is expected to send nulls when there is no data.

so basically - we are doing this magic double thing now
thrift doesn’t like it if some values are null in a list

so we made a few changes - to insert a magic double into the list when null/Nan/infinity etc

prior to this we would create list with all nulls - and we had code to convert that into a single null value downstream. we moved this upstream so list of nulls became null.

## Summary fixed null handling in drift test code. ## Checklist - [ ] Added Unit Tests - [x] Covered by existing CI - [ ] Integration tested - [ ] Documentation update  ## Summary by CodeRabbit - **Bug Fixes** - Improved null handling in drift series processing to prevent potential runtime exceptions - Enhanced error resilience by safely checking for null values during data aggregation

## Summary fixed null handling in drift test code. ## Cheour clientslist - [ ] Added Unit Tests - [x] Covered by existing CI - [ ] Integration tested - [ ] Documentation update  ## Summary by CodeRabbit - **Bug Fixes** - Improved null handling in drift series processing to prevent potential runtime exceptions - Enhanced error resilience by safely cheour clientsing for null values during data aggregation

fix: drift test null map handling

5842560

varant-zlai approved these changes Jan 28, 2025

View reviewed changes

tchow-zlai reviewed Jan 28, 2025

View reviewed changes

tchow-zlai merged commit 0cdb2be into main Jan 28, 2025
9 checks passed

tchow-zlai deleted the drift_test_fix branch January 28, 2025 18:39

This was referenced Jan 29, 2025

fix: handle change to collectDoubles in convertTileDriftSeriesInfoToTimeSeries #293

Merged

test: remove unnecessary tests #295

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: drift test null map handling #287

fix: drift test null map handling #287

Uh oh!

nikhil-zlai commented Jan 28, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jan 28, 2025 •

edited

Loading

Review ran into problems

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

tchow-zlai Jan 28, 2025

Uh oh!

nikhil-zlai Jan 28, 2025

Uh oh!

nikhil-zlai Jan 28, 2025

Uh oh!

Uh oh!

Uh oh!

fix: drift test null map handling #287

fix: drift test null map handling #287

Uh oh!

Conversation

nikhil-zlai commented Jan 28, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Poem

Review ran into problems

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

tchow-zlai Jan 28, 2025

Choose a reason for hiding this comment

Uh oh!

nikhil-zlai Jan 28, 2025

Choose a reason for hiding this comment

Uh oh!

nikhil-zlai Jan 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nikhil-zlai commented Jan 28, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 28, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)