Bazel migration for Flink module #237
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| scala_library( | ||
| name = "lib", | ||
| srcs = glob(["src/main/**/*.scala"]), | ||
| visibility = ["//visibility:public"], | ||
| deps = [ | ||
| "//api:lib", | ||
| "//api:thrift", | ||
| "//aggregator:lib", | ||
| "//online:lib", | ||
| "//tools/build_rules/spark:spark-exec", | ||
| scala_artifact("org.apache.flink:flink-streaming-scala"), | ||
| scala_artifact("org.apache.flink:flink-scala"), | ||
| scala_artifact("org.scala-lang.modules:scala-java8-compat"), | ||
| scala_artifact("org.scala-lang.modules:scala-collection-compat"), | ||
| scala_artifact("org.rogach:scallop"), | ||
| maven_artifact("org.apache.flink:flink-streaming-java"), | ||
| maven_artifact("org.apache.flink:flink-core"), | ||
| maven_artifact("org.apache.flink:flink-metrics-dropwizard"), | ||
| maven_artifact("org.apache.flink:flink-metrics-core"), | ||
| maven_artifact("org.apache.flink:flink-clients"), | ||
| maven_artifact("org.apache.flink:flink-yarn"), | ||
| maven_artifact("io.dropwizard.metrics:metrics-core"), | ||
| ], | ||
| ) | ||
|
|
||
| scala_library( | ||
| name = "test-lib", | ||
| srcs = glob(["src/test/**/*.scala"]), | ||
| visibility = ["//visibility:public"], | ||
| deps = [ | ||
| ":lib", | ||
| "//online:lib", | ||
| "//api:thrift", | ||
| "//api:lib", | ||
| "//aggregator:lib", | ||
| "//tools/build_rules/spark:spark-exec", | ||
| # Libraries | ||
| scala_artifact("org.apache.flink:flink-streaming-scala"), | ||
| scala_artifact("org.apache.flink:flink-scala"), | ||
| scala_artifact("org.scala-lang.modules:scala-java8-compat"), | ||
| scala_artifact("org.scala-lang.modules:scala-collection-compat"), | ||
| maven_artifact("org.apache.flink:flink-core"), | ||
| maven_artifact("org.apache.flink:flink-streaming-java"), | ||
| maven_artifact("org.apache.flink:flink-runtime"), | ||
| # Testing | ||
| scala_artifact("org.scalatest:scalatest-matchers-core"), | ||
| scala_artifact("org.scalatest:scalatest-core"), | ||
| scala_artifact("org.scalatest:scalatest"), | ||
| scala_artifact("org.scalatest:scalatest-flatspec"), | ||
| scala_artifact("org.scalatest:scalatest-funsuite"), | ||
| scala_artifact("org.scalatest:scalatest-shouldmatchers"), | ||
| scala_artifact("org.scalactic:scalactic"), | ||
| scala_artifact("org.scalatestplus:mockito-3-4"), | ||
| scala_artifact("org.mockito:mockito-scala"), | ||
| maven_artifact("org.mockito:mockito-core"), | ||
| maven_artifact("org.scalatest:scalatest-compatible"), | ||
| maven_artifact("junit:junit"), | ||
| maven_artifact("com.novocode:junit-interface"), | ||
| maven_artifact("org.apache.flink:flink-test-utils"), | ||
| maven_artifact("org.apache.flink:flink-runtime-tests"), | ||
| ], | ||
| ) | ||
|
|
||
| scala_test_suite( | ||
| name = "test", | ||
| srcs = glob(["src/test/**/*.scala"]), | ||
| visibility = ["//visibility:public"], | ||
| deps = [ | ||
|
There was a problem hiding this comment. there seems to be a lot of repetition across targets - i would split these into two python arrays - flink_deps, flink_test_deps and re-use in three places. |
||
| ":lib", | ||
| ":test-lib", | ||
| "//online:lib", | ||
| "//api:thrift", | ||
| "//api:lib", | ||
| "//aggregator:lib", | ||
| "//tools/build_rules/spark:spark-exec", | ||
| # Libraries | ||
| scala_artifact("org.apache.flink:flink-streaming-scala"), | ||
| scala_artifact("org.apache.flink:flink-scala"), | ||
| scala_artifact("org.scala-lang.modules:scala-java8-compat"), | ||
| scala_artifact("org.scala-lang.modules:scala-collection-compat"), | ||
| maven_artifact("org.apache.flink:flink-core"), | ||
| maven_artifact("org.apache.flink:flink-streaming-java"), | ||
| maven_artifact("org.apache.flink:flink-runtime"), | ||
| # Testing | ||
| scala_artifact("org.scalatest:scalatest-matchers-core"), | ||
| scala_artifact("org.scalatest:scalatest-core"), | ||
| scala_artifact("org.scalatest:scalatest"), | ||
| scala_artifact("org.scalatest:scalatest-flatspec"), | ||
| scala_artifact("org.scalatest:scalatest-funsuite"), | ||
| scala_artifact("org.scalatest:scalatest-shouldmatchers"), | ||
| scala_artifact("org.scalactic:scalactic"), | ||
| scala_artifact("org.scalatestplus:mockito-3-4"), | ||
| scala_artifact("org.mockito:mockito-scala"), | ||
| maven_artifact("org.mockito:mockito-core"), | ||
| maven_artifact("org.scalatest:scalatest-compatible"), | ||
| maven_artifact("junit:junit"), | ||
| maven_artifact("com.novocode:junit-interface"), | ||
| maven_artifact("org.apache.flink:flink-test-utils"), | ||
| maven_artifact("org.apache.flink:flink-runtime-tests"), | ||
| ], | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when we build the flink jar - which of these modules are included and which ones are excluded / treated as provided? We'll want to mimic the sbt assembly behavior here (not blocking this pr but we'll need to address / tackle)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point. I think by default bazel includes all dependency jars in the fat jar and we would need additional config setup to replicate excluded/provided behavior in sbt which i'm working as part of separate PR.