Drop Spark BigTable version to unlock DataProc submission

[piyush-zlai]

Summary

While testing the Flink side of things, I noticed that our DataProc submission was broken due to some opencensus version mismatches:

[info]   com.google.common.util.concurrent.ExecutionError: java.lang.NoSuchMethodError: 'io.opencensus.tags.TagContext io.opencensus.tags.unsafe.ContextUtils.getValue(io.grpc.Context)'
[info]   at com.google.common.util.concurrent.Futures.wrapAndThrowUnchecked(Futures.java:1387)
[info]   at com.google.common.util.concurrent.Futures.getUnchecked(Futures.java:1380)
[info]   at com.google.api.gax.rpc.ApiExceptions.callAndTranslateApiException(ApiExceptions.java:53)
[info]   at com.google.api.gax.rpc.UnaryCallable.call(UnaryCallable.java:112)
[info]   at com.google.cloud.dataproc.v1.JobControllerClient.submitJob(JobControllerClient.java:435)
[info]   at com.google.cloud.dataproc.v1.JobControllerClient.submitJob(JobControllerClient.java:404)
[info]   at ai.chronon.integrations.cloud_gcp.DataprocSubmitter.submit(DataprocSubmitter.scala:70)
[info]   at ai.chronon.integrations.cloud_gcp.test.DataprocSubmitterTest.$anonfun$new$4(DataprocSubmitterTest.scala:77)
[info]   at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
[info]   at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
[info]   ...
[info]   Cause: java.lang.NoSuchMethodError: 'io.opencensus.tags.TagContext io.opencensus.tags.unsafe.ContextUtils.getValue(io.grpc.Context)'
[info]   at io.opencensus.implcore.tags.CurrentTagMapUtils.getCurrentTagMap(CurrentTagMapUtils.java:37)
[info]   at io.opencensus.implcore.tags.TaggerImpl.getCurrentTagContext(TaggerImpl.java:51)
[info]   at io.opencensus.implcore.tags.TaggerImpl.getCurrentTagContext(TaggerImpl.java:31)
[info]   at io.grpc.census.CensusStatsModule$StatsClientInterceptor.interceptCall(CensusStatsModule.java:801)
[info]   at io.grpc.ClientInterceptors$InterceptorChannel.newCall(ClientInterceptors.java:156)
[info]   at com.google.api.gax.grpc.GrpcChannelUUIDInterceptor.interceptCall(GrpcChannelUUIDInterceptor.java:52)
[info]   at io.grpc.ClientInterceptors$InterceptorChannel.newCall(ClientInterceptors.java:156)
[info]   at com.google.api.gax.grpc.GrpcHeaderInterceptor.interceptCall(GrpcHeaderInterceptor.java:80)
[info]   at io.grpc.ClientInterceptors$InterceptorChannel.newCall(ClientInterceptors.java:156)
[info]   at com.google.api.gax.grpc.GrpcMetadataHandlerInterceptor.interceptCall(GrpcMetadataHandlerInterceptor.java:54)
[info]   ...

Tried playing with different opencensus versions + lib management etc and @tchow-zlai pointed out that this was due to the spark-bigtable dep. We don't need this dep for the mainstream as we're using the BQ export data query to load data into BT. The Spark-Bt connector is required primarily for docker quickstart testing. So in this PR, I've yanked the dep to re-enable the dataproc submission and reworked the load-data script and Dockerfile to download the spark-bigtable + slf4j jars to pass them in only for the Spark2bigTableLoader app in the docker setup.

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• New Features

  • Updated Docker image to include custom JAR files for BigTable and logging
  • Modified Spark configuration to use updated Bigtable dependencies
  • Enhanced data loading script with improved JAR file handling

• Dependency Updates

  • Replaced Spark-specific BigTable connector with general Bigtable HBase library
  • Updated Google Cloud library dependencies to latest versions

[coderabbitai]

Walkthrough

This pull request focuses on enhancing the project's Docker and build configurations by updating dependencies and JAR file management. The changes involve modifying the Dockerfile to include custom JAR files for BigTable and Log4j, updating the build.sbt to use a more generic Bigtable dependency, and adjusting the load_data.sh script to incorporate these new JAR files in the Spark job configuration.

Changes

File	Change Summary
Dockerfile	Added steps to download and install custom JAR files for BigTable and Log4j in /opt/custom-jars
build.sbt	Replaced Spark-specific Bigtable connector with a generic Bigtable HBase dependency
quickstart/cloud_gcp/scripts/load_data.sh	Updated Spark submit command to include custom JAR files via --driver-class-path and --jars options

Sequence Diagram

sequenceDiagram
    participant Dockerfile
    participant build.sbt
    participant load_data.sh
    
    Dockerfile->>+Dockerfile: Create /opt/custom-jars
    Dockerfile->>+Dockerfile: Download custom JARs
    build.sbt->>+build.sbt: Update Bigtable dependency
    load_data.sh->>+load_data.sh: Configure Spark submit with custom JARs

Loading

Possibly related PRs

• Wire up Play frontend + server in docker setup #24: Dockerfile environment and dependency setup
• Driver Summarizer #62: JAR file loading functionality
• feat: enable slf4j logging to work with logback #76: Log4j integration
• feat: use log4j2 everywhere in spark consistently #99: Log4j2 implementation
• Tweak obs demo docker init image to pull out sbt steps outside docker build #102: Dockerfile build process optimization
• feat: support dataproc federated bigquery catalog #128: JAR file handling in DataprocSubmitter
• chore: separate column predicates from partition filters #149: Partition and column predicate handling

Suggested Reviewers

• nikhil-zlai
• tchow-zlai

Poem

🚢 Dockerfiles sailing, dependencies bright,
JAR files dancing in the build's delight,
Bigtable's connector, now sleek and clean,
Spark's magic weaving a data-driven scene!
Code evolves, with each commit's might 🌟

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

quickstart/cloud_gcp/scripts/load_data.sh (1)

36-38: Add error checks for required JARs

Check if required JARs exist before spark-submit.

+# Check for required JARs
+for jar in "spark-bigtable_2.12-0.2.1.jar" "log4j-slf4j-impl-2.20.0.jar"; do
+  if [ ! -f "/opt/custom-jars/$jar" ]; then
+    echo "Error: Required JAR $jar not found in /opt/custom-jars/" >&2
+    exit 1
+  fi
+done
+
 if ! spark-submit --driver-class-path "$CLASSPATH:/opt/custom-jars/*" \

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between a4f162c and 7933f85.

📒 Files selected for processing (3)

• Dockerfile (1 hunks)
• build.sbt (0 hunks)
• quickstart/cloud_gcp/scripts/load_data.sh (1 hunks)

💤 Files with no reviewable changes (1)

• build.sbt

🔇 Additional comments (1)

Dockerfile (1)

60-65: Verify if these specific versions resolve the opencensus conflict

Let's verify if these versions resolve the NoSuchMethodError.

[coderabbitai]

🛠️ Refactor suggestion

Add checksum verification for downloaded JARs

Verify JAR integrity to prevent supply chain attacks.

 RUN mkdir -p /opt/custom-jars && \
+    # spark-bigtable
     curl -L "https://repo1.maven.org/maven2/com/google/cloud/spark/bigtable/spark-bigtable_2.12/0.2.1/spark-bigtable_2.12-0.2.1.jar" \
-    -o /opt/custom-jars/spark-bigtable_2.12-0.2.1.jar && \
+    -o /opt/custom-jars/spark-bigtable_2.12-0.2.1.jar && \
+    echo "expected-sha256-here /opt/custom-jars/spark-bigtable_2.12-0.2.1.jar" | sha256sum -c && \
+    # log4j-slf4j-impl
     curl -L "https://repo1.maven.org/maven2/org/apache/logging/log4j/log4j-slf4j-impl/2.20.0/log4j-slf4j-impl-2.20.0.jar" \
-    -o /opt/custom-jars/log4j-slf4j-impl-2.20.0.jar
+    -o /opt/custom-jars/log4j-slf4j-impl-2.20.0.jar && \
+    echo "expected-sha256-here /opt/custom-jars/log4j-slf4j-impl-2.20.0.jar" | sha256sum -c

Committable suggestion skipped: line range outside the PR's diff.

[tchow-zlai]

thank you sir!!