This repository was archived by the owner on Nov 13, 2024. It is now read-only.
Add yank support #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thank you @logan-connolly for the PR. I will start looking into #8, and update the README to explain the Yank commands we just merged :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ziontee113,
Just want to say great work on the plugin. I really enjoy having these symbols integrated into vim!
There was one thing that I kept doing when using the plugin that I think this PR addresses:
In order to simplify this process, I have added another group of commands with
Yankas a suffix (e.g.PickEmojiYank) that takes the selection and assigns it to the clipboard register+.Unfortunately, this adds many more commands to the package (14 -> 21), which crowds the command namespace when entering into command mode with
:Pand hitting tab. I will open an issue after publishing this PR detailing what exactly I mean by that and a potential API change to improve design.Anways, thanks again for the cool package!
EDIT: link to issue #8