Skip to content

restore: fix bug where chunked segment was processed but not used #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025
Merged

restore: fix bug where chunked segment was processed but not used #559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/client/restful.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ func (r *RestfulClient) BulkInsert(ctx context.Context, input RestfulBulkInsertI
var createResp createImportResp
log.Debug("create import job via restful", zap.Any("createReq", createReq))
resp, err := r.cli.R().
SetHeader("Request-Timeout", "600").
SetContext(ctx).
SetBody(createReq).
SetSuccessResult(&createResp).
Expand Down
4 changes: 2 additions & 2 deletions core/restore/collection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import (
const (
_bulkInsertTimeout = 60 * time.Minute
_bulkInsertCheckInterval = 3 * time.Second
_bulkInsertRestfulAPIChunkSize = 1024
_bulkInsertRestfulAPIChunkSize = 256
)

type tearDownFn func(ctx context.Context) error
Expand Down Expand Up @@ -618,7 +618,7 @@ func (ct *CollectionTask) restoreNotL0SegV2(ctx context.Context, part *backuppb.
chunkedGroups := lo.Chunk(notL0Groups, _bulkInsertRestfulAPIChunkSize)
for _, groups := range chunkedGroups {
paths := make([][]string, 0, len(groups))
for _, g := range notL0Groups {
for _, g := range groups {
paths = append(paths, []string{g.insertLogDir, g.deltaLogDir})
}

Expand Down