-
Notifications
You must be signed in to change notification settings - Fork 53
TLS Authentication in Backup Tool #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@gifi-siby Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/main/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
Thank you for your PR! Currently, I’m making adjustments to the way the tool connects to Milvus as part of preparing for the v0.5.0 release, which will support new features in Milvus 2.5. Would you like your changes to be included in the v0.5.0 release? If so, you may need to rebase your PR to align with the upcoming changes. |
cf47ed0
to
6a6008c
Compare
Could you please confirm the expected release date for v0.5.0? |
Signed-off-by: gifi-siby <[email protected]> Signed-off-by: “gifi-siby” <[email protected]>
6a6008c
to
2522071
Compare
The v0.5.0 beta release is expected around mid to late January. For the v0.4.x series, we plan to create a separate branch and maintain it for some time. |
Thanks for the update! |
Thanks for your clarification! Your PR can be merged after review. However, please note that the master branch will soon transition to v0.5.0. This release includes significant changes to how connections to Milvus are handled, and the v0.5.0 branch is not fully ready yet as it is still undergoing internal testing. If you'd like your changes to be part of v0.5.0, you might need to rebase your PR onto the updated master branch once it reflects the v0.5.0 changes. Alternatively, we can merge your PR into the current master branch now, but resolving conflicts later may require extra effort due to the pending updates. I will let you know as soon as the v0.5.0 is ready for development. |
It sounds like merging to the current master branch works for now. If you’re ready to share one v0.5.0 branch for development, I’d be happy to rebase my changes and continue working there as well. Looking forward to the next steps! |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gifi-siby, huanghaoyuanhhy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: “gifi-siby” <[email protected]>
Milvus-Backup currently doesn't support TLS and thus, I am not able to connect using certificates.
I would like to add TLS support for Milvus-Backup tool
Related issue: #493
PRs worked together are:
#495
#496