Skip to content

TLS Authentication in Backup Tool #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

gifi-siby
Copy link
Contributor

@gifi-siby gifi-siby commented Jan 6, 2025

Milvus-Backup currently doesn't support TLS and thus, I am not able to connect using certificates.
I would like to add TLS support for Milvus-Backup tool

Related issue: #493

PRs worked together are:
#495
#496

Copy link

mergify bot commented Jan 6, 2025

@gifi-siby Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/main/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added the needs-dco label Jan 6, 2025
@huanghaoyuanhhy
Copy link
Collaborator

Thank you for your PR!

Currently, I’m making adjustments to the way the tool connects to Milvus as part of preparing for the v0.5.0 release, which will support new features in Milvus 2.5. Would you like your changes to be included in the v0.5.0 release? If so, you may need to rebase your PR to align with the upcoming changes.

@gifi-siby
Copy link
Contributor Author

Could you please confirm the expected release date for v0.5.0?
I’d like to merge my changes to master as soon as possible, and I want to make sure everything aligns with the release timeline.

Signed-off-by: gifi-siby <[email protected]>

Signed-off-by: “gifi-siby” <[email protected]>
@mergify mergify bot added dco-passed and removed needs-dco labels Jan 6, 2025
@huanghaoyuanhhy
Copy link
Collaborator

The v0.5.0 beta release is expected around mid to late January. For the v0.4.x series, we plan to create a separate branch and maintain it for some time.

@gifi-siby
Copy link
Contributor Author

Thanks for the update!
I wanted to clarify whether the changes from my PR will be merged into the master branch or if they will go into a separate branch after the review.
I’m keen to ensure that the committed dates are not affected, and I want to avoid any issues with that.

@huanghaoyuanhhy
Copy link
Collaborator

huanghaoyuanhhy commented Jan 7, 2025

Thanks for your clarification!

Your PR can be merged after review. However, please note that the master branch will soon transition to v0.5.0. This release includes significant changes to how connections to Milvus are handled, and the v0.5.0 branch is not fully ready yet as it is still undergoing internal testing.

If you'd like your changes to be part of v0.5.0, you might need to rebase your PR onto the updated master branch once it reflects the v0.5.0 changes. Alternatively, we can merge your PR into the current master branch now, but resolving conflicts later may require extra effort due to the pending updates.

I will let you know as soon as the v0.5.0 is ready for development.

@gifi-siby
Copy link
Contributor Author

It sounds like merging to the current master branch works for now. If you’re ready to share one v0.5.0 branch for development, I’d be happy to rebase my changes and continue working there as well.

Looking forward to the next steps!

@huanghaoyuanhhy
Copy link
Collaborator

/lgtm

@huanghaoyuanhhy
Copy link
Collaborator

/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gifi-siby, huanghaoyuanhhy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@huanghaoyuanhhy huanghaoyuanhhy merged commit d39b7d6 into zilliztech:main Jan 10, 2025
17 of 18 checks passed
zhuwenxing pushed a commit to zhuwenxing/milvus-backup that referenced this pull request Feb 18, 2025
@gifi-siby gifi-siby deleted the IBM_Authorization branch March 5, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants