Add support for unpacking tars with hardlinks #21092
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NilsIrl
force-pushed
the
nils-hard-link
branch
from
706d4bb to
39be7fd
Compare
NilsIrl
force-pushed
the
nils-hard-link
branch
from
39be7fd to
2d17cff
Compare
NilsIrl
force-pushed
the
nils-hard-link
branch
from
fbe9b90 to
2d17cff
Compare
alexrp
reviewed
Mar 26, 2025
alexrp
reviewed
Mar 26, 2025
Comment on lines
+728
to
+730
| if (native_os == .windows) { | ||
| return error.UnableToCreateHardLink; | ||
| } |
There was a problem hiding this comment.
https://learn.microsoft.com/en-us/windows/win32/fileio/hard-links-and-junctions
Not sure how compatible Windows's notion of a hard link is with the POSIX notion, though. cc @squeek502
There was a problem hiding this comment.
Out of precaution and without a concrete example, I would not assume they work in the same way
There was a problem hiding this comment.
I'd say open a follow-up issue for hard links on Windows. I'm not familiar enough with hard links to know how Windows/POSIX hard links differ.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how cross platform support for non-posix platforms should be implemented. This depends on std.posix.link
Use case: https://github.com/NilsIrl/dockerc/actions/runs/10414275001/job/28842950131