-
Notifications
You must be signed in to change notification settings - Fork 4
feat(build): add docs build step to build.zig & deploy docs job #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
environment: | ||
name: github-pages | ||
url: ${{ steps.deployment.outputs.page_url }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do?
Do we need it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/actions/deploy-pages?tab=readme-ov-file#security-considerations
url: ${{ steps.deployment.outputs.page_url }}
This sets the environment’s URL to the value of the page_url output from the deployment step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing me to the docs, I admit I am not entirely sure I understand what points 3 to 5 mean.
Do you think we should create an environment in the repo settings?
I don't have prior experience of deploying to GitHub pages 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's not needed. Only gh pages needs to be enabled here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I did check the settings and pages are enabled.
Also the environment exists.
@hendriknielaender thanks for tackling this! ❤️ They should go away if you |
7090309
to
fc88a4d
Compare
Oh yeah thank you 🙏 , missed that part. Didn't create the branch on a clean state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handy thread on Discord on how to setup the repo settings |
Little progress: I think the broader compilation is wrong, because the output of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this 🙏🏼
We have an unrelated problem with the build that prevents proper population of the docs, this PR works as intended and I'm looking forward to see it deployed after merging 👍🏼
uh where is the result of this? where are the docs? |
Summary
This PR introduces two key improvements to our documentation workflow:
1.
build.zig
Enhancementdocs
) to generate project documentation.2. GitHub Actions Workflow
.github/workflows/deploy-docs.yml
.master
branch.zig build docs
step.actions/deploy-pages
action.Testing
zig build docs
produces the expected output locally.Checklist
build.zig
closes #52