Skip to content

otlp: implement collector types and exp backoff retry #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 23, 2025

Conversation

inge4pres
Copy link
Collaborator

@inge4pres inge4pres commented May 13, 2025

Reason for this PR

Follow up of #41 to add:

  • HTTP/protobuf protocol now uses the correct types as messages for export requests
  • proper OTLP tests

Closes #42

Details

Collector protobuf is added to the build to allow generating the types used in the ExportXYZ RPCs.

Implement the retries as (partially) described in the OTel specs for the HTTP/protobuf protocol.
With this PR, we allow users to configure the behavior of HTTP retries when configuring the exporter, but not which status codes will be retried.

Related: open-telemetry/opentelemetry-specification#3639

Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've skimmed. I don't have any objections.
I will have more in-depth review, hopefully soon.

Thanks for all the hardwork!

Base automatically changed from metrics/stable-exporters-2 to main May 23, 2025 08:49
@inge4pres inge4pres force-pushed the otlp-test-httpstd branch from 596857a to 99c0a6e Compare May 23, 2025 08:51
@inge4pres inge4pres merged commit eddbe5a into main May 23, 2025
4 checks passed
@inge4pres inge4pres deleted the otlp-test-httpstd branch May 26, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTLP: code-generation for Collector message types
3 participants