Skip to content

MeterOptions struct should actually be InstrumentationScope #38

Closed
@inge4pres

Description

@inge4pres

Describe the current state

When developing the metrics we created a type MeterOptions to create meters.
This is incorrect, and this should really be a common component across all signals, namley InstrumentationScope.

Describe the desired state

A shared type InstrumentationScope exists that acts as a metadata container for all signals.
This is usually passed to get(Meter|Logger|Tracer) methods in their corresponding providers, functioning as identifier for the builder of each signal handler.

Additional context

@kmos is already going to provide the InstrumentationScope type in an upcoming PR.
Once that lands, we should basically remove the meter.zig implementation of MeterOptions and replace it with InstrumentationScope, amending all tests and call sites.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions