1.21: Made order of names in AUTHORS.md reliable #1899
Merged
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details: * The sort order of the 'sort' command depends on the LC_COLLATE env var (which can be overridden by the LC_ALL env var). The AUTHORS.md file is generated on every build (because its dependencies are the complete set of commits in the repo), and uses the 'sort' command when creating it. When the sort order is not reliable, the AUTHORS.md file changes, and this causes the publish workflow to have a dirty git status due to the change AUTHORS.md file, and thus the upload to Pypi fails. This change sets LC_ALL=C.UTF-8 in order to produce a reliable order in the UATHORS.md file, independent of the LC_* env vars the environment may or may not have set. Signed-off-by: Andreas Maier <[email protected]>
andy-maier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolls back PR #1897 into 1.21.