-
Notifications
You must be signed in to change notification settings - Fork 0
Sidebar dark theme #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/theme/palette.ts
Outdated
const darkThemePalette = { | ||
...lightThemePalette, | ||
primary: { | ||
main: "#EC4A0A", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the main color is changing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup this has been removed. Also added a new custom icon button component that can render a contained variant. Adding a new prop named variant
to the default MuiIconButton doesn't work. It's also the suggested approach based what I read on a thread on the MUI repo.
mui/material-ui#37443
Can this PR be merged and release without negative effects on current manager-ui and with out merging zesty-io/manager-ui#2197? |
Still finalizing a few things, since the main PR hasn't been fully-approved yet. There's still a small chance I might have to change something here. But this shouldn't affect manager-ui if this get's released ahead of the main PR since this basically only adds a few new exports. |
Added dark mode theme for sidebar elements
Note
This is needed for zesty-io/manager-ui#2197
Preview