Skip to content

Sidebar dark theme #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Aug 7, 2023
Merged

Sidebar dark theme #78

merged 22 commits into from
Aug 7, 2023

Conversation

finnar-bin
Copy link
Contributor

@finnar-bin finnar-bin commented Jul 31, 2023

Added dark mode theme for sidebar elements

Note

This is needed for zesty-io/manager-ui#2197

Preview

image

@finnar-bin finnar-bin requested a review from agalin920 July 31, 2023 08:05
@finnar-bin finnar-bin requested a review from agalin920 August 1, 2023 08:42
const darkThemePalette = {
...lightThemePalette,
primary: {
main: "#EC4A0A",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the main color is changing

Copy link
Contributor Author

@finnar-bin finnar-bin Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup this has been removed. Also added a new custom icon button component that can render a contained variant. Adding a new prop named variant to the default MuiIconButton doesn't work. It's also the suggested approach based what I read on a thread on the MUI repo.
mui/material-ui#37443

@finnar-bin finnar-bin requested a review from agalin920 August 2, 2023 10:04
@shrunyan
Copy link
Contributor

shrunyan commented Aug 3, 2023

Can this PR be merged and release without negative effects on current manager-ui and with out merging zesty-io/manager-ui#2197?

@finnar-bin
Copy link
Contributor Author

finnar-bin commented Aug 3, 2023

Can this PR be merged and release without negative effects on current manager-ui and with out merging zesty-io/manager-ui#2197?

Still finalizing a few things, since the main PR hasn't been fully-approved yet. There's still a small chance I might have to change something here. But this shouldn't affect manager-ui if this get's released ahead of the main PR since this basically only adds a few new exports.

@finnar-bin finnar-bin requested a review from agalin920 August 3, 2023 22:26
@shrunyan shrunyan merged commit 1119450 into main Aug 7, 2023
@finnar-bin finnar-bin deleted the sidebar-dark-theme branch December 19, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants