[Global] Prevent unnecessary re-renders in global top bar

[finnar-bin]

Prevents unnecessary re-renders in the global top bar to improve overall app performance

[Copilot]

Pull Request Overview

This PR aims to improve overall app performance by preventing unnecessary re-renders in the global top bar. The key changes include:

• Removing the redundant state parameter from the createTab function, with state now fetched directly within the function.
• Updating all call sites of createTab to match the new signature.
• Wrapping TopBarTab and GlobalTopbar components with React.memo to prevent unnecessary re-renders.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/shell/store/ui.ts	Modified createTab to remove the explicit state parameter and now retrieve state internally.
src/shell/components/global-tabs/components/Tab.tsx	Updated UnpinnedTopBarTab to call the new createTab signature and wrapped TopBarTab using memo.
src/shell/components/GlobalTopbar/GlobalTopbar.tsx	Converted GlobalTopbar to a memoized component with displayName assignment.

Comments suppressed due to low confidence (2)

src/shell/store/ui.ts:257

• Using store.getState() inside createTab decouples the function from the thunk's getState, which may lead to subtle timing issues if the global state and the thunk state differ. Confirm that this design change is intentional and does not introduce stale state problems in asynchronous scenarios.

export function createTab(parsedPath: ParsedPath, queryData?: any) {

src/shell/components/global-tabs/components/Tab.tsx:234

• The variable queryData is referenced without being defined in UnpinnedTopBarTab. Consider explicitly passing or defining queryData to avoid potential runtime errors.

  const tab = createTab(parsePath(location), queryData);