-
Notifications
You must be signed in to change notification settings - Fork 5
[Content] Notify users when a related item failed to publish due to missing an allow publish status #3540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
[Content] Notify users when a related item failed to publish due to missing an allow publish status #3540
Conversation
…ssing allow publish status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a notification to inform users when any related content items fail to publish due to missing the required workflow status.
- Captures publishing results via
Promise.allSettled
- Filters responses for 403 errors on related items
- Dispatches an error notification listing the affected item titles
Comments suppressed due to low confidence (2)
src/apps/content-editor/src/app/views/ItemEdit/components/ItemEditHeader/ItemEditHeaderActions.tsx:334
- [nitpick] Fix grammar in the error message: change "does not have" to "do not have" when referring to multiple items.
"The following related items does not have the required status that allows publishing: ${relatedItemsWithMissingPublishStatus.join(
src/apps/content-editor/src/app/views/ItemEdit/components/ItemEditHeader/ItemEditHeaderActions.tsx:289
- [nitpick] The variable
publishResponse
holds an array of results. Rename it topublishResponses
orpublishResults
for clarity.
const publishResponse = await Promise.allSettled([
...ps/content-editor/src/app/views/ItemEdit/components/ItemEditHeader/ItemEditHeaderActions.tsx
Show resolved
Hide resolved
...ps/content-editor/src/app/views/ItemEdit/components/ItemEditHeader/ItemEditHeaderActions.tsx
Show resolved
Hide resolved
Temporarily placing on hold as we need to request for a change on the api to provide a clearer error message instead of assuming that the 403 was caused by a missing workflow status |
Show a notification to let users know when a related content item failed to publish due to missing an allow publish workflow status
Resolves #3539
Content---nar-test-2---Zesty-io---zesty-pw---Manager.webm