fix: Media: Upload Modal - Title does not become plural #2589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agalin920
approved these changes
Mar 13, 2024
zcolah
suggested changes
Mar 14, 2024
@zcolah Yes, I also tested on 1 file, its working fine |
|
@glespinosa |
|
@zcolah screencast-8-aaeffee09b-7w6v22.manager.dev.zesty.io_8080-2024.03.22-07_13_34.1.webm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close #2495
Since I can't reproduced the success uploading in the local environment cause it keeps failing to upload.
While testing I set a fixed value of 2 for filesUploaded variable to reproduce and check if the condition is now working fiine.
Note: pls ignore the failed uploading messages, since this is a local environment, when this is deployed in dev or prod this will work as intended.
screencast-8-aaeffee09b-7w6v22.manager.dev.zesty.io_8080-2024.03.13-06_31_50.webm
Creating new PR cause I made some unnecessary commits in my previous PR, thinking that I only have problem in my connectivity but looks like the github having some outage issue in PR. (https://www.githubstatus.com/incidents/q3gl44chgxwv)
#2587