Skip to content

fix: Preview Modal - Disable the Arrow Key Image Changing Functionality #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

glespinosa
Copy link
Contributor

Will close #2435
This will prevent unnecessary navigation of images while the user is focus on an input/textarea when the only purpose of user is to navigate through texts.

@glespinosa glespinosa marked this pull request as ready for review March 12, 2024 11:41
@glespinosa glespinosa self-assigned this Mar 12, 2024
@glespinosa glespinosa requested a review from agalin920 March 12, 2024 11:42
agalin920
agalin920 previously approved these changes Mar 12, 2024
@agalin920
Copy link
Contributor

Can you add a code comment explaining the "why" this is done

@glespinosa glespinosa added the ready PR is complete and ready for deployment label Mar 14, 2024
@shrunyan shrunyan changed the base branch from master to dev March 25, 2024 19:00
@glespinosa
Copy link
Contributor Author

glespinosa commented Apr 1, 2024

@zcolah needs your vqa tag here on the PR for this to proceed. Thank you

@zcolah zcolah added the vqa VQA is complete and approved label Apr 1, 2024
@shrunyan shrunyan merged commit 5484604 into dev Apr 1, 2024
@shrunyan shrunyan deleted the fix/media-preview-modal-enhancement branch April 1, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PR is complete and ready for deployment vqa VQA is complete and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media: Preview Modal - Disable the Arrow Key Image Changing Functionality when a user is typing in the title input and rename modal input
4 participants