-
Notifications
You must be signed in to change notification settings - Fork 5
feat: Global: Notification Alert Revamp #2555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
6cc783c
revamp alert notification
glespinosa 000611e
Merge branch 'dev' into feat/revamp-alert-notification
shrunyan 6798312
Merge branch 'dev' into feat/revamp-alert-notification
glespinosa 06bbda6
Merge branch 'dev' into feat/revamp-alert-notification
shrunyan 20beb6d
Content Update Global Alert
glespinosa 149f529
Schema: Update Global Alert
glespinosa 2c5a413
Merge branch 'dev' into feat/revamp-alert-notification
shrunyan 4d5cd58
Merge branch 'dev' into feat/revamp-alert-notification
glespinosa 2cfd2ba
Merge branch 'dev' into feat/revamp-alert-notification
glespinosa 0071e3f
- removes commented messages
glespinosa 49e0639
convert function to static object
glespinosa afcc027
Merge branch 'dev' into feat/revamp-alert-notification
glespinosa ffb7842
actions.spec.js test suite update
glespinosa 41b2836
update content.spec.js toast contains
glespinosa 3ff19c2
Merge branch 'dev' into feat/revamp-alert-notification
shrunyan 1ac385b
Merge branch 'dev' into feat/revamp-alert-notification
glespinosa b98c3a8
Merge branch 'dev' into feat/revamp-alert-notification
shrunyan af7b250
Merge branch 'dev' into feat/revamp-alert-notification
shrunyan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -159,11 +159,23 @@ export const CreateModelDialogue = ({ onClose, modelType = "" }: Props) => { | |
|
||
useEffect(() => { | ||
if (error) { | ||
// @ts-ignore | ||
let message = error?.data?.error || "Failed to create model", | ||
heading = ""; | ||
// @ts-ignore | ||
if (error?.data?.error.includes("label cannot be blank")) { | ||
message = "Please Add Display Name"; | ||
heading = "Cannot Create Model"; | ||
// @ts-ignore | ||
} else if (error?.data?.error.includes("name is already in use")) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not a fan of this. Would prefer BE messaging changes. But approving |
||
message = "Display name is already in use"; | ||
heading = "Cannot Create Model"; | ||
} | ||
dispatch( | ||
notify({ | ||
// @ts-ignore | ||
message: error?.data?.error || "Failed to create model", | ||
kind: "warn", | ||
message, | ||
heading, | ||
kind: "error", | ||
}) | ||
); | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How much file size does this add to our bundle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
24.3 kB minified, 8.4kb minified + gzipped