Skip to content

Feature: Schema title bar #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 69 commits into from
Sep 8, 2023
Merged

Feature: Schema title bar #2246

merged 69 commits into from
Sep 8, 2023

Conversation

finnar-bin
Copy link
Contributor

@finnar-bin finnar-bin commented Sep 5, 2023

Closes #2202
Closes #2226
Closes #2247

Dependent on zesty-io/material#80 for the new icon

Preview

all models
search
model view
field select
field input

zcolah

This comment was marked as spam.

zcolah

This comment was marked as spam.

zcolah

This comment was marked as spam.

zcolah

This comment was marked as spam.

@zcolah

This comment was marked as spam.

Copy link

@zcolah zcolah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall Great Job @theofficialnar, please make the following changes to the designs.

  1. Visual QA Feedback on Figma

  2. Make Info Tab Updates in Figma: There is a poor contrast on the Info Tab page due to the change in the background color to Grey.50. I had not anticipated this and hence need to request 4 changes to be made to the content items in the Info Tab. Apologies for the same.

  3. Update Icon of All Models in the Sidebar and in the Breadcrumbs to be database-search (sent the icon SVG on Slack). Please also ensure this PR is connected to this issue. See screenshot below

image

  1. Update API Tab Padding Issues. Currently the API Tab spacing looks to be off. So we need to make two changes specifically as listed below. You can also refer to this Figma file to see the spacing rules.

a. Make the top padding on this div from 16px to 0px.
CleanShot 2023-09-06 at 19 43 56@2x

b. Make the bottom padding on this div from 20px to 16px
CleanShot 2023-09-06 at 19 45 30@2x

Base automatically changed from feature/content-title-bar to master September 6, 2023 20:20
Copy link

@zcolah zcolah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Update the info icon size for the description field in the right sidebar to be 12px by 12px. Note: This is a bug not originally in scope.

  2. Make the color of the title in each field list item to be typography.primary.

CleanShot 2023-09-08 at 04 18 22@2x
  1. Please rename Copy ZUID to Copy Model ZUID
CleanShot 2023-09-08 at 04 19 36@2x
  1. Please rename copy zuid here to "Copy Field ZUID"
CleanShot 2023-09-08 at 04 20 00@2x
  1. Change "As Single Page" to "As a Single Page Model"
CleanShot 2023-09-08 at 04 28 25@2x
  1. Add 16px margin to each field. Please also do this for the deactivated and system fields. This will ensure the scroll bar no more covers the fields.
CleanShot 2023-09-08 at 04 33 17@2x
  1. Remove the right padding of this container.
CleanShot 2023-09-08 at 04 34 02@2x

@zcolah zcolah added the vqa VQA is complete and approved label Sep 8, 2023
@shrunyan shrunyan merged commit 740dcaf into master Sep 8, 2023
@shrunyan shrunyan deleted the feature/schema-title-bar branch September 8, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vqa VQA is complete and approved
Projects
None yet
4 participants