-
Notifications
You must be signed in to change notification settings - Fork 5
Feature: Schema title bar #2246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…er-ui into feature/schema-title-bar
This comment was marked as spam.
This comment was marked as spam.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall Great Job @theofficialnar, please make the following changes to the designs.
-
Make Info Tab Updates in Figma: There is a poor contrast on the Info Tab page due to the change in the background color to Grey.50. I had not anticipated this and hence need to request 4 changes to be made to the content items in the Info Tab. Apologies for the same.
-
Update Icon of All Models in the Sidebar and in the Breadcrumbs to be database-search (sent the icon SVG on Slack). Please also ensure this PR is connected to this issue. See screenshot below
- Update API Tab Padding Issues. Currently the API Tab spacing looks to be off. So we need to make two changes specifically as listed below. You can also refer to this Figma file to see the spacing rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Update the info icon size for the description field in the right sidebar to be 12px by 12px. Note: This is a bug not originally in scope.
-
Make the color of the title in each field list item to be typography.primary.

- Please rename Copy ZUID to Copy Model ZUID

- Please rename copy zuid here to "Copy Field ZUID"

- Change "As Single Page" to "As a Single Page Model"

- Add 16px margin to each field. Please also do this for the deactivated and system fields. This will ensure the scroll bar no more covers the fields.

- Remove the right padding of this container.

Closes #2202
Closes #2226
Closes #2247
Dependent on zesty-io/material#80 for the new icon
Preview