-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
20210302 events queues stores #186
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better logging Multiple SNS send thread in EnrichWorker Better event acknowledging in ConsumerProducer
Also, avoid serializing and deserializing event. The machine metadata should already be in the received serialized event.
Use it with compatible stores
Also: use exit status if available in the run_worker management command.
Do not paginate, but fetch more events
It was never really good…
The matching probes are added during the event enrichment. They are serialized, and used during the event processing. They can be also stored.
Use the serialized probe information to fetch the probe events Replace pagination with "search after" continuation Add time range and event type filters Add links to event stores Make probe dashboard and probe events optional
WARNING the new code used to only remove an event from a SQS queue if the generated events have been successfully published is maybe too much, and needs to be tested at scale. It could be removed, if loosing some events in case a SQS queue or SNS topic is unavailable is acceptable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the event pipeline.
bulk_store
method on the Elasticsearch store to speed up the indexing of the events