improve coverage for pyarrow.struct typehint #157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I ran into a mypy error and would like to fix it upstream.
This is from the docstring of
pyarrow.struct
.To make the last line pass mypy
Iterable[Tuple[str, DataType]]
needs to be added to the stub.The actual implementation is even more permissive, is that needed? I.e.
Iterable[Tuple[x]]
works as long as you can feed x intopyarrow.field
.(https://github.com/apache/arrow/blob/f9a6edac9f175de3ad993887470dd1dff4f151c1/python/pyarrow/types.pxi#L5195)