Feature: Add checks for sound before auto toggling PiP #7796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
Slowlife01
reviewed
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from Arc, I really liked using auto PiP. Enabling it in Zen has been a bit annoying because even muted videos on web pages (such as the muted stream on twitch's home page) are activating auto PiP when you change tabs.
I've added a simple patch in the
actors/PictureInPictureChild.sys.mjsfile that checks if the video player itself is muted and if it is it does not activate PiP when you switch away from that tab.I then added another small patch in
components/PictureInPicture.sys.mjswhich checks whether the tab itself is muted and prevents auto PiP if it is in fact muted.Maybe this behavior should be behind a preference?