Skip to content

[Command] Remove svg from CommandPage, use Icon.Close (like "Search") #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 task
zeh opened this issue Aug 15, 2023 · 0 comments
Open
1 task

[Command] Remove svg from CommandPage, use Icon.Close (like "Search") #31

zeh opened this issue Aug 15, 2023 · 0 comments
Labels
enhancement New feature or request
Milestone
Beta

Comments

@zeh
Copy link
Owner

zeh commented Aug 15, 2023

We have an inlined SVG there for the "close" button. We need to use Icon.Close, like the search input.

In general, all icons should be there (e.g. "copy" and "reset" in the future).

Requirements

  • Drop the inline SVG icon for "close" and use the existing icon
@zeh zeh added this to FFmpeg.app Aug 15, 2023
@zeh zeh converted this from a draft issue Aug 15, 2023
@zeh zeh added the enhancement New feature or request label Aug 15, 2023
@zeh zeh added this to the Beta milestone Aug 15, 2023
@zeh zeh moved this from Todo to Planned in FFmpeg.app Aug 15, 2023
@zeh zeh moved this from Planned to In Progress in FFmpeg.app Aug 16, 2023
zeh added a commit that referenced this issue Aug 16, 2023
@zeh
Command: fix close button
7bb4fbb 
We now reuse the existing icon instead of having a custom SVG.

Closes #31.
zeh added a commit that referenced this issue Aug 18, 2023
@zeh
Command: fix close button
4dc2f84 
We now reuse the existing icon instead of having a custom SVG.

Closes #31.
zeh added a commit that referenced this issue Aug 18, 2023
@zeh
Command: fix close button
a88d4e1 
We now reuse the existing icon instead of having a custom SVG.

Closes #31.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
FFmpeg.app
Status: In Progress
Milestone
Beta
Development

No branches or pull requests
1 participant
@zeh