zcash_keys: Add UnifiedAddressRequest::{SHIELDED, ORCHARD}. #1595
nuttycomaudits.yml
on: pull_request
Required audits have passed
2s
Annotations
444 warnings
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/lib.rs#L2305
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/lib.rs:2305:17
|
2305 | / write!(
2306 | | f,
2307 | | "Requested height {} does not exist in the block cache",
2308 | | height
2309 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/lib.rs#L2298
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/lib.rs:2298:17
|
2298 | / write!(
2299 | | f,
2300 | | "The block cache has corrupted data and this caused an error: {}",
2301 | | e,
2302 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/lib.rs#L2274
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/lib.rs:2274:17
|
2274 | write!(f, "Failed to parse protobuf-encoded record: {}", e)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
2274 - write!(f, "Failed to parse protobuf-encoded record: {}", e)
2274 + write!(f, "Failed to parse protobuf-encoded record: {e}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/lib.rs#L2271
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/lib.rs:2271:17
|
2271 | write!(f, "There was a problem with the sqlite db: {}", e)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
2271 - write!(f, "There was a problem with the sqlite db: {}", e)
2271 + write!(f, "There was a problem with the sqlite db: {e}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/lib.rs#L2268
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/lib.rs:2268:17
|
2268 | write!(f, "Failed to access the file system: {}", io_error)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
2268 - write!(f, "Failed to access the file system: {}", io_error)
2268 + write!(f, "Failed to access the file system: {io_error}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/lib.rs#L246
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/lib.rs:246:45
|
246 | ReceivedNoteId(protocol, id) => write!(f, "Received {:?} Note: {}", protocol, id),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
246 - ReceivedNoteId(protocol, id) => write!(f, "Received {:?} Note: {}", protocol, id),
246 + ReceivedNoteId(protocol, id) => write!(f, "Received {protocol:?} Note: {id}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet.rs#L4328
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet.rs:4328:45
|
4328 | let mut stmt = conn.prepare_cached(&format!(
| _____________________________________________^
4329 | | "SELECT checkpoint_id, position FROM {}_tree_checkpoints
4330 | | ORDER BY checkpoint_id",
4331 | | table_prefix
4332 | | ))?;
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet.rs#L1978
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet.rs:1978:58
|
1978 | SqliteClientError::CorruptedData(format!(
| __________________________________________________________^
1979 | | "Priority code {} not recognized.",
1980 | | raw
1981 | | ))
| |_________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet.rs#L1962
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet.rs:1962:50
|
1962 | SqliteClientError::CorruptedData(format!(
| __________________________________________________^
1963 | | "Negative received note value: {}",
1964 | | value_raw
1965 | | ))
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet.rs#L878
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet.rs:878:59
|
878 | _ => Err(SqliteClientError::CorruptedData(format!(
| ___________________________________________________________^
879 | | "Addresses table contains {} which is not a unified address",
880 | | addr_str,
881 | | ))),
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/transparent.rs#L1069
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/transparent.rs:1069:47
|
1069 | SchedulingError::OutOfRange(t) => write!(f, "Not a valid timestamp or duration: {}", t),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
1069 - SchedulingError::OutOfRange(t) => write!(f, "Not a valid timestamp or duration: {}", t),
1069 + SchedulingError::OutOfRange(t) => write!(f, "Not a valid timestamp or duration: {t}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/transparent.rs#L1068
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/transparent.rs:1068:41
|
1068 | SchedulingError::Time(t) => write!(f, "Invalid system time: {}", t),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
1068 - SchedulingError::Time(t) => write!(f, "Invalid system time: {}", t),
1068 + SchedulingError::Time(t) => write!(f, "Invalid system time: {t}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/transparent.rs#L1066
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/transparent.rs:1066:17
|
1066 | write!(f, "Failure in sampling scheduling time: {}", e)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
1066 - write!(f, "Failure in sampling scheduling time: {}", e)
1066 + write!(f, "Failure in sampling scheduling time: {e}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/transparent.rs#L969
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/transparent.rs:969:46
|
969 | SqliteClientError::CorruptedData(format!("Negative UTXO value {:?}", raw_value))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
969 - SqliteClientError::CorruptedData(format!("Negative UTXO value {:?}", raw_value))
969 + SqliteClientError::CorruptedData(format!("Negative UTXO value {raw_value:?}"))
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/transparent.rs#L926
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/transparent.rs:926:46
|
926 | SqliteClientError::CorruptedData(format!("Negative UTXO value {:?}", raw_value))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
926 - SqliteClientError::CorruptedData(format!("Negative UTXO value {:?}", raw_value))
926 + SqliteClientError::CorruptedData(format!("Negative UTXO value {raw_value:?}"))
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/transparent.rs#L676
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/transparent.rs:676:42
|
676 | SqliteClientError::CorruptedData(format!("Invalid UTXO value: {}", raw_value))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
676 - SqliteClientError::CorruptedData(format!("Invalid UTXO value: {}", raw_value))
676 + SqliteClientError::CorruptedData(format!("Invalid UTXO value: {raw_value}"))
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/transparent.rs#L127
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/transparent.rs:127:46
|
127 | SqliteClientError::CorruptedData(format!(
| ______________________________________________^
128 | | "{} is not a valid transparent child index",
129 | | address_index
130 | | )),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/scanning.rs#L378
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/scanning.rs:378:10
|
378 | &format!(
| __________^
379 | | "SELECT MAX(subtree_end_height) FROM {}_tree_shards",
380 | | table_prefix
381 | | ),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/scanning.rs#L236
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/scanning.rs:236:51
|
236 | let mut shard_end_stmt = conn.prepare_cached(&format!(
| ___________________________________________________^
237 | | "SELECT subtree_end_height
238 | | FROM {}_tree_shards
239 | | WHERE shard_index = :shard_index",
240 | | table_prefix
241 | | ))?;
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/scanning.rs#L182
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/scanning.rs:182:36
|
182 | E::corrupt(format!("scan priority not recognized: {}", code))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
182 - E::corrupt(format!("scan priority not recognized: {}", code))
182 + E::corrupt(format!("scan priority not recognized: {code}"))
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/scanning.rs#L81
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/scanning.rs:81:46
|
81 | SqliteClientError::CorruptedData(format!("scan priority not recognized: {}", code))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
81 - SqliteClientError::CorruptedData(format!("scan priority not recognized: {}", code))
81 + SqliteClientError::CorruptedData(format!("scan priority not recognized: {code}"))
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/sapling.rs#L167
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/sapling.rs:167:54
|
167 | SqliteClientError::CorruptedData(format!(
| ______________________________________________________^
168 | | "Invalid key scope code {}",
169 | | scope_code
170 | | ))
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/orchard.rs#L166
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/orchard.rs:166:54
|
166 | SqliteClientError::CorruptedData(format!(
| ______________________________________________________^
167 | | "Invalid key scope code {}",
168 | | scope_code
169 | | ))
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init.rs#L200
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init.rs:200:13
|
200 | format!("Wallet DB contains unsupported pool type {}", pool),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
200 - format!("Wallet DB contains unsupported pool type {}", pool),
200 + format!("Wallet DB contains unsupported pool type {pool}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init.rs#L149
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init.rs:149:17
|
149 | / write!(
150 | | f,
151 | | "Unexpected violation of database business rules: {}",
152 | | err
153 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init.rs#L146
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init.rs:146:17
|
146 | write!(f, "Reverting migration {} is not supported", uuid)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
146 - write!(f, "Reverting migration {} is not supported", uuid)
146 + write!(f, "Reverting migration {uuid} is not supported")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init.rs#L143
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init.rs:143:17
|
143 | write!(f, "Address generation error: {:?}", e)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
143 - write!(f, "Address generation error: {:?}", e)
143 + write!(f, "Address generation error: {e:?}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init.rs#L141
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init.rs:141:56
|
141 | WalletMigrationError::CommitmentTree(e) => write!(f, "Commitment tree error: {:?}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
141 - WalletMigrationError::CommitmentTree(e) => write!(f, "Commitment tree error: {:?}", e),
141 + WalletMigrationError::CommitmentTree(e) => write!(f, "Commitment tree error: {e:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init.rs#L140
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init.rs:140:54
|
140 | WalletMigrationError::BalanceError(e) => write!(f, "Balance error: {:?}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
140 - WalletMigrationError::BalanceError(e) => write!(f, "Balance error: {:?}", e),
140 + WalletMigrationError::BalanceError(e) => write!(f, "Balance error: {e:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init.rs#L139
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init.rs:139:49
|
139 | WalletMigrationError::DbError(e) => write!(f, "{}", e),
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
139 - WalletMigrationError::DbError(e) => write!(f, "{}", e),
139 + WalletMigrationError::DbError(e) => write!(f, "{e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init.rs#L137
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init.rs:137:17
|
137 | write!(f, "Wallet database is corrupted: {}", reason)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
137 - write!(f, "Wallet database is corrupted: {}", reason)
137 + write!(f, "Wallet database is corrupted: {reason}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init.rs#L118
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init.rs:118:17
|
118 | / write!(
119 | | f,
120 | | "The installed SQLite version {} does not support operations required by the wallet.",
121 | | version
122 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/v_transactions_note_uniqueness.rs#L248
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/v_transactions_note_uniqueness.rs:248:25
|
248 | / panic!(
249 | | "Account {:?} is not expected to exist in the wallet.",
250 | | other
251 | | );
| |_________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/v_transactions_net.rs#L587
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/v_transactions_net.rs:587:25
|
587 | / panic!(
588 | | "Unexpected output pool and index for tx {}: {:?}.",
589 | | tx, other
590 | | );
| |_________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
components/zcash_protocol/src/memo.rs#L46
warning: variables can be used directly in the `format!` string
--> components/zcash_protocol/src/memo.rs:46:34
|
46 | Error::TooLong(n) => write!(f, "Memo length {} is larger than maximum of 512", n),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
46 - Error::TooLong(n) => write!(f, "Memo length {} is larger than maximum of 512", n),
46 + Error::TooLong(n) => write!(f, "Memo length {n} is larger than maximum of 512"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/v_transactions_net.rs#L553
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/v_transactions_net.rs:553:25
|
553 | / panic!(
554 | | "Unexpected output pool and index for tx {}: {:?}.",
555 | | tx, other
556 | | );
| |_________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
components/zcash_protocol/src/memo.rs#L45
warning: variables can be used directly in the `format!` string
--> components/zcash_protocol/src/memo.rs:45:38
|
45 | Error::InvalidUtf8(e) => write!(f, "Invalid UTF-8: {}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
45 - Error::InvalidUtf8(e) => write!(f, "Invalid UTF-8: {}", e),
45 + Error::InvalidUtf8(e) => write!(f, "Invalid UTF-8: {e}"),
|
|
|
variables can be used directly in the `format!` string:
components/zcash_protocol/src/memo.rs#L25
warning: variables can be used directly in the `format!` string
--> components/zcash_protocol/src/memo.rs:25:9
|
25 | write!(f, "{:02x}", byte)?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
25 - write!(f, "{:02x}", byte)?;
25 + write!(f, "{byte:02x}")?;
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/v_transactions_net.rs#L508
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/v_transactions_net.rs:508:25
|
508 | panic!("Unexpected output index for tx {}: {}.", tx, other);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
508 - panic!("Unexpected output index for tx {}: {}.", tx, other);
508 + panic!("Unexpected output index for tx {tx}: {other}.");
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/v_transactions_net.rs#L456
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/v_transactions_net.rs:456:25
|
456 | panic!("(Account, Transaction) pair {:?} is not expected to exist in the wallet.", other);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
456 - panic!("(Account, Transaction) pair {:?} is not expected to exist in the wallet.", other);
456 + panic!("(Account, Transaction) pair {other:?} is not expected to exist in the wallet.");
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/v_transactions_net.rs#L390
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/v_transactions_net.rs:390:25
|
390 | panic!("Transaction {} is not a sent tx.", other);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
390 - panic!("Transaction {} is not a sent tx.", other);
390 + panic!("Transaction {other} is not a sent tx.");
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/ufvk_support.rs#L261
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/ufvk_support.rs:261:57
|
261 | WalletMigrationError::CorruptedData(format!(
| _________________________________________________________^
262 | | "Could not decode {} as a valid Zcash address.",
263 | | address
264 | | ))
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/transparent_gap_limit_handling.rs#L140
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/transparent_gap_limit_handling.rs:140:53
|
140 | WalletMigrationError::CorruptedData(format!(
| _____________________________________________________^
141 | | "Invalid UIVK encoding {}: {}",
142 | | uivk_str, e
143 | | ))
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/transparent_gap_limit_handling.rs#L93
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/transparent_gap_limit_handling.rs:93:21
|
93 | format!("{} is not a valid transparent child index.", i),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
93 - format!("{} is not a valid transparent child index.", i),
93 + format!("{i} is not a valid transparent child index."),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/sapling_memo_consistency.rs#L105
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/sapling_memo_consistency.rs:105:57
|
105 | WalletMigrationError::CorruptedData(format!(
| _________________________________________________________^
106 | | "Transaction not found for id {:?}",
107 | | txid
108 | | ))
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/sapling_memo_consistency.rs#L99
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/sapling_memo_consistency.rs:99:66
|
99 | other => WalletMigrationError::CorruptedData(format!(
| __________________________________________________________________^
100 | | "An error was encountered decoding transaction data: {:?}",
101 | | other
102 | | )),
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/sapling_memo_consistency.rs#L71
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/sapling_memo_consistency.rs:71:53
|
71 | WalletMigrationError::CorruptedData(format!(
| _____________________________________________________^
72 | | "Could not decode unified full viewing key for account {}: {:?}",
73 | | account, e
74 | | ))
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/receiving_key_scopes.rs#L229
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/receiving_key_scopes.rs:229:65
|
229 | ... WalletMigrationError::CorruptedData(format!(
| ___________________________________________________________^
230 | | ... "Note {} is invalid",
231 | | ... note_id
232 | | ... ))
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/receiving_key_scopes.rs#L199
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/receiving_key_scopes.rs:199:25
|
199 | panic!("A Sapling output must exist at index {}", output_index)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
199 - panic!("A Sapling output must exist at index {}", output_index)
199 + panic!("A Sapling output must exist at index {output_index}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/receiving_key_scopes.rs#L190
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/receiving_key_scopes.rs:190:57
|
190 | WalletMigrationError::CorruptedData(format!(
| _________________________________________________________^
191 | | "Unable to parse raw transaction: {:?}",
192 | | e
193 | | ))
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/receiving_key_scopes.rs#L177
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/receiving_key_scopes.rs:177:53
|
177 | WalletMigrationError::CorruptedData(format!("Stored UFVK was invalid: {:?}", e))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
177 - WalletMigrationError::CorruptedData(format!("Stored UFVK was invalid: {:?}", e))
177 + WalletMigrationError::CorruptedData(format!("Stored UFVK was invalid: {e:?}"))
|
|
|
variables can be used directly in the `format!` string:
zcash_transparent/src/address.rs#L290
warning: variables can be used directly in the `format!` string
--> zcash_transparent/src/address.rs:290:39
|
290 | let encoded = format!("{:02x}", b);
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
290 - let encoded = format!("{:02x}", b);
290 + let encoded = format!("{b:02x}");
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/receiving_key_scopes.rs#L85
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/receiving_key_scopes.rs:85:49
|
85 | WalletMigrationError::CorruptedData(format!(
| _________________________________________________^
86 | | "Error querying note commitment tree: {:?}",
87 | | e
88 | | ))
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/received_notes_nullable_nf.rs#L374
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/received_notes_nullable_nf.rs:374:25
|
374 | panic!("(Account, Transaction) pair {:?} is not expected to exist in the wallet.", other);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
374 - panic!("(Account, Transaction) pair {:?} is not expected to exist in the wallet.", other);
374 + panic!("(Account, Transaction) pair {other:?} is not expected to exist in the wallet.");
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/received_notes_nullable_nf.rs#L310
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/received_notes_nullable_nf.rs:310:25
|
310 | panic!("(Account, Transaction) pair {:?} is not expected to exist in the wallet.", other);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
310 - panic!("(Account, Transaction) pair {:?} is not expected to exist in the wallet.", other);
310 + panic!("(Account, Transaction) pair {other:?} is not expected to exist in the wallet.");
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/ensure_orchard_ua_receiver.rs#L202
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/ensure_orchard_ua_receiver.rs:202:22
|
202 | other => panic!("Unexpected result from address decoding: {:?}", other),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
202 - other => panic!("Unexpected result from address decoding: {:?}", other),
202 + other => panic!("Unexpected result from address decoding: {other:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/ensure_orchard_ua_receiver.rs#L182
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/ensure_orchard_ua_receiver.rs:182:22
|
182 | other => panic!("Unexpected result from address decoding: {:?}", other),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
182 - other => panic!("Unexpected result from address decoding: {:?}", other),
182 + other => panic!("Unexpected result from address decoding: {other:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/add_transaction_views.rs#L107
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/add_transaction_views.rs:107:57
|
107 | ... FeeError::CorruptedData(format!(
| _______________________________________________^
108 | | ... "UTXO amount out of range in outpoint {:?}",
109 | | ... op
110 | | ... ))
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/add_transaction_views.rs#L89
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/add_transaction_views.rs:89:57
|
89 | WalletMigrationError::CorruptedData(format!(
| _________________________________________________________^
90 | | "Parsing failed for transaction {:?}: {:?}",
91 | | id_tx, e
92 | | ))
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/encoding.rs#L120
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/encoding.rs:120:59
|
120 | other => Err(SqliteClientError::CorruptedData(format!(
| ___________________________________________________________^
121 | | "Invalid key scope code: {}",
122 | | other
123 | | ))),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/common.rs#L388
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/common.rs:388:46
|
388 | SqliteClientError::CorruptedData(format!("Negative received note value: {}", value))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
388 - SqliteClientError::CorruptedData(format!("Negative received note value: {}", value))
388 + SqliteClientError::CorruptedData(format!("Negative received note value: {value}"))
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/serialization/shardtree.rs#L94
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/serialization/shardtree.rs:94:13
|
94 | format!("Shard serialization version not recognized: {}", other),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
94 - format!("Shard serialization version not recognized: {}", other),
94 + format!("Shard serialization version not recognized: {other}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/serialization/shardtree.rs#L79
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/serialization/shardtree.rs:79:13
|
79 | format!("Node tag not recognized: {}", other),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
79 - format!("Node tag not recognized: {}", other),
79 + format!("Node tag not recognized: {other}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/serialization/shardtree.rs#L67
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/serialization/shardtree.rs:67:25
|
67 | / format!(
68 | | "Byte value {} does not correspond to a valid set of retention flags",
69 | | bits
70 | | ),
| |_________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/sync.rs#L575
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/sync.rs:575:33
|
575 | Error::Wallet(e) => write!(f, "Error while interacting with wallet database: {}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
575 - Error::Wallet(e) => write!(f, "Error while interacting with wallet database: {}", e),
575 + Error::Wallet(e) => write!(f, "Error while interacting with wallet database: {e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/sync.rs#L570
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/sync.rs:570:33
|
570 | Error::Server(e) => write!(
| _________________________________^
571 | | f,
572 | | "Error while communicating with lightwalletd server: {}",
573 | | e
574 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/sync.rs#L569
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/sync.rs:569:31
|
569 | Error::Scan(e) => write!(f, "Error while scanning blocks: {}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
569 - Error::Scan(e) => write!(f, "Error while scanning blocks: {}", e),
569 + Error::Scan(e) => write!(f, "Error while scanning blocks: {e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/sync.rs#L567
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/sync.rs:567:32
|
567 | Error::Cache(e) => write!(f, "Error while interacting with block cache: {}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
567 - Error::Cache(e) => write!(f, "Error while interacting with block cache: {}", e),
567 + Error::Cache(e) => write!(f, "Error while interacting with block cache: {e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L1085
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:1085:26
|
1085 | .prepare_cached(&format!(
| __________________________^
1086 | | "INSERT INTO {}_tree_shards (shard_index, subtree_end_height, root_hash, shard_data)
1087 | | VALUES (:shard_index, :subtree_end_height, :root_hash, :shard_data)
1088 | | ON CONFLICT (shard_index) DO UPDATE
1089 | | SET subtree_end_height = :subtree_end_height, root_hash = :root_hash",
1090 | | table_prefix
1091 | | ))
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L1055
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:1055:13
|
1055 | format!("Note commitment tree cap was invalid at address {:?}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
1055 - format!("Note commitment tree cap was invalid at address {:?}", e),
1055 + format!("Note commitment tree cap was invalid at address {e:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L986
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:986:10
|
986 | &format!(
| __________^
987 | | "DELETE FROM {}_tree_checkpoint_marks_removed WHERE checkpoint_id = ?",
988 | | table_prefix
989 | | ),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L976
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:976:10
|
976 | &format!(
| __________^
977 | | "DELETE FROM {}_tree_checkpoints WHERE checkpoint_id > ?",
978 | | table_prefix
979 | | ),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L954
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:954:26
|
954 | .prepare_cached(&format!(
| __________________________^
955 | | "DELETE FROM {}_tree_checkpoints
956 | | WHERE checkpoint_id = :checkpoint_id",
957 | | table_prefix
958 | | ))
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L880
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:880:26
|
880 | .prepare_cached(&format!(
| __________________________^
881 | | "SELECT checkpoint_id, position
882 | | FROM {}_tree_checkpoints
883 | | ORDER BY position
884 | | LIMIT :limit",
885 | | table_prefix
886 | | ))
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L847
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:847:49
|
847 | let mut stmt = conn.prepare_cached(&format!(
| _________________________________________________^
848 | | "SELECT mark_removed_position
849 | | FROM {}_tree_checkpoint_marks_removed
850 | | WHERE checkpoint_id = ?",
851 | | table_prefix
852 | | ))?;
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L825
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:825:14
|
825 | &format!(
| ______________^
826 | | "SELECT checkpoint_id, position
827 | | FROM {}_tree_checkpoints
828 | | ORDER BY checkpoint_id DESC
... |
831 | | table_prefix
832 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L804
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:804:10
|
804 | &format!(
| __________^
805 | | "SELECT checkpoint_id
806 | | FROM {}_tree_checkpoints
807 | | WHERE checkpoint_id <= :max_checkpoint_height
... |
810 | | table_prefix
811 | | ),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L767
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:767:14
|
767 | &format!(
| ______________^
768 | | "SELECT position
769 | | FROM {}_tree_checkpoints
770 | | WHERE checkpoint_id = ?",
771 | | table_prefix
772 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L743
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:743:26
|
743 | .prepare_cached(&format!(
| __________________________^
744 | | "SELECT mark_removed_position
745 | | FROM {}_tree_checkpoint_marks_removed
746 | | WHERE checkpoint_id = ?",
747 | | table_prefix
748 | | ))
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L730
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:730:10
|
730 | &format!("SELECT COUNT(*) FROM {}_tree_checkpoints", table_prefix),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
730 - &format!("SELECT COUNT(*) FROM {}_tree_checkpoints", table_prefix),
730 + &format!("SELECT COUNT(*) FROM {table_prefix}_tree_checkpoints"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L704
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:704:34
|
704 | .prepare_cached(&format!(
| __________________________________^
705 | | "INSERT INTO {}_tree_checkpoint_marks_removed (checkpoint_id, mark_removed_position)
706 | | VALUES (:checkpoint_id, :position)",
707 | | table_prefix
708 | | ))
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L689
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:689:34
|
689 | .prepare_cached(&format!(
| __________________________________^
690 | | "INSERT INTO {}_tree_checkpoints (checkpoint_id, position)
691 | | VALUES (:checkpoint_id, :position)",
692 | | table_prefix
693 | | ))
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L642
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:642:14
|
642 | &format!(
| ______________^
643 | | "SELECT position FROM {}_tree_checkpoints WHERE checkpoint_id = :checkpoint_id",
644 | | table_prefix
645 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L621
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:621:10
|
621 | &format!(
| __________^
622 | | "SELECT MAX(checkpoint_id) FROM {}_tree_checkpoints",
623 | | table_prefix
624 | | ),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L603
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:603:10
|
603 | &format!(
| __________^
604 | | "SELECT MIN(checkpoint_id) FROM {}_tree_checkpoints",
605 | | table_prefix
606 | | ),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L582
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:582:26
|
582 | .prepare_cached(&format!(
| __________________________^
583 | | "INSERT INTO {}_tree_cap (cap_id, cap_data)
584 | | VALUES (0, :cap_data)
585 | | ON CONFLICT (cap_id) DO UPDATE
586 | | SET cap_data = :cap_data",
587 | | table_prefix
588 | | ))
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L563
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:563:10
|
563 | &format!("SELECT cap_data FROM {}_tree_cap", table_prefix),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
563 - &format!("SELECT cap_data FROM {}_tree_cap", table_prefix),
563 + &format!("SELECT cap_data FROM {table_prefix}_tree_cap"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L547
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:547:10
|
547 | &format!(
| __________^
548 | | "DELETE FROM {}_tree_shards WHERE shard_index >= ?",
549 | | table_prefix
550 | | ),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L524
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:524:19
|
524 | .prepare(&format!(
| ___________________^
525 | | "SELECT shard_index FROM {}_tree_shards ORDER BY shard_index",
526 | | table_prefix
527 | | ))
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L497
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:497:26
|
497 | .prepare_cached(&format!(
| __________________________^
498 | | "INSERT INTO {}_tree_shards (shard_index, root_hash, shard_data)
499 | | VALUES (:shard_index, :root_hash, :shard_data)
500 | | ON CONFLICT (shard_index) DO UPDATE
... |
503 | | table_prefix
504 | | ))
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L438
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:438:14
|
438 | &format!(
| ______________^
439 | | "SELECT MIN(shard_index), MAX(shard_index) FROM {}_tree_shards",
440 | | table_prefix
441 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L420
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:420:17
|
420 | format!("Tree contained invalid data at address {:?}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
420 - format!("Tree contained invalid data at address {:?}", e),
420 + format!("Tree contained invalid data at address {e:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L398
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:398:10
|
398 | &format!(
| __________^
399 | | "SELECT shard_index, shard_data
400 | | FROM {}_tree_shards
401 | | ORDER BY shard_index DESC
402 | | LIMIT 1",
403 | | table_prefix
404 | | ),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L379
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:379:21
|
379 | format!("Tree contained invalid data at address {:?}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
379 - format!("Tree contained invalid data at address {:?}", e),
379 + format!("Tree contained invalid data at address {e:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L362
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:362:10
|
362 | &format!(
| __________^
363 | | "SELECT shard_data, root_hash
364 | | FROM {}_tree_shards
365 | | WHERE shard_index = :shard_index",
366 | | table_prefix
367 | | ),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L76
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:76:17
|
76 | / write!(
77 | | f,
78 | | "Attempted to write subtree roots with indices {:?} which is discontinuous with existing subtree range {:?}",
79 | | attempted_insertion_range, existing_range,
80 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L66
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:66:17
|
66 | / write!(
67 | | f,
68 | | "Conflict at checkpoint id {}, tried to insert {:?}, which is incompatible with existing state ({:?}, {:?})",
69 | | checkpoint_id, checkpoint, extant_tree_state, extant_marks_removed
70 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L59
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:59:34
|
59 | Error::Query(err) => write!(f, "Commitment tree query or update error: {}", err),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
59 - Error::Query(err) => write!(f, "Commitment tree query or update error: {}", err),
59 + Error::Query(err) => write!(f, "Commitment tree query or update error: {err}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L58
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:58:42
|
58 | Error::Serialization(err) => write!(f, "Commitment tree serialization error: {}", err),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
58 - Error::Serialization(err) => write!(f, "Commitment tree serialization error: {}", err),
58 + Error::Serialization(err) => write!(f, "Commitment tree serialization error: {err}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L224
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:224:17
|
224 | write!(f, "The wallet was unable to schedule an event: {}", err)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
224 - write!(f, "The wallet was unable to schedule an event: {}", err)
224 + write!(f, "The wallet was unable to schedule an event: {err}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L220
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:220:17
|
220 | write!(f, "The address {address_str} previously used in txid(s) {:?} would be reused.", txids)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
220 - write!(f, "The address {address_str} previously used in txid(s) {:?} would be reused.", txids)
220 + write!(f, "The address {address_str} previously used in txid(s) {txids:?} would be reused.")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L200
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:200:56
|
200 | SqliteClientError::NoteFilterInvalid(s) => write!(f, "Could not evaluate filter query: {:?}", s),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
200 - SqliteClientError::NoteFilterInvalid(s) => write!(f, "Could not evaluate filter query: {:?}", s),
200 + SqliteClientError::NoteFilterInvalid(s) => write!(f, "Could not evaluate filter query: {s:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L199
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:199:51
|
199 | SqliteClientError::BalanceError(e) => write!(f, "Balance error: {}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
199 - SqliteClientError::BalanceError(e) => write!(f, "Balance error: {}", e),
199 + SqliteClientError::BalanceError(e) => write!(f, "Balance error: {e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L198
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:198:58
|
198 | SqliteClientError::UnsupportedPoolType(t) => write!(f, "Pool type is not currently supported: {}", t),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
198 - SqliteClientError::UnsupportedPoolType(t) => write!(f, "Pool type is not currently supported: {}", t),
198 + SqliteClientError::UnsupportedPoolType(t) => write!(f, "Pool type is not currently supported: {t}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L196
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:196:53
|
196 | SqliteClientError::CacheMiss(height) => write!(f, "Requested height {} does not exist in the block cache.", height),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
196 - SqliteClientError::CacheMiss(height) => write!(f, "Requested height {} does not exist in the block cache.", height),
196 + SqliteClientError::CacheMiss(height) => write!(f, "Requested height {height} does not exist in the block cache."),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L195
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:195:55
|
195 | ...CommitmentTree(err) => write!(f, "An error occurred accessing or updating note commitment tree data: {}.", err),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
195 - SqliteClientError::CommitmentTree(err) => write!(f, "An error occurred accessing or updating note commitment tree data: {}.", err),
195 + SqliteClientError::CommitmentTree(err) => write!(f, "An error occurred accessing or updating note commitment tree data: {err}."),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L190
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:190:53
|
190 | SqliteClientError::BadAccountData(e) => write!(f, "Failed to add account: {}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
190 - SqliteClientError::BadAccountData(e) => write!(f, "Failed to add account: {}", e),
190 + SqliteClientError::BadAccountData(e) => write!(f, "Failed to add account: {e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L186
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:186:56
|
186 | SqliteClientError::AddressGeneration(e) => write!(f, "{}", e),
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
186 - SqliteClientError::AddressGeneration(e) => write!(f, "{}", e),
186 + SqliteClientError::AddressGeneration(e) => write!(f, "{e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L183
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:183:50
|
183 | SqliteClientError::InvalidMemo(e) => write!(f, "{}", e),
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
183 - SqliteClientError::InvalidMemo(e) => write!(f, "{}", e),
183 + SqliteClientError::InvalidMemo(e) => write!(f, "{e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L182
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:182:41
|
182 | SqliteClientError::Io(e) => write!(f, "{}", e),
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
182 - SqliteClientError::Io(e) => write!(f, "{}", e),
182 + SqliteClientError::Io(e) => write!(f, "{e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L181
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:181:46
|
181 | SqliteClientError::DbError(e) => write!(f, "{}", e),
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
181 - SqliteClientError::DbError(e) => write!(f, "{}", e),
181 + SqliteClientError::DbError(e) => write!(f, "{e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L179
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:179:57
|
179 | SqliteClientError::TransparentAddress(e) => write!(f, "{}", e),
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
179 - SqliteClientError::TransparentAddress(e) => write!(f, "{}", e),
179 + SqliteClientError::TransparentAddress(e) => write!(f, "{e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L177
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:177:60
|
177 | SqliteClientError::TransparentDerivation(e) => write!(f, "{:?}", e),
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
177 - SqliteClientError::TransparentDerivation(e) => write!(f, "{:?}", e),
177 + SqliteClientError::TransparentDerivation(e) => write!(f, "{e:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L172
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:172:76
|
172 | safe_rewind_height.map_or("<unavailable>".to_owned(), |h0| format!("{}", h0)),
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
172 - safe_rewind_height.map_or("<unavailable>".to_owned(), |h0| format!("{}", h0)),
172 + safe_rewind_height.map_or("<unavailable>".to_owned(), |h0| format!("{h0}")),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L167
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:167:47
|
167 | SqliteClientError::Protobuf(e) => write!(f, "Failed to parse protobuf-encoded record: {}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
167 - SqliteClientError::Protobuf(e) => write!(f, "Failed to parse protobuf-encoded record: {}", e),
167 + SqliteClientError::Protobuf(e) => write!(f, "Failed to parse protobuf-encoded record: {e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L165
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:165:17
|
165 | write!(f, "Data DB is corrupted: {}", reason)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
165 - write!(f, "Data DB is corrupted: {}", reason)
165 + write!(f, "Data DB is corrupted: {reason}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/scanning.rs#L472
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/scanning.rs:472:17
|
472 | ... write!(f, "Received invalid (potentially default) {:?} note commitment tree size metadata at height {}", protocol, at_height)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
472 - write!(f, "Received invalid (potentially default) {:?} note commitment tree size metadata at height {}", protocol, at_height)
472 + write!(f, "Received invalid (potentially default) {protocol:?} note commitment tree size metadata at height {at_height}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/scanning.rs#L469
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/scanning.rs:469:17
|
469 | write!(f, "Unable to determine {:?} note commitment tree size at height {}", protocol, at_height)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
469 - write!(f, "Unable to determine {:?} note commitment tree size at height {}", protocol, at_height)
469 + write!(f, "Unable to determine {protocol:?} note commitment tree size at height {at_height}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/scanning.rs#L466
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/scanning.rs:466:17
|
466 | ... write!(f, "The {:?} note commitment tree size provided by a compact block did not match the expected size at height {}; given {}, expected {}", protocol, at_height, given, computed)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
466 - write!(f, "The {:?} note commitment tree size provided by a compact block did not match the expected size at height {}; given {}, expected {}", protocol, at_height, given, computed)
466 + write!(f, "The {protocol:?} note commitment tree size provided by a compact block did not match the expected size at height {at_height}; given {given}, expected {computed}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/scanning.rs#L463
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/scanning.rs:463:17
|
463 | write!(f, "Block height discontinuity at height {}; previous height was: {}", new_height, prev_height)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
463 - write!(f, "Block height discontinuity at height {}; previous height was: {}", new_height, prev_height)
463 + write!(f, "Block height discontinuity at height {new_height}; previous height was: {prev_height}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/scanning.rs#L457
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/scanning.rs:457:47
|
457 | PrevHashMismatch { at_height } => write!(
| _______________________________________________^
458 | | f,
459 | | "The parent hash of proposed block does not correspond to the block hash at height {}.",
460 | | at_height
461 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/scanning.rs#L452
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/scanning.rs:452:63
|
452 | EncodingInvalid { txid, pool_type, index, .. } => write!(
| _______________________________________________________________^
453 | | f,
454 | | "{:?} output {} of transaction {} was improperly encoded.",
455 | | pool_type, index, txid
456 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proto.rs#L502
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proto.rs:502:60
|
502 | ProposalDecodingError::ProposalInvalid(err) => write!(f, "{}", err),
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
502 - ProposalDecodingError::ProposalInvalid(err) => write!(f, "{}", err),
502 + ProposalDecodingError::ProposalInvalid(err) => write!(f, "{err}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proto.rs#L496
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proto.rs:496:17
|
496 | / write!(
497 | | f,
498 | | "Fee calculation using the {:?} fee rule is not supported.",
499 | | r
500 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proto.rs#L493
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proto.rs:493:17
|
493 | write!(f, "Unrecognized proposal version {}", v)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
493 - write!(f, "Unrecognized proposal version {}", v)
493 + write!(f, "Unrecognized proposal version {v}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proto.rs#L490
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proto.rs:490:17
|
490 | write!(f, "An error occurred decoding a proposed memo: {}", err)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
490 - write!(f, "An error occurred decoding a proposed memo: {}", err)
490 + write!(f, "An error occurred decoding a proposed memo: {err}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proto.rs#L481
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proto.rs:481:70
|
481 | ProposalDecodingError::InputNotFound(txid, pool, idx) => write!(
| ______________________________________________________________________^
482 | | f,
483 | | "No {} input found for txid {}, index {}",
484 | | pool, txid, idx
485 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proto.rs#L476
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proto.rs:476:59
|
476 | ProposalDecodingError::InputRetrieval(err) => write!(
| ___________________________________________________________^
477 | | f,
478 | | "An error occurred retrieving a transaction input: {}",
479 | | err
480 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proto.rs#L474
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proto.rs:474:17
|
474 | write!(f, "Invalid value pool identifier: {:?}", id)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
474 - write!(f, "Invalid value pool identifier: {:?}", id)
474 + write!(f, "Invalid value pool identifier: {id:?}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proto.rs#L466
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proto.rs:466:51
|
466 | ProposalDecodingError::Zip321(err) => write!(f, "Transaction request invalid: {}", err),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
466 - ProposalDecodingError::Zip321(err) => write!(f, "Transaction request invalid: {}", err),
466 + ProposalDecodingError::Zip321(err) => write!(f, "Transaction request invalid: {err}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proto.rs#L376
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proto.rs:376:21
|
376 | format!("Hex decoding of Orchard tree bytes failed: {:?}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
376 - format!("Hex decoding of Orchard tree bytes failed: {:?}", e),
376 + format!("Hex decoding of Orchard tree bytes failed: {e:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proto.rs#L355
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proto.rs:355:21
|
355 | format!("Hex decoding of Sapling tree bytes failed: {:?}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
355 - format!("Hex decoding of Sapling tree bytes failed: {:?}", e),
355 + format!("Hex decoding of Sapling tree bytes failed: {e:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/lib.rs#L2305
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/lib.rs:2305:17
|
2305 | / write!(
2306 | | f,
2307 | | "Requested height {} does not exist in the block cache",
2308 | | height
2309 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/lib.rs#L2298
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/lib.rs:2298:17
|
2298 | / write!(
2299 | | f,
2300 | | "The block cache has corrupted data and this caused an error: {}",
2301 | | e,
2302 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/lib.rs#L2274
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/lib.rs:2274:17
|
2274 | write!(f, "Failed to parse protobuf-encoded record: {}", e)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
2274 - write!(f, "Failed to parse protobuf-encoded record: {}", e)
2274 + write!(f, "Failed to parse protobuf-encoded record: {e}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/lib.rs#L2271
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/lib.rs:2271:17
|
2271 | write!(f, "There was a problem with the sqlite db: {}", e)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
2271 - write!(f, "There was a problem with the sqlite db: {}", e)
2271 + write!(f, "There was a problem with the sqlite db: {e}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/lib.rs#L2268
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/lib.rs:2268:17
|
2268 | write!(f, "Failed to access the file system: {}", io_error)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
2268 - write!(f, "Failed to access the file system: {}", io_error)
2268 + write!(f, "Failed to access the file system: {io_error}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/lib.rs#L246
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/lib.rs:246:45
|
246 | ReceivedNoteId(protocol, id) => write!(f, "Received {:?} Note: {}", protocol, id),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
246 - ReceivedNoteId(protocol, id) => write!(f, "Received {:?} Note: {}", protocol, id),
246 + ReceivedNoteId(protocol, id) => write!(f, "Received {protocol:?} Note: {id}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet.rs#L4328
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet.rs:4328:45
|
4328 | let mut stmt = conn.prepare_cached(&format!(
| _____________________________________________^
4329 | | "SELECT checkpoint_id, position FROM {}_tree_checkpoints
4330 | | ORDER BY checkpoint_id",
4331 | | table_prefix
4332 | | ))?;
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proposal.rs#L113
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proposal.rs:113:61
|
113 | ProposalError::EphemeralOutputLeftUnspent(r) => write!(
| _____________________________________________________________^
114 | | f,
115 | | "The proposal created an ephemeral output at step {:?} that was not spent in any later step.",
116 | | r,
117 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proposal.rs#L93
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proposal.rs:93:50
|
93 | ProposalError::StepDoubleSpend(r) => write!(
| __________________________________________________^
94 | | f,
95 | | "The proposal uses the output of step {:?} in more than one place.",
96 | | r
97 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet.rs#L1978
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet.rs:1978:58
|
1978 | SqliteClientError::CorruptedData(format!(
| __________________________________________________________^
1979 | | "Priority code {} not recognized.",
1980 | | raw
1981 | | ))
| |_________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proposal.rs#L88
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proposal.rs:88:17
|
88 | write!(f, "Unable to compute anchor for block height {:?}", h)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
88 - write!(f, "Unable to compute anchor for block height {:?}", h)
88 + write!(f, "Unable to compute anchor for block height {h:?}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/fees.rs#L272
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/fees.rs:272:17
|
272 | / write!(
273 | | f,
274 | | "The proposed transaction structure violates bundle type constraints: {}",
275 | | err
276 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/fees.rs#L269
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/fees.rs:269:17
|
269 | write!(f, "{}", err)
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
269 - write!(f, "{}", err)
269 + write!(f, "{err}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet.rs#L878
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet.rs:878:59
|
878 | _ => Err(SqliteClientError::CorruptedData(format!(
| ___________________________________________________________^
879 | | "Addresses table contains {} which is not a unified address",
880 | | addr_str,
881 | | ))),
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/transparent.rs#L1069
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/transparent.rs:1069:47
|
1069 | SchedulingError::OutOfRange(t) => write!(f, "Not a valid timestamp or duration: {}", t),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
1069 - SchedulingError::OutOfRange(t) => write!(f, "Not a valid timestamp or duration: {}", t),
1069 + SchedulingError::OutOfRange(t) => write!(f, "Not a valid timestamp or duration: {t}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/transparent.rs#L1066
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/transparent.rs:1066:17
|
1066 | write!(f, "Failure in sampling scheduling time: {}", e)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
1066 - write!(f, "Failure in sampling scheduling time: {}", e)
1066 + write!(f, "Failure in sampling scheduling time: {e}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/transparent.rs#L969
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/transparent.rs:969:46
|
969 | SqliteClientError::CorruptedData(format!("Negative UTXO value {:?}", raw_value))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
969 - SqliteClientError::CorruptedData(format!("Negative UTXO value {:?}", raw_value))
969 + SqliteClientError::CorruptedData(format!("Negative UTXO value {raw_value:?}"))
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/transparent.rs#L926
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/transparent.rs:926:46
|
926 | SqliteClientError::CorruptedData(format!("Negative UTXO value {:?}", raw_value))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
926 - SqliteClientError::CorruptedData(format!("Negative UTXO value {:?}", raw_value))
926 + SqliteClientError::CorruptedData(format!("Negative UTXO value {raw_value:?}"))
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/transparent.rs#L676
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/transparent.rs:676:42
|
676 | SqliteClientError::CorruptedData(format!("Invalid UTXO value: {}", raw_value))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
676 - SqliteClientError::CorruptedData(format!("Invalid UTXO value: {}", raw_value))
676 + SqliteClientError::CorruptedData(format!("Invalid UTXO value: {raw_value}"))
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/transparent.rs#L127
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/transparent.rs:127:46
|
127 | SqliteClientError::CorruptedData(format!(
| ______________________________________________^
128 | | "{} is not a valid transparent child index",
129 | | address_index
130 | | )),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/scanning.rs#L378
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/scanning.rs:378:10
|
378 | &format!(
| __________^
379 | | "SELECT MAX(subtree_end_height) FROM {}_tree_shards",
380 | | table_prefix
381 | | ),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/scanning.rs#L182
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/scanning.rs:182:36
|
182 | E::corrupt(format!("scan priority not recognized: {}", code))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
182 - E::corrupt(format!("scan priority not recognized: {}", code))
182 + E::corrupt(format!("scan priority not recognized: {code}"))
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/scanning.rs#L81
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/scanning.rs:81:46
|
81 | SqliteClientError::CorruptedData(format!("scan priority not recognized: {}", code))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
81 - SqliteClientError::CorruptedData(format!("scan priority not recognized: {}", code))
81 + SqliteClientError::CorruptedData(format!("scan priority not recognized: {code}"))
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/sapling.rs#L167
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/sapling.rs:167:54
|
167 | SqliteClientError::CorruptedData(format!(
| ______________________________________________________^
168 | | "Invalid key scope code {}",
169 | | scope_code
170 | | ))
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/orchard.rs#L166
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/orchard.rs:166:54
|
166 | SqliteClientError::CorruptedData(format!(
| ______________________________________________________^
167 | | "Invalid key scope code {}",
168 | | scope_code
169 | | ))
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init.rs#L200
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init.rs:200:13
|
200 | format!("Wallet DB contains unsupported pool type {}", pool),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
200 - format!("Wallet DB contains unsupported pool type {}", pool),
200 + format!("Wallet DB contains unsupported pool type {pool}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init.rs#L149
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init.rs:149:17
|
149 | / write!(
150 | | f,
151 | | "Unexpected violation of database business rules: {}",
152 | | err
153 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init.rs#L146
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init.rs:146:17
|
146 | write!(f, "Reverting migration {} is not supported", uuid)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
146 - write!(f, "Reverting migration {} is not supported", uuid)
146 + write!(f, "Reverting migration {uuid} is not supported")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init.rs#L143
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init.rs:143:17
|
143 | write!(f, "Address generation error: {:?}", e)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
143 - write!(f, "Address generation error: {:?}", e)
143 + write!(f, "Address generation error: {e:?}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init.rs#L141
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init.rs:141:56
|
141 | WalletMigrationError::CommitmentTree(e) => write!(f, "Commitment tree error: {:?}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
141 - WalletMigrationError::CommitmentTree(e) => write!(f, "Commitment tree error: {:?}", e),
141 + WalletMigrationError::CommitmentTree(e) => write!(f, "Commitment tree error: {e:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init.rs#L140
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init.rs:140:54
|
140 | WalletMigrationError::BalanceError(e) => write!(f, "Balance error: {:?}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
140 - WalletMigrationError::BalanceError(e) => write!(f, "Balance error: {:?}", e),
140 + WalletMigrationError::BalanceError(e) => write!(f, "Balance error: {e:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init.rs#L139
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init.rs:139:49
|
139 | WalletMigrationError::DbError(e) => write!(f, "{}", e),
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
139 - WalletMigrationError::DbError(e) => write!(f, "{}", e),
139 + WalletMigrationError::DbError(e) => write!(f, "{e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init.rs#L137
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init.rs:137:17
|
137 | write!(f, "Wallet database is corrupted: {}", reason)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
137 - write!(f, "Wallet database is corrupted: {}", reason)
137 + write!(f, "Wallet database is corrupted: {reason}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init.rs#L118
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init.rs:118:17
|
118 | / write!(
119 | | f,
120 | | "The installed SQLite version {} does not support operations required by the wallet.",
121 | | version
122 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/ufvk_support.rs#L261
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/ufvk_support.rs:261:57
|
261 | WalletMigrationError::CorruptedData(format!(
| _________________________________________________________^
262 | | "Could not decode {} as a valid Zcash address.",
263 | | address
264 | | ))
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/transparent_gap_limit_handling.rs#L184
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/transparent_gap_limit_handling.rs:184:57
|
184 | WalletMigrationError::CorruptedData(format!(
| _________________________________________________________^
185 | | "Encoded address {} is not a valid zcash address: {}",
186 | | addr_str, e
187 | | ))
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/transparent_gap_limit_handling.rs#L140
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/transparent_gap_limit_handling.rs:140:53
|
140 | WalletMigrationError::CorruptedData(format!(
| _____________________________________________________^
141 | | "Invalid UIVK encoding {}: {}",
142 | | uivk_str, e
143 | | ))
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/transparent_gap_limit_handling.rs#L93
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/transparent_gap_limit_handling.rs:93:21
|
93 | format!("{} is not a valid transparent child index.", i),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
93 - format!("{} is not a valid transparent child index.", i),
93 + format!("{i} is not a valid transparent child index."),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/sapling_memo_consistency.rs#L105
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/sapling_memo_consistency.rs:105:57
|
105 | WalletMigrationError::CorruptedData(format!(
| _________________________________________________________^
106 | | "Transaction not found for id {:?}",
107 | | txid
108 | | ))
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/sapling_memo_consistency.rs#L99
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/sapling_memo_consistency.rs:99:66
|
99 | other => WalletMigrationError::CorruptedData(format!(
| __________________________________________________________________^
100 | | "An error was encountered decoding transaction data: {:?}",
101 | | other
102 | | )),
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/sapling_memo_consistency.rs#L71
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/sapling_memo_consistency.rs:71:53
|
71 | WalletMigrationError::CorruptedData(format!(
| _____________________________________________________^
72 | | "Could not decode unified full viewing key for account {}: {:?}",
73 | | account, e
74 | | ))
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/receiving_key_scopes.rs#L236
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/receiving_key_scopes.rs:236:61
|
236 | WalletMigrationError::CorruptedData(format!("Note {} is invalid", note_id))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
236 - WalletMigrationError::CorruptedData(format!("Note {} is invalid", note_id))
236 + WalletMigrationError::CorruptedData(format!("Note {note_id} is invalid"))
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/receiving_key_scopes.rs#L229
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/receiving_key_scopes.rs:229:65
|
229 | ... WalletMigrationError::CorruptedData(format!(
| ___________________________________________________________^
230 | | ... "Note {} is invalid",
231 | | ... note_id
232 | | ... ))
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/receiving_key_scopes.rs#L199
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/receiving_key_scopes.rs:199:25
|
199 | panic!("A Sapling output must exist at index {}", output_index)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
199 - panic!("A Sapling output must exist at index {}", output_index)
199 + panic!("A Sapling output must exist at index {output_index}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/receiving_key_scopes.rs#L177
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/receiving_key_scopes.rs:177:53
|
177 | WalletMigrationError::CorruptedData(format!("Stored UFVK was invalid: {:?}", e))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
177 - WalletMigrationError::CorruptedData(format!("Stored UFVK was invalid: {:?}", e))
177 + WalletMigrationError::CorruptedData(format!("Stored UFVK was invalid: {e:?}"))
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/receiving_key_scopes.rs#L85
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/receiving_key_scopes.rs:85:49
|
85 | WalletMigrationError::CorruptedData(format!(
| _________________________________________________^
86 | | "Error querying note commitment tree: {:?}",
87 | | e
88 | | ))
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/addresses_table.rs#L137
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/addresses_table.rs:137:72
|
137 | return Err(WalletMigrationError::CorruptedData(format!(
| ________________________________________________________________________^
138 | | "Decoded transparent address {} is not the default transparent address.",
139 | | transparent_address,
140 | | )));
| |_________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/addresses_table.rs#L110
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/addresses_table.rs:110:61
|
110 | WalletMigrationError::CorruptedData(format!(
| _____________________________________________________________^
111 | | "Could not decode {} as a valid Zcash address.",
112 | | address
113 | | ))
| |_________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/addresses_table.rs#L81
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/addresses_table.rs:81:53
|
81 | WalletMigrationError::CorruptedData(format!(
| _____________________________________________________^
82 | | "Could not decode {} as a valid Zcash address.",
83 | | address
84 | | ))
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/add_utxo_account.rs#L154
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/add_utxo_account.rs:154:59
|
154 | _ => Err(SqliteClientError::CorruptedData(format!(
| ___________________________________________________________^
155 | | "Addresses table contains {} which is not a unified address",
156 | | ua_str,
157 | | ))),
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/add_utxo_account.rs#L75
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/add_utxo_account.rs:75:70
|
75 | other => WalletMigrationError::CorruptedData(format!(
| ______________________________________________________________________^
76 | | "Unexpected error in migration: {}",
77 | | other
78 | | )),
| |_________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/init/migrations/add_transaction_views.rs#L89
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/init/migrations/add_transaction_views.rs:89:57
|
89 | WalletMigrationError::CorruptedData(format!(
| _________________________________________________________^
90 | | "Parsing failed for transaction {:?}: {:?}",
91 | | id_tx, e
92 | | ))
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_proofs/src/lib.rs#L503
warning: variables can be used directly in the `format!` string
--> zcash_proofs/src/lib.rs:503:13
|
503 | / format!(
504 | | "{} failed validation:\n\
505 | | expected: {} hashing {} bytes,\n\
506 | | actual: {} hashing {} bytes from {:?}",
507 | | name, expected_hash, expected_bytes, hash, byte_count, params_source,
508 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_proofs/src/lib.rs#L452
warning: variables can be used directly in the `format!` string
--> zcash_proofs/src/lib.rs:452:13
|
452 | / format!(
453 | | "{} failed validation:\n\
454 | | expected: {} bytes,\n\
455 | | actual: {} bytes from {:?}",
456 | | name, expected_bytes, file_size, params_source,
457 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_proofs/src/lib.rs#L275
warning: variables can be used directly in the `format!` string
--> zcash_proofs/src/lib.rs:275:10
|
275 | &format!("{} + {}", params_url_1, params_url_2),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
275 - &format!("{} + {}", params_url_1, params_url_2),
275 + &format!("{params_url_1} + {params_url_2}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_proofs/src/lib.rs#L247
warning: variables can be used directly in the `format!` string
--> zcash_proofs/src/lib.rs:247:24
|
247 | let params_url_2 = format!("{}/{}.part.2", DOWNLOAD_URL, name);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
247 - let params_url_2 = format!("{}/{}.part.2", DOWNLOAD_URL, name);
247 + let params_url_2 = format!("{DOWNLOAD_URL}/{name}.part.2");
|
|
|
variables can be used directly in the `format!` string:
zcash_proofs/src/lib.rs#L245
warning: variables can be used directly in the `format!` string
--> zcash_proofs/src/lib.rs:245:24
|
245 | let params_url_1 = format!("{}/{}.part.1", DOWNLOAD_URL, name);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
245 - let params_url_1 = format!("{}/{}.part.1", DOWNLOAD_URL, name);
245 + let params_url_1 = format!("{DOWNLOAD_URL}/{name}.part.1");
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/testing/pool.rs#L310
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/testing/pool.rs:310:28
|
310 | Some(other) => panic!("Unexpected memo value: {:?}", other),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
310 - Some(other) => panic!("Unexpected memo value: {:?}", other),
310 + Some(other) => panic!("Unexpected memo value: {other:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/encoding.rs#L120
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/encoding.rs:120:59
|
120 | other => Err(SqliteClientError::CorruptedData(format!(
| ___________________________________________________________^
121 | | "Invalid key scope code: {}",
122 | | other
123 | | ))),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_proofs/src/circuit/sprout/mod.rs#L243
warning: variables can be used directly in the `format!` string
--> zcash_proofs/src/circuit/sprout/mod.rs:243:33
|
243 | cs.namespace(|| format!("bit {}", i)),
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
243 - cs.namespace(|| format!("bit {}", i)),
243 + cs.namespace(|| format!("bit {i}")),
|
|
|
variables can be used directly in the `format!` string:
zcash_proofs/src/circuit/sprout/mod.rs#L158
warning: variables can be used directly in the `format!` string
--> zcash_proofs/src/circuit/sprout/mod.rs:158:43
|
158 | let cs = &mut cs.namespace(|| format!("output {}", i));
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
158 - let cs = &mut cs.namespace(|| format!("output {}", i));
158 + let cs = &mut cs.namespace(|| format!("output {i}"));
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L1055
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:1055:13
|
1055 | format!("Note commitment tree cap was invalid at address {:?}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
1055 - format!("Note commitment tree cap was invalid at address {:?}", e),
1055 + format!("Note commitment tree cap was invalid at address {e:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_proofs/src/circuit/sprout/mod.rs#L98
warning: variables can be used directly in the `format!` string
--> zcash_proofs/src/circuit/sprout/mod.rs:98:43
|
98 | let cs = &mut cs.namespace(|| format!("input {}", i));
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
98 - let cs = &mut cs.namespace(|| format!("input {}", i));
98 + let cs = &mut cs.namespace(|| format!("input {i}"));
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L986
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:986:10
|
986 | &format!(
| __________^
987 | | "DELETE FROM {}_tree_checkpoint_marks_removed WHERE checkpoint_id = ?",
988 | | table_prefix
989 | | ),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L976
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:976:10
|
976 | &format!(
| __________^
977 | | "DELETE FROM {}_tree_checkpoints WHERE checkpoint_id > ?",
978 | | table_prefix
979 | | ),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L954
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:954:26
|
954 | .prepare_cached(&format!(
| __________________________^
955 | | "DELETE FROM {}_tree_checkpoints
956 | | WHERE checkpoint_id = :checkpoint_id",
957 | | table_prefix
958 | | ))
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L890
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:890:26
|
890 | .prepare_cached(&format!(
| __________________________^
891 | | "SELECT mark_removed_position
892 | | FROM {}_tree_checkpoint_marks_removed
893 | | WHERE checkpoint_id = :checkpoint_id",
894 | | table_prefix
895 | | ))
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L880
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:880:26
|
880 | .prepare_cached(&format!(
| __________________________^
881 | | "SELECT checkpoint_id, position
882 | | FROM {}_tree_checkpoints
883 | | ORDER BY position
884 | | LIMIT :limit",
885 | | table_prefix
886 | | ))
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L847
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:847:49
|
847 | let mut stmt = conn.prepare_cached(&format!(
| _________________________________________________^
848 | | "SELECT mark_removed_position
849 | | FROM {}_tree_checkpoint_marks_removed
850 | | WHERE checkpoint_id = ?",
851 | | table_prefix
852 | | ))?;
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_proofs/src/circuit/sprout/input.rs#L139
warning: variables can be used directly in the `format!` string
--> zcash_proofs/src/circuit/sprout/input.rs:139:39
|
139 | let cs = &mut cs.namespace(|| format!("bit {}", i));
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
139 - let cs = &mut cs.namespace(|| format!("bit {}", i));
139 + let cs = &mut cs.namespace(|| format!("bit {i}"));
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L825
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:825:14
|
825 | &format!(
| ______________^
826 | | "SELECT checkpoint_id, position
827 | | FROM {}_tree_checkpoints
828 | | ORDER BY checkpoint_id DESC
... |
831 | | table_prefix
832 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L804
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:804:10
|
804 | &format!(
| __________^
805 | | "SELECT checkpoint_id
806 | | FROM {}_tree_checkpoints
807 | | WHERE checkpoint_id <= :max_checkpoint_height
... |
810 | | table_prefix
811 | | ),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L767
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:767:14
|
767 | &format!(
| ______________^
768 | | "SELECT position
769 | | FROM {}_tree_checkpoints
770 | | WHERE checkpoint_id = ?",
771 | | table_prefix
772 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L743
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:743:26
|
743 | .prepare_cached(&format!(
| __________________________^
744 | | "SELECT mark_removed_position
745 | | FROM {}_tree_checkpoint_marks_removed
746 | | WHERE checkpoint_id = ?",
747 | | table_prefix
748 | | ))
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_proofs/src/circuit/sprout/input.rs#L109
warning: variables can be used directly in the `format!` string
--> zcash_proofs/src/circuit/sprout/input.rs:109:20
|
109 | || format!("conditionally enforce correct root for bit {}", i),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
109 - || format!("conditionally enforce correct root for bit {}", i),
109 + || format!("conditionally enforce correct root for bit {i}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L730
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:730:10
|
730 | &format!("SELECT COUNT(*) FROM {}_tree_checkpoints", table_prefix),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
730 - &format!("SELECT COUNT(*) FROM {}_tree_checkpoints", table_prefix),
730 + &format!("SELECT COUNT(*) FROM {table_prefix}_tree_checkpoints"),
|
|
|
variables can be used directly in the `format!` string:
zcash_proofs/src/circuit/sprout/input.rs#L59
warning: variables can be used directly in the `format!` string
--> zcash_proofs/src/circuit/sprout/input.rs:59:43
|
59 | let cs = &mut cs.namespace(|| format!("layer {}", i));
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
59 - let cs = &mut cs.namespace(|| format!("layer {}", i));
59 + let cs = &mut cs.namespace(|| format!("layer {i}"));
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L704
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:704:34
|
704 | .prepare_cached(&format!(
| __________________________________^
705 | | "INSERT INTO {}_tree_checkpoint_marks_removed (checkpoint_id, mark_removed_position)
706 | | VALUES (:checkpoint_id, :position)",
707 | | table_prefix
708 | | ))
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L689
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:689:34
|
689 | .prepare_cached(&format!(
| __________________________________^
690 | | "INSERT INTO {}_tree_checkpoints (checkpoint_id, position)
691 | | VALUES (:checkpoint_id, :position)",
692 | | table_prefix
693 | | ))
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L642
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:642:14
|
642 | &format!(
| ______________^
643 | | "SELECT position FROM {}_tree_checkpoints WHERE checkpoint_id = :checkpoint_id",
644 | | table_prefix
645 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/wallet/input_selection.rs#L264
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/wallet/input_selection.rs:264:53
|
264 | GreedyInputSelectorError::Balance(e) => write!(
| _____________________________________________________^
265 | | f,
266 | | "A balance calculation violated amount validity bounds: {:?}.",
267 | | e
268 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L621
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:621:10
|
621 | &format!(
| __________^
622 | | "SELECT MAX(checkpoint_id) FROM {}_tree_checkpoints",
623 | | table_prefix
624 | | ),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L603
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:603:10
|
603 | &format!(
| __________^
604 | | "SELECT MIN(checkpoint_id) FROM {}_tree_checkpoints",
605 | | table_prefix
606 | | ),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/wallet/input_selection.rs#L95
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/wallet/input_selection.rs:95:17
|
95 | / write!(
96 | | f,
97 | | "An error occurred decoding the address from a payment request: {}.",
98 | | e
99 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/wallet/input_selection.rs#L88
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/wallet/input_selection.rs:88:17
|
88 | / write!(
89 | | f,
90 | | "Input selection attempted to generate an invalid proposal: {}",
91 | | e
92 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/wallet/input_selection.rs#L82
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/wallet/input_selection.rs:82:46
|
82 | InputSelectorError::Change(e) => write!(
| ______________________________________________^
83 | | f,
84 | | "Proposal generation failed due to an error in computing change or transaction fees: {}",
85 | | e
86 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/wallet/input_selection.rs#L80
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/wallet/input_selection.rs:80:17
|
80 | write!(f, "Note selection encountered the following error: {}", e)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
80 - write!(f, "Note selection encountered the following error: {}", e)
80 + write!(f, "Note selection encountered the following error: {e}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L582
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:582:26
|
582 | .prepare_cached(&format!(
| __________________________^
583 | | "INSERT INTO {}_tree_cap (cap_id, cap_data)
584 | | VALUES (0, :cap_data)
585 | | ON CONFLICT (cap_id) DO UPDATE
586 | | SET cap_data = :cap_data",
587 | | table_prefix
588 | | ))
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/wallet/input_selection.rs#L73
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/wallet/input_selection.rs:73:17
|
73 | / write!(
74 | | f,
75 | | "The underlying datasource produced the following error: {}",
76 | | e
77 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L563
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:563:10
|
563 | &format!("SELECT cap_data FROM {}_tree_cap", table_prefix),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
563 - &format!("SELECT cap_data FROM {}_tree_cap", table_prefix),
563 + &format!("SELECT cap_data FROM {table_prefix}_tree_cap"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L547
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:547:10
|
547 | &format!(
| __________^
548 | | "DELETE FROM {}_tree_shards WHERE shard_index >= ?",
549 | | table_prefix
550 | | ),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L524
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:524:19
|
524 | .prepare(&format!(
| ___________________^
525 | | "SELECT shard_index FROM {}_tree_shards ORDER BY shard_index",
526 | | table_prefix
527 | | ))
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L497
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:497:26
|
497 | .prepare_cached(&format!(
| __________________________^
498 | | "INSERT INTO {}_tree_shards (shard_index, root_hash, shard_data)
499 | | VALUES (:shard_index, :root_hash, :shard_data)
500 | | ON CONFLICT (shard_index) DO UPDATE
... |
503 | | table_prefix
504 | | ))
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L438
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:438:14
|
438 | &format!(
| ______________^
439 | | "SELECT MIN(shard_index), MAX(shard_index) FROM {}_tree_shards",
440 | | table_prefix
441 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L420
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:420:17
|
420 | format!("Tree contained invalid data at address {:?}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
420 - format!("Tree contained invalid data at address {:?}", e),
420 + format!("Tree contained invalid data at address {e:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L398
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:398:10
|
398 | &format!(
| __________^
399 | | "SELECT shard_index, shard_data
400 | | FROM {}_tree_shards
401 | | ORDER BY shard_index DESC
402 | | LIMIT 1",
403 | | table_prefix
404 | | ),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L379
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:379:21
|
379 | format!("Tree contained invalid data at address {:?}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
379 - format!("Tree contained invalid data at address {:?}", e),
379 + format!("Tree contained invalid data at address {e:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/scanning.rs#L51
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/scanning.rs:51:9
|
51 | / assert!(
52 | | block_range.end >= block_range.start,
53 | | "{:?} is invalid for ScanRange({:?})",
54 | | block_range,
55 | | priority,
56 | | );
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L362
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:362:10
|
362 | &format!(
| __________^
363 | | "SELECT shard_data, root_hash
364 | | FROM {}_tree_shards
365 | | WHERE shard_index = :shard_index",
366 | | table_prefix
367 | | ),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L76
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:76:17
|
76 | / write!(
77 | | f,
78 | | "Attempted to write subtree roots with indices {:?} which is discontinuous with existing subtree range {:?}",
79 | | attempted_insertion_range, existing_range,
80 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L66
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:66:17
|
66 | / write!(
67 | | f,
68 | | "Conflict at checkpoint id {}, tried to insert {:?}, which is incompatible with existing state ({:?}, {:?})",
69 | | checkpoint_id, checkpoint, extant_tree_state, extant_marks_removed
70 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L59
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:59:34
|
59 | Error::Query(err) => write!(f, "Commitment tree query or update error: {}", err),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
59 - Error::Query(err) => write!(f, "Commitment tree query or update error: {}", err),
59 + Error::Query(err) => write!(f, "Commitment tree query or update error: {err}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/wallet/commitment_tree.rs#L58
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/wallet/commitment_tree.rs:58:42
|
58 | Error::Serialization(err) => write!(f, "Commitment tree serialization error: {}", err),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
58 - Error::Serialization(err) => write!(f, "Commitment tree serialization error: {}", err),
58 + Error::Serialization(err) => write!(f, "Commitment tree serialization error: {err}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L224
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:224:17
|
224 | write!(f, "The wallet was unable to schedule an event: {}", err)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
224 - write!(f, "The wallet was unable to schedule an event: {}", err)
224 + write!(f, "The wallet was unable to schedule an event: {err}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L220
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:220:17
|
220 | write!(f, "The address {address_str} previously used in txid(s) {:?} would be reused.", txids)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
220 - write!(f, "The address {address_str} previously used in txid(s) {:?} would be reused.", txids)
220 + write!(f, "The address {address_str} previously used in txid(s) {txids:?} would be reused.")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L200
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:200:56
|
200 | SqliteClientError::NoteFilterInvalid(s) => write!(f, "Could not evaluate filter query: {:?}", s),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
200 - SqliteClientError::NoteFilterInvalid(s) => write!(f, "Could not evaluate filter query: {:?}", s),
200 + SqliteClientError::NoteFilterInvalid(s) => write!(f, "Could not evaluate filter query: {s:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L199
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:199:51
|
199 | SqliteClientError::BalanceError(e) => write!(f, "Balance error: {}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
199 - SqliteClientError::BalanceError(e) => write!(f, "Balance error: {}", e),
199 + SqliteClientError::BalanceError(e) => write!(f, "Balance error: {e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L198
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:198:58
|
198 | SqliteClientError::UnsupportedPoolType(t) => write!(f, "Pool type is not currently supported: {}", t),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
198 - SqliteClientError::UnsupportedPoolType(t) => write!(f, "Pool type is not currently supported: {}", t),
198 + SqliteClientError::UnsupportedPoolType(t) => write!(f, "Pool type is not currently supported: {t}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L196
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:196:53
|
196 | SqliteClientError::CacheMiss(height) => write!(f, "Requested height {} does not exist in the block cache.", height),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
196 - SqliteClientError::CacheMiss(height) => write!(f, "Requested height {} does not exist in the block cache.", height),
196 + SqliteClientError::CacheMiss(height) => write!(f, "Requested height {height} does not exist in the block cache."),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L195
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:195:55
|
195 | ...CommitmentTree(err) => write!(f, "An error occurred accessing or updating note commitment tree data: {}.", err),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
195 - SqliteClientError::CommitmentTree(err) => write!(f, "An error occurred accessing or updating note commitment tree data: {}.", err),
195 + SqliteClientError::CommitmentTree(err) => write!(f, "An error occurred accessing or updating note commitment tree data: {err}."),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L190
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:190:53
|
190 | SqliteClientError::BadAccountData(e) => write!(f, "Failed to add account: {}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
190 - SqliteClientError::BadAccountData(e) => write!(f, "Failed to add account: {}", e),
190 + SqliteClientError::BadAccountData(e) => write!(f, "Failed to add account: {e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L186
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:186:56
|
186 | SqliteClientError::AddressGeneration(e) => write!(f, "{}", e),
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
186 - SqliteClientError::AddressGeneration(e) => write!(f, "{}", e),
186 + SqliteClientError::AddressGeneration(e) => write!(f, "{e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L183
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:183:50
|
183 | SqliteClientError::InvalidMemo(e) => write!(f, "{}", e),
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
183 - SqliteClientError::InvalidMemo(e) => write!(f, "{}", e),
183 + SqliteClientError::InvalidMemo(e) => write!(f, "{e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L182
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:182:41
|
182 | SqliteClientError::Io(e) => write!(f, "{}", e),
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
182 - SqliteClientError::Io(e) => write!(f, "{}", e),
182 + SqliteClientError::Io(e) => write!(f, "{e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L181
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:181:46
|
181 | SqliteClientError::DbError(e) => write!(f, "{}", e),
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
181 - SqliteClientError::DbError(e) => write!(f, "{}", e),
181 + SqliteClientError::DbError(e) => write!(f, "{e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L179
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:179:57
|
179 | SqliteClientError::TransparentAddress(e) => write!(f, "{}", e),
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
179 - SqliteClientError::TransparentAddress(e) => write!(f, "{}", e),
179 + SqliteClientError::TransparentAddress(e) => write!(f, "{e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L177
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:177:60
|
177 | SqliteClientError::TransparentDerivation(e) => write!(f, "{:?}", e),
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
177 - SqliteClientError::TransparentDerivation(e) => write!(f, "{:?}", e),
177 + SqliteClientError::TransparentDerivation(e) => write!(f, "{e:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L172
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:172:76
|
172 | safe_rewind_height.map_or("<unavailable>".to_owned(), |h0| format!("{}", h0)),
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
172 - safe_rewind_height.map_or("<unavailable>".to_owned(), |h0| format!("{}", h0)),
172 + safe_rewind_height.map_or("<unavailable>".to_owned(), |h0| format!("{h0}")),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L167
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:167:47
|
167 | SqliteClientError::Protobuf(e) => write!(f, "Failed to parse protobuf-encoded record: {}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
167 - SqliteClientError::Protobuf(e) => write!(f, "Failed to parse protobuf-encoded record: {}", e),
167 + SqliteClientError::Protobuf(e) => write!(f, "Failed to parse protobuf-encoded record: {e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/error.rs#L165
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/error.rs:165:17
|
165 | write!(f, "Data DB is corrupted: {}", reason)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
165 - write!(f, "Data DB is corrupted: {}", reason)
165 + write!(f, "Data DB is corrupted: {reason}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_sqlite/src/chain.rs#L171
warning: variables can be used directly in the `format!` string
--> zcash_client_sqlite/src/chain.rs:171:21
|
171 | / panic!(
172 | | "Rollback failed with error {} while attempting to recover from error {}; database is likely corrupt.",
173 | | e,
174 | | error
175 | | )
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/error.rs#L233
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/error.rs:233:17
|
233 | write!(f, "The wallet tried to pay to an ephemeral transparent address as a normal output: {}", addr)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
233 - write!(f, "The wallet tried to pay to an ephemeral transparent address as a normal output: {}", addr)
233 + write!(f, "The wallet tried to pay to an ephemeral transparent address as a normal output: {addr}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/error.rs#L225
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/error.rs:225:17
|
225 | write!(f, "An error occurred decoding the address from a payment request: {}.", e)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
225 - write!(f, "An error occurred decoding the address from a payment request: {}.", e)
225 + write!(f, "An error occurred decoding the address from a payment request: {e}.")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/error.rs#L222
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/error.rs:222:39
|
222 | ...=> write!(f, "A note being spent ({:?}) does not correspond to either the internal or external full viewing key for the provided spending key.", n),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
222 - Error::NoteMismatch(n) => write!(f, "A note being spent ({:?}) does not correspond to either the internal or external full viewing key for the provided spending key.", n),
222 + Error::NoteMismatch(n) => write!(f, "A note being spent ({n:?}) does not correspond to either the internal or external full viewing key for the provided spending key."),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/error.rs#L221
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/error.rs:221:45
|
221 | ...vailable(pool) => write!(f, "A key required for transaction construction was not available for pool type {}", pool),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
221 - Error::KeyNotAvailable(pool) => write!(f, "A key required for transaction construction was not available for pool type {}", pool),
221 + Error::KeyNotAvailable(pool) => write!(f, "A key required for transaction construction was not available for pool type {pool}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/error.rs#L212
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/error.rs:212:48
|
212 | Error::UnsupportedChangeType(t) => write!(f, "Attempted to send change to an unsupported pool type: {}", t),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
212 - Error::UnsupportedChangeType(t) => write!(f, "Attempted to send change to an unsupported pool type: {}", t),
212 + Error::UnsupportedChangeType(t) => write!(f, "Attempted to send change to an unsupported pool type: {t}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/error.rs#L163
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/error.rs:163:17
|
163 | write!(f, "An error occurred in querying or updating a note commitment tree: {}", e)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
163 - write!(f, "An error occurred in querying or updating a note commitment tree: {}", e)
163 + write!(f, "An error occurred in querying or updating a note commitment tree: {e}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/error.rs#L156
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/error.rs:156:17
|
156 | / write!(
157 | | f,
158 | | "The underlying datasource produced the following error: {}",
159 | | e
160 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/chain/error.rs#L42
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/chain/error.rs:42:17
|
42 | write!(f, "Scanning produced the following error: {}", e)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
42 - write!(f, "Scanning produced the following error: {}", e)
42 + write!(f, "Scanning produced the following error: {e}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/chain/error.rs#L35
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/chain/error.rs:35:17
|
35 | / write!(
36 | | f,
37 | | "The underlying block store produced the following error: {}",
38 | | e
39 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/chain/error.rs#L28
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/chain/error.rs:28:17
|
28 | / write!(
29 | | f,
30 | | "The underlying datasource produced the following error: {}",
31 | | e
32 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L770
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:770:21
|
770 | Err(format!("Required parameter {} not recognized", other))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
770 - Err(format!("Required parameter {} not recognized", other))
770 + Err(format!("Required parameter {other} not recognized"))
|
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L767
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:767:30
|
767 | .map_err(|e| format!("Decoded memo was invalid: {:?}", e)),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
767 - .map_err(|e| format!("Decoded memo was invalid: {:?}", e)),
767 + .map_err(|e| format!("Decoded memo was invalid: {e:?}")),
|
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L744
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:744:21
|
744 | / format!(
745 | | "Could not interpret {} as a valid Zcash address: {}",
746 | | value, err
747 | | )
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L731
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:731:34
|
731 | .map_err(|_| format!("Not a valid zat amount: {}.{}", coins, zats))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
731 - .map_err(|_| format!("Not a valid zat amount: {}.{}", coins, zats))
731 + .map_err(|_| format!("Not a valid zat amount: {coins}.{zats}"))
|
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L720
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:720:32
|
720 | Some(d) => format!("{:0<8}", d)
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
720 - Some(d) => format!("{:0<8}", d)
720 + Some(d) => format!("{d:0<8}")
|
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L491
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:491:13
|
491 | format!("{}.{:0>8}", coins, zats)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
491 - format!("{}.{:0>8}", coins, zats)
491 + format!("{coins}.{zats:0>8}")
|
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L489
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:489:13
|
489 | format!("{}", coins)
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
489 - format!("{}", coins)
489 + format!("{coins}")
|
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L472
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:472:33
|
472 | Some(i) if i > 0 => format!(".{}", i),
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
472 - Some(i) if i > 0 => format!(".{}", i),
472 + Some(i) if i > 0 => format!(".{i}"),
|
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L393
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:393:41
|
393 | Zip321Error::ParseError(format!("Error parsing query parameters: {}", e))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
393 - Zip321Error::ParseError(format!("Error parsing query parameters: {}", e))
393 + Zip321Error::ParseError(format!("Error parsing query parameters: {e}"))
|
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L382
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:382:50
|
382 | .map_err(|e| Zip321Error::ParseError(format!("Error parsing lead address: {}", e)))?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
382 - .map_err(|e| Zip321Error::ParseError(format!("Error parsing lead address: {}", e)))?;
382 + .map_err(|e| Zip321Error::ParseError(format!("Error parsing lead address: {e}")))?;
|
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L84
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:84:43
|
84 | Zip321Error::ParseError(s) => write!(f, "Parse failure: {}", s),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
84 - Zip321Error::ParseError(s) => write!(f, "Parse failure: {}", s),
84 + Zip321Error::ParseError(s) => write!(f, "Parse failure: {s}"),
|
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L82
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:82:17
|
82 | write!(f, "Payment {} is missing its recipient address", idx)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
82 - write!(f, "Payment {} is missing its recipient address", idx)
82 + write!(f, "Payment {idx} is missing its recipient address")
|
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L76
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:76:50
|
76 | Zip321Error::TransparentMemo(idx) => write!(
| __________________________________________________^
77 | | f,
78 | | "Payment {} is invalid: cannot send a memo to a transparent recipient address",
79 | | idx
80 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L65
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:65:48
|
65 | Zip321Error::TooManyPayments(n) => write!(
| ________________________________________________^
66 | | f,
67 | | "Cannot create a Zcash transaction containing {} payments",
68 | | n
69 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L60
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:60:49
|
60 | Zip321Error::MemoBytesError(err) => write!(
| _________________________________________________^
61 | | f,
62 | | "Memo exceeded maximum length or violated UTF-8 encoding restrictions: {:?}",
63 | | err
64 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L58
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:58:17
|
58 | write!(f, "Memo value was not correctly base64-encoded: {:?}", err)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
58 - write!(f, "Memo value was not correctly base64-encoded: {:?}", err)
58 + write!(f, "Memo value was not correctly base64-encoded: {err:?}")
|
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L50
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:50:33
|
50 | Zip321Error::ParseError(format!("Address parsing failed: {}", value))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
50 - Zip321Error::ParseError(format!("Address parsing failed: {}", value))
50 + Zip321Error::ParseError(format!("Address parsing failed: {value}"))
|
|
|
variables can be used directly in the `format!` string:
zcash_primitives/src/transaction/fees/zip317.rs#L143
warning: variables can be used directly in the `format!` string
--> zcash_primitives/src/transaction/fees/zip317.rs:143:37
|
143 | FeeError::Balance(e) => write!(
| _____________________________________^
144 | | f,
145 | | "A balance calculation violated amount validity bounds: {}.",
146 | | e
147 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_primitives/src/transaction/builder.rs#L131
warning: variables can be used directly in the `format!` string
--> zcash_primitives/src/transaction/builder.rs:131:45
|
131 | Error::OrchardRecipient(err) => write!(f, "Could not add Orchard recipient: {}", err),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
131 - Error::OrchardRecipient(err) => write!(f, "Could not add Orchard recipient: {}", err),
131 + Error::OrchardRecipient(err) => write!(f, "Could not add Orchard recipient: {err}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_primitives/src/transaction/builder.rs#L130
warning: variables can be used directly in the `format!` string
--> zcash_primitives/src/transaction/builder.rs:130:41
|
130 | Error::OrchardSpend(err) => write!(f, "Could not add Orchard spend: {}", err),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
130 - Error::OrchardSpend(err) => write!(f, "Could not add Orchard spend: {}", err),
130 + Error::OrchardSpend(err) => write!(f, "Could not add Orchard spend: {err}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_primitives/src/transaction/builder.rs#L129
warning: variables can be used directly in the `format!` string
--> zcash_primitives/src/transaction/builder.rs:129:41
|
129 | Error::OrchardBuild(err) => write!(f, "{:?}", err),
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
129 - Error::OrchardBuild(err) => write!(f, "{:?}", err),
129 + Error::OrchardBuild(err) => write!(f, "{err:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_primitives/src/transaction/builder.rs#L125
warning: variables can be used directly in the `format!` string
--> zcash_primitives/src/transaction/builder.rs:125:34
|
125 | Error::Balance(e) => write!(f, "Invalid amount {:?}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
125 - Error::Balance(e) => write!(f, "Invalid amount {:?}", e),
125 + Error::Balance(e) => write!(f, "Invalid amount {e:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_primitives/src/transaction/builder.rs#L120
warning: variables can be used directly in the `format!` string
--> zcash_primitives/src/transaction/builder.rs:120:46
|
120 | Error::ChangeRequired(amount) => write!(
| ______________________________________________^
121 | | f,
122 | | "The transaction requires an additional change output of {:?} zatoshis",
123 | | amount
124 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_primitives/src/transaction/builder.rs#L115
warning: variables can be used directly in the `format!` string
--> zcash_primitives/src/transaction/builder.rs:115:49
|
115 | Error::InsufficientFunds(amount) => write!(
| _________________________________________________^
116 | | f,
117 | | "Insufficient funds for transaction construction; need an additional {:?} zatoshis",
118 | | amount
119 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_primitives/src/transaction/builder.rs#L73
warning: variables can be used directly in the `format!` string
--> zcash_primitives/src/transaction/builder.rs:73:36
|
73 | FeeError::Bundle(b) => write!(f, "Bundle structure invalid in fee calculation: {}", b),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
73 - FeeError::Bundle(b) => write!(f, "Bundle structure invalid in fee calculation: {}", b),
73 + FeeError::Bundle(b) => write!(f, "Bundle structure invalid in fee calculation: {b}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/keys.rs#L1085
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/keys.rs:1085:24
|
1085 | return Err(format!(
| ________________________^
1086 | | "UIVK is for network {:?} but we expected {:?}",
1087 | | net, expected_net,
1088 | | ));
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/keys.rs#L839
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/keys.rs:839:24
|
839 | return Err(format!(
| ________________________^
840 | | "UFVK is for network {:?} but we expected {:?}",
841 | | net, expected_net,
842 | | ));
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/keys.rs#L539
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/keys.rs:539:17
|
539 | / write!(
540 | | f,
541 | | "The Unified Viewing Key does not contain a key for typecode {:?}.",
542 | | t
543 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/keys.rs#L532
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/keys.rs:532:17
|
532 | / write!(
533 | | f,
534 | | "Unified Address generation does not yet support receivers of type {:?}.",
535 | | t
536 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/keys.rs#L519
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/keys.rs:519:17
|
519 | / write!(
520 | | f,
521 | | "Child index {:?} does not generate a valid Sapling receiver",
522 | | i
523 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/keys.rs#L511
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/keys.rs:511:17
|
511 | / write!(
512 | | f,
513 | | "Child index {:?} does not generate a valid transparent receiver",
514 | | i
515 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/keys.rs#L179
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/keys.rs:179:49
|
179 | DecodingError::KeyDataInvalid(t) => write!(f, "Invalid key data for key type {:?}", t),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
179 - DecodingError::KeyDataInvalid(t) => write!(f, "Invalid key data for key type {:?}", t),
179 + DecodingError::KeyDataInvalid(t) => write!(f, "Invalid key data for key type {t:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/keys.rs#L177
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/keys.rs:177:17
|
177 | write!(f, "Insufficient data for typecode {:?}", t)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
177 - write!(f, "Insufficient data for typecode {:?}", t)
177 + write!(f, "Insufficient data for typecode {t:?}")
|
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/keys.rs#L169
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/keys.rs:169:17
|
169 | / write!(
170 | | f,
171 | | "Length mismatch: received {} bytes for typecode {:?}",
172 | | l, t
173 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/keys.rs#L162
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/keys.rs:162:46
|
162 | DecodingError::EraMismatch(e) => write!(f, "Era mismatch: actual {:?}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
162 - DecodingError::EraMismatch(e) => write!(f, "Era mismatch: actual {:?}", e),
162 + DecodingError::EraMismatch(e) => write!(f, "Era mismatch: actual {e:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/keys.rs#L158
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/keys.rs:158:44
|
158 | DecodingError::ReadError(s) => write!(f, "Read error: {}", s),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
158 - DecodingError::ReadError(s) => write!(f, "Read error: {}", s),
158 + DecodingError::ReadError(s) => write!(f, "Read error: {s}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/encoding.rs#L192
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/encoding.rs:192:25
|
192 | Err(format!(
| _________________________^
193 | | "Address {} is for a different network: {:?}",
194 | | address, network
195 | | ))
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/encoding.rs#L187
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/encoding.rs:187:26
|
187 | .map_err(|e| format!("{}", e))
| ^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
187 - .map_err(|e| format!("{}", e))
187 + .map_err(|e| format!("{e}"))
|
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/encoding.rs#L133
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/encoding.rs:133:49
|
133 | TransparentCodecError::Base58(e) => write!(f, "{}", e),
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
133 - TransparentCodecError::Base58(e) => write!(f, "{}", e),
133 + TransparentCodecError::Base58(e) => write!(f, "{e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/encoding.rs#L128
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/encoding.rs:128:65
|
128 | TransparentCodecError::UnsupportedAddressType(s) => write!(
| _________________________________________________________________^
129 | | f,
130 | | "Could not recognize {} as a supported p2sh or p2pkh address.",
131 | | s
132 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/encoding.rs#L70
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/encoding.rs:70:68
|
70 | Bech32DecodeError::HrpMismatch { expected, actual } => write!(
| ____________________________________________________________________^
71 | | f,
72 | | "Key was encoded for a different network: expected {}, got {}.",
73 | | expected, actual
74 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/encoding.rs#L65
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/encoding.rs:65:50
|
65 | Bech32DecodeError::Bech32Error(e) => write!(f, "{}", e),
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
65 - Bech32DecodeError::Bech32Error(e) => write!(f, "{}", e),
65 + Bech32DecodeError::Bech32Error(e) => write!(f, "{e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_history/src/lib.rs#L52
warning: variables can be used directly in the `format!` string
--> zcash_history/src/lib.rs:52:35
|
52 | Self::Generated(v) => write!(f, "generated({})", v),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
52 - Self::Generated(v) => write!(f, "generated({})", v),
52 + Self::Generated(v) => write!(f, "generated({v})"),
|
|
|
variables can be used directly in the `format!` string:
zcash_history/src/lib.rs#L51
warning: variables can be used directly in the `format!` string
--> zcash_history/src/lib.rs:51:32
|
51 | Self::Stored(v) => write!(f, "stored({})", v),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
51 - Self::Stored(v) => write!(f, "stored({})", v),
51 + Self::Stored(v) => write!(f, "stored({v})"),
|
|
|
variables can be used directly in the `format!` string:
zcash_history/src/lib.rs#L33
warning: variables can be used directly in the `format!` string
--> zcash_history/src/lib.rs:33:44
|
33 | Self::ExpectedNode(Some(l)) => write!(f, "Node expected, not leaf: {}", l),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
33 - Self::ExpectedNode(Some(l)) => write!(f, "Node expected, not leaf: {}", l),
33 + Self::ExpectedNode(Some(l)) => write!(f, "Node expected, not leaf: {l}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_history/src/lib.rs#L31
warning: variables can be used directly in the `format!` string
--> zcash_history/src/lib.rs:31:42
|
31 | Self::ExpectedInMemory(l) => write!(f, "Node/leaf expected to be in memory: {}", l),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
31 - Self::ExpectedInMemory(l) => write!(f, "Node/leaf expected to be in memory: {}", l),
31 + Self::ExpectedInMemory(l) => write!(f, "Node/leaf expected to be in memory: {l}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/serialization/shardtree.rs#L94
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/serialization/shardtree.rs:94:13
|
94 | format!("Shard serialization version not recognized: {}", other),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
94 - format!("Shard serialization version not recognized: {}", other),
94 + format!("Shard serialization version not recognized: {other}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/serialization/shardtree.rs#L79
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/serialization/shardtree.rs:79:13
|
79 | format!("Node tag not recognized: {}", other),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
79 - format!("Node tag not recognized: {}", other),
79 + format!("Node tag not recognized: {other}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/serialization/shardtree.rs#L67
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/serialization/shardtree.rs:67:25
|
67 | / format!(
68 | | "Byte value {} does not correspond to a valid set of retention flags",
69 | | bits
70 | | ),
| |_________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/sync.rs#L576
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/sync.rs:576:38
|
576 | Error::WalletTrees(e) => write!(
| ______________________________________^
577 | | f,
578 | | "Error while interacting with wallet commitment trees: {}",
579 | | e
580 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/sync.rs#L575
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/sync.rs:575:33
|
575 | Error::Wallet(e) => write!(f, "Error while interacting with wallet database: {}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
575 - Error::Wallet(e) => write!(f, "Error while interacting with wallet database: {}", e),
575 + Error::Wallet(e) => write!(f, "Error while interacting with wallet database: {e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/sync.rs#L570
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/sync.rs:570:33
|
570 | Error::Server(e) => write!(
| _________________________________^
571 | | f,
572 | | "Error while communicating with lightwalletd server: {}",
573 | | e
574 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/sync.rs#L569
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/sync.rs:569:31
|
569 | Error::Scan(e) => write!(f, "Error while scanning blocks: {}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
569 - Error::Scan(e) => write!(f, "Error while scanning blocks: {}", e),
569 + Error::Scan(e) => write!(f, "Error while scanning blocks: {e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/sync.rs#L567
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/sync.rs:567:32
|
567 | Error::Cache(e) => write!(f, "Error while interacting with block cache: {}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
567 - Error::Cache(e) => write!(f, "Error while interacting with block cache: {}", e),
567 + Error::Cache(e) => write!(f, "Error while interacting with block cache: {e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_history/src/entry.rs#L118
warning: variables can be used directly in the `format!` string
--> zcash_history/src/entry.rs:118:38
|
118 | EntryKind::Node(l, r) => write!(f, "node({}, {}, ..)", l, r),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
118 - EntryKind::Node(l, r) => write!(f, "node({}, {}, ..)", l, r),
118 + EntryKind::Node(l, r) => write!(f, "node({l}, {r}, ..)"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/scanning.rs#L472
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/scanning.rs:472:17
|
472 | ... write!(f, "Received invalid (potentially default) {:?} note commitment tree size metadata at height {}", protocol, at_height)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
472 - write!(f, "Received invalid (potentially default) {:?} note commitment tree size metadata at height {}", protocol, at_height)
472 + write!(f, "Received invalid (potentially default) {protocol:?} note commitment tree size metadata at height {at_height}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/scanning.rs#L469
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/scanning.rs:469:17
|
469 | write!(f, "Unable to determine {:?} note commitment tree size at height {}", protocol, at_height)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
469 - write!(f, "Unable to determine {:?} note commitment tree size at height {}", protocol, at_height)
469 + write!(f, "Unable to determine {protocol:?} note commitment tree size at height {at_height}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/scanning.rs#L466
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/scanning.rs:466:17
|
466 | ... write!(f, "The {:?} note commitment tree size provided by a compact block did not match the expected size at height {}; given {}, expected {}", protocol, at_height, given, computed)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
466 - write!(f, "The {:?} note commitment tree size provided by a compact block did not match the expected size at height {}; given {}, expected {}", protocol, at_height, given, computed)
466 + write!(f, "The {protocol:?} note commitment tree size provided by a compact block did not match the expected size at height {at_height}; given {given}, expected {computed}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/scanning.rs#L463
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/scanning.rs:463:17
|
463 | write!(f, "Block height discontinuity at height {}; previous height was: {}", new_height, prev_height)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
463 - write!(f, "Block height discontinuity at height {}; previous height was: {}", new_height, prev_height)
463 + write!(f, "Block height discontinuity at height {new_height}; previous height was: {prev_height}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/scanning.rs#L457
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/scanning.rs:457:47
|
457 | PrevHashMismatch { at_height } => write!(
| _______________________________________________^
458 | | f,
459 | | "The parent hash of proposed block does not correspond to the block hash at height {}.",
460 | | at_height
461 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/scanning.rs#L452
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/scanning.rs:452:63
|
452 | EncodingInvalid { txid, pool_type, index, .. } => write!(
| _______________________________________________________________^
453 | | f,
454 | | "{:?} output {} of transaction {} was improperly encoded.",
455 | | pool_type, index, txid
456 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proto.rs#L516
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proto.rs:516:76
|
516 | ProposalDecodingError::InvalidEphemeralRecipient(pool_type) => write!(
| ____________________________________________________________________________^
517 | | f,
518 | | "Ephemeral outputs to the {} pool are not supported.",
519 | | pool_type
520 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proto.rs#L511
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proto.rs:511:73
|
511 | ProposalDecodingError::InvalidChangeRecipient(pool_type) => write!(
| _________________________________________________________________________^
512 | | f,
513 | | "Change outputs to the {} pool are not supported.",
514 | | pool_type
515 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proto.rs#L503
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proto.rs:503:69
|
503 | ProposalDecodingError::EmptyShieldedInputs(protocol) => write!(
| _____________________________________________________________________^
504 | | f,
505 | | "An inputs field was present for {:?}, but contained no note references.",
506 | | protocol
507 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proto.rs#L502
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proto.rs:502:60
|
502 | ProposalDecodingError::ProposalInvalid(err) => write!(f, "{}", err),
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
502 - ProposalDecodingError::ProposalInvalid(err) => write!(f, "{}", err),
502 + ProposalDecodingError::ProposalInvalid(err) => write!(f, "{err}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proto.rs#L496
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proto.rs:496:17
|
496 | / write!(
497 | | f,
498 | | "Fee calculation using the {:?} fee rule is not supported.",
499 | | r
500 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proto.rs#L493
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proto.rs:493:17
|
493 | write!(f, "Unrecognized proposal version {}", v)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
493 - write!(f, "Unrecognized proposal version {}", v)
493 + write!(f, "Unrecognized proposal version {v}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proto.rs#L490
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proto.rs:490:17
|
490 | write!(f, "An error occurred decoding a proposed memo: {}", err)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
490 - write!(f, "An error occurred decoding a proposed memo: {}", err)
490 + write!(f, "An error occurred decoding a proposed memo: {err}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proto.rs#L481
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proto.rs:481:70
|
481 | ProposalDecodingError::InputNotFound(txid, pool, idx) => write!(
| ______________________________________________________________________^
482 | | f,
483 | | "No {} input found for txid {}, index {}",
484 | | pool, txid, idx
485 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proto.rs#L476
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proto.rs:476:59
|
476 | ProposalDecodingError::InputRetrieval(err) => write!(
| ___________________________________________________________^
477 | | f,
478 | | "An error occurred retrieving a transaction input: {}",
479 | | err
480 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proto.rs#L474
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proto.rs:474:17
|
474 | write!(f, "Invalid value pool identifier: {:?}", id)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
474 - write!(f, "Invalid value pool identifier: {:?}", id)
474 + write!(f, "Invalid value pool identifier: {id:?}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proto.rs#L471
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proto.rs:471:17
|
471 | write!(f, "Invalid transaction id: {:?}", err)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
471 - write!(f, "Invalid transaction id: {:?}", err)
471 + write!(f, "Invalid transaction id: {err:?}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proto.rs#L468
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proto.rs:468:17
|
468 | write!(f, "Proposed input was null at index {}", i)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
468 - write!(f, "Proposed input was null at index {}", i)
468 + write!(f, "Proposed input was null at index {i}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proto.rs#L466
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proto.rs:466:51
|
466 | ProposalDecodingError::Zip321(err) => write!(f, "Transaction request invalid: {}", err),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
466 - ProposalDecodingError::Zip321(err) => write!(f, "Transaction request invalid: {}", err),
466 + ProposalDecodingError::Zip321(err) => write!(f, "Transaction request invalid: {err}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proto.rs#L394
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proto.rs:394:17
|
394 | format!("Block hash is not valid hex: {:?}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
394 - format!("Block hash is not valid hex: {:?}", e),
394 + format!("Block hash is not valid hex: {e:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proto.rs#L376
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proto.rs:376:21
|
376 | format!("Hex decoding of Orchard tree bytes failed: {:?}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
376 - format!("Hex decoding of Orchard tree bytes failed: {:?}", e),
376 + format!("Hex decoding of Orchard tree bytes failed: {e:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proto.rs#L355
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proto.rs:355:21
|
355 | format!("Hex decoding of Sapling tree bytes failed: {:?}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
355 - format!("Hex decoding of Sapling tree bytes failed: {:?}", e),
355 + format!("Hex decoding of Sapling tree bytes failed: {e:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_history/examples/write.rs#L41
warning: variables can be used directly in the `format!` string
--> zcash_history/examples/write.rs:41:13
|
41 | println!("{:?}", n);
| ^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
41 - println!("{:?}", n);
41 + println!("{n:?}");
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proposal.rs#L113
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proposal.rs:113:61
|
113 | ProposalError::EphemeralOutputLeftUnspent(r) => write!(
| _____________________________________________________________^
114 | | f,
115 | | "The proposal created an ephemeral output at step {:?} that was not spent in any later step.",
116 | | r,
117 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proposal.rs#L107
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proposal.rs:107:47
|
107 | ProposalError::SpendsChange(r) => write!(
| _______________________________________________^
108 | | f,
109 | | "The proposal attempts to spends the change output created at step {:?}.",
110 | | r,
111 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proposal.rs#L98
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proposal.rs:98:67
|
98 | ProposalError::ChainDoubleSpend(pool, txid, index) => write!(
| ___________________________________________________________________^
99 | | f,
100 | | "The proposal attempts to spend the same output twice: {}, {}, {}",
101 | | pool, txid, index
102 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proposal.rs#L93
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proposal.rs:93:50
|
93 | ProposalError::StepDoubleSpend(r) => write!(
| __________________________________________________^
94 | | f,
95 | | "The proposal uses the output of step {:?} in more than one place.",
96 | | r
97 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proposal.rs#L91
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proposal.rs:91:17
|
91 | write!(f, "No prior step output found for reference {:?}", r)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
91 - write!(f, "No prior step output found for reference {:?}", r)
91 + write!(f, "No prior step output found for reference {r:?}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/proposal.rs#L88
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/proposal.rs:88:17
|
88 | write!(f, "Unable to compute anchor for block height {:?}", h)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
88 - write!(f, "Unable to compute anchor for block height {:?}", h)
88 + write!(f, "Unable to compute anchor for block height {h:?}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/fees.rs#L272
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/fees.rs:272:17
|
272 | / write!(
273 | | f,
274 | | "The proposed transaction structure violates bundle type constraints: {}",
275 | | err
276 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/fees.rs#L269
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/fees.rs:269:17
|
269 | write!(f, "{}", err)
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
269 - write!(f, "{}", err)
269 + write!(f, "{err}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/testing/pool.rs#L468
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/testing/pool.rs:468:28
|
468 | Some(other) => panic!("Unexpected memo value: {:?}", other),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
468 - Some(other) => panic!("Unexpected memo value: {:?}", other),
468 + Some(other) => panic!("Unexpected memo value: {other:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/testing/pool.rs#L310
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/testing/pool.rs:310:28
|
310 | Some(other) => panic!("Unexpected memo value: {:?}", other),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
310 - Some(other) => panic!("Unexpected memo value: {:?}", other),
310 + Some(other) => panic!("Unexpected memo value: {other:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/wallet/input_selection.rs#L264
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/wallet/input_selection.rs:264:53
|
264 | GreedyInputSelectorError::Balance(e) => write!(
| _____________________________________________________^
265 | | f,
266 | | "A balance calculation violated amount validity bounds: {:?}.",
267 | | e
268 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/wallet/input_selection.rs#L95
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/wallet/input_selection.rs:95:17
|
95 | / write!(
96 | | f,
97 | | "An error occurred decoding the address from a payment request: {}.",
98 | | e
99 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/wallet/input_selection.rs#L88
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/wallet/input_selection.rs:88:17
|
88 | / write!(
89 | | f,
90 | | "Input selection attempted to generate an invalid proposal: {}",
91 | | e
92 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/wallet/input_selection.rs#L82
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/wallet/input_selection.rs:82:46
|
82 | InputSelectorError::Change(e) => write!(
| ______________________________________________^
83 | | f,
84 | | "Proposal generation failed due to an error in computing change or transaction fees: {}",
85 | | e
86 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/wallet/input_selection.rs#L80
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/wallet/input_selection.rs:80:17
|
80 | write!(f, "Note selection encountered the following error: {}", e)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
80 - write!(f, "Note selection encountered the following error: {}", e)
80 + write!(f, "Note selection encountered the following error: {e}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/wallet/input_selection.rs#L73
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/wallet/input_selection.rs:73:17
|
73 | / write!(
74 | | f,
75 | | "The underlying datasource produced the following error: {}",
76 | | e
77 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/scanning.rs#L51
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/scanning.rs:51:9
|
51 | / assert!(
52 | | block_range.end >= block_range.start,
53 | | "{:?} is invalid for ScanRange({:?})",
54 | | block_range,
55 | | priority,
56 | | );
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/error.rs#L233
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/error.rs:233:17
|
233 | write!(f, "The wallet tried to pay to an ephemeral transparent address as a normal output: {}", addr)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
233 - write!(f, "The wallet tried to pay to an ephemeral transparent address as a normal output: {}", addr)
233 + write!(f, "The wallet tried to pay to an ephemeral transparent address as a normal output: {addr}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/error.rs#L225
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/error.rs:225:17
|
225 | write!(f, "An error occurred decoding the address from a payment request: {}.", e)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
225 - write!(f, "An error occurred decoding the address from a payment request: {}.", e)
225 + write!(f, "An error occurred decoding the address from a payment request: {e}.")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/error.rs#L222
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/error.rs:222:39
|
222 | ...=> write!(f, "A note being spent ({:?}) does not correspond to either the internal or external full viewing key for the provided spending key.", n),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
222 - Error::NoteMismatch(n) => write!(f, "A note being spent ({:?}) does not correspond to either the internal or external full viewing key for the provided spending key.", n),
222 + Error::NoteMismatch(n) => write!(f, "A note being spent ({n:?}) does not correspond to either the internal or external full viewing key for the provided spending key."),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/error.rs#L212
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/error.rs:212:48
|
212 | Error::UnsupportedChangeType(t) => write!(f, "Attempted to send change to an unsupported pool type: {}", t),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
212 - Error::UnsupportedChangeType(t) => write!(f, "Attempted to send change to an unsupported pool type: {}", t),
212 + Error::UnsupportedChangeType(t) => write!(f, "Attempted to send change to an unsupported pool type: {t}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/error.rs#L210
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/error.rs:210:34
|
210 | Error::Builder(e) => write!(f, "An error occurred building the transaction: {}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
210 - Error::Builder(e) => write!(f, "An error occurred building the transaction: {}", e),
210 + Error::Builder(e) => write!(f, "An error occurred building the transaction: {e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/error.rs#L198
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/error.rs:198:39
|
198 | Error::BalanceError(e) => write!(
| _______________________________________^
199 | | f,
200 | | "The value lies outside the valid range of Zcash amounts: {:?}.",
201 | | e
202 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/error.rs#L172
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/error.rs:172:17
|
172 | write!(f, "Input selection attempted to construct an invalid proposal: {}", e)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
172 - write!(f, "Input selection attempted to construct an invalid proposal: {}", e)
172 + write!(f, "Input selection attempted to construct an invalid proposal: {e}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/error.rs#L169
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/error.rs:169:17
|
169 | write!(f, "Change output generation failed: {}", e)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
169 - write!(f, "Change output generation failed: {}", e)
169 + write!(f, "Change output generation failed: {e}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/error.rs#L166
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/error.rs:166:17
|
166 | write!(f, "Note selection encountered the following error: {}", e)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
166 - write!(f, "Note selection encountered the following error: {}", e)
166 + write!(f, "Note selection encountered the following error: {e}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/error.rs#L163
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/error.rs:163:17
|
163 | write!(f, "An error occurred in querying or updating a note commitment tree: {}", e)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
163 - write!(f, "An error occurred in querying or updating a note commitment tree: {}", e)
163 + write!(f, "An error occurred in querying or updating a note commitment tree: {e}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/error.rs#L156
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/error.rs:156:17
|
156 | / write!(
157 | | f,
158 | | "The underlying datasource produced the following error: {}",
159 | | e
160 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/chain/error.rs#L42
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/chain/error.rs:42:17
|
42 | write!(f, "Scanning produced the following error: {}", e)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
42 - write!(f, "Scanning produced the following error: {}", e)
42 + write!(f, "Scanning produced the following error: {e}")
|
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/chain/error.rs#L35
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/chain/error.rs:35:17
|
35 | / write!(
36 | | f,
37 | | "The underlying block store produced the following error: {}",
38 | | e
39 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_client_backend/src/data_api/chain/error.rs#L28
warning: variables can be used directly in the `format!` string
--> zcash_client_backend/src/data_api/chain/error.rs:28:17
|
28 | / write!(
29 | | f,
30 | | "The underlying datasource produced the following error: {}",
31 | | e
32 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
|
|
variables can be used directly in the `format!` string:
zcash_primitives/benches/note_decryption.rs#L126
warning: variables can be used directly in the `format!` string
--> zcash_primitives/benches/note_decryption.rs:126:34
|
126 | BenchmarkId::new(format!("compact-invalid-{}", nivks), noutputs),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
126 - BenchmarkId::new(format!("compact-invalid-{}", nivks), noutputs),
126 + BenchmarkId::new(format!("compact-invalid-{nivks}"), noutputs),
|
|
|
variables can be used directly in the `format!` string:
zcash_primitives/benches/note_decryption.rs#L121
warning: variables can be used directly in the `format!` string
--> zcash_primitives/benches/note_decryption.rs:121:34
|
121 | BenchmarkId::new(format!("compact-valid-{}", nivks), noutputs),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
121 - BenchmarkId::new(format!("compact-valid-{}", nivks), noutputs),
121 + BenchmarkId::new(format!("compact-valid-{nivks}"), noutputs),
|
|
|
variables can be used directly in the `format!` string:
zcash_primitives/benches/note_decryption.rs#L111
warning: variables can be used directly in the `format!` string
--> zcash_primitives/benches/note_decryption.rs:111:34
|
111 | BenchmarkId::new(format!("invalid-{}", nivks), noutputs),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
111 - BenchmarkId::new(format!("invalid-{}", nivks), noutputs),
111 + BenchmarkId::new(format!("invalid-{nivks}"), noutputs),
|
|
|
variables can be used directly in the `format!` string:
zcash_primitives/benches/note_decryption.rs#L106
warning: variables can be used directly in the `format!` string
--> zcash_primitives/benches/note_decryption.rs:106:34
|
106 | BenchmarkId::new(format!("valid-{}", nivks), noutputs),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
106 - BenchmarkId::new(format!("valid-{}", nivks), noutputs),
106 + BenchmarkId::new(format!("valid-{nivks}"), noutputs),
|
|
|
variables can be used directly in the `format!` string:
zcash_history/src/lib.rs#L52
warning: variables can be used directly in the `format!` string
--> zcash_history/src/lib.rs:52:35
|
52 | Self::Generated(v) => write!(f, "generated({})", v),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
52 - Self::Generated(v) => write!(f, "generated({})", v),
52 + Self::Generated(v) => write!(f, "generated({v})"),
|
|
|
variables can be used directly in the `format!` string:
zcash_history/src/lib.rs#L51
warning: variables can be used directly in the `format!` string
--> zcash_history/src/lib.rs:51:32
|
51 | Self::Stored(v) => write!(f, "stored({})", v),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
51 - Self::Stored(v) => write!(f, "stored({})", v),
51 + Self::Stored(v) => write!(f, "stored({v})"),
|
|
|
variables can be used directly in the `format!` string:
zcash_history/src/lib.rs#L33
warning: variables can be used directly in the `format!` string
--> zcash_history/src/lib.rs:33:44
|
33 | Self::ExpectedNode(Some(l)) => write!(f, "Node expected, not leaf: {}", l),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
33 - Self::ExpectedNode(Some(l)) => write!(f, "Node expected, not leaf: {}", l),
33 + Self::ExpectedNode(Some(l)) => write!(f, "Node expected, not leaf: {l}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_history/src/lib.rs#L31
warning: variables can be used directly in the `format!` string
--> zcash_history/src/lib.rs:31:42
|
31 | Self::ExpectedInMemory(l) => write!(f, "Node/leaf expected to be in memory: {}", l),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
31 - Self::ExpectedInMemory(l) => write!(f, "Node/leaf expected to be in memory: {}", l),
31 + Self::ExpectedInMemory(l) => write!(f, "Node/leaf expected to be in memory: {l}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_history/src/entry.rs#L118
warning: variables can be used directly in the `format!` string
--> zcash_history/src/entry.rs:118:38
|
118 | EntryKind::Node(l, r) => write!(f, "node({}, {}, ..)", l, r),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
118 - EntryKind::Node(l, r) => write!(f, "node({}, {}, ..)", l, r),
118 + EntryKind::Node(l, r) => write!(f, "node({l}, {r}, ..)"),
|
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/keys.rs#L1085
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/keys.rs:1085:24
|
1085 | return Err(format!(
| ________________________^
1086 | | "UIVK is for network {:?} but we expected {:?}",
1087 | | net, expected_net,
1088 | | ));
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/keys.rs#L839
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/keys.rs:839:24
|
839 | return Err(format!(
| ________________________^
840 | | "UFVK is for network {:?} but we expected {:?}",
841 | | net, expected_net,
842 | | ));
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/keys.rs#L539
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/keys.rs:539:17
|
539 | / write!(
540 | | f,
541 | | "The Unified Viewing Key does not contain a key for typecode {:?}.",
542 | | t
543 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/keys.rs#L532
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/keys.rs:532:17
|
532 | / write!(
533 | | f,
534 | | "Unified Address generation does not yet support receivers of type {:?}.",
535 | | t
536 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/keys.rs#L519
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/keys.rs:519:17
|
519 | / write!(
520 | | f,
521 | | "Child index {:?} does not generate a valid Sapling receiver",
522 | | i
523 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/keys.rs#L511
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/keys.rs:511:17
|
511 | / write!(
512 | | f,
513 | | "Child index {:?} does not generate a valid transparent receiver",
514 | | i
515 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/keys.rs#L179
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/keys.rs:179:49
|
179 | DecodingError::KeyDataInvalid(t) => write!(f, "Invalid key data for key type {:?}", t),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
179 - DecodingError::KeyDataInvalid(t) => write!(f, "Invalid key data for key type {:?}", t),
179 + DecodingError::KeyDataInvalid(t) => write!(f, "Invalid key data for key type {t:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/keys.rs#L177
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/keys.rs:177:17
|
177 | write!(f, "Insufficient data for typecode {:?}", t)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
177 - write!(f, "Insufficient data for typecode {:?}", t)
177 + write!(f, "Insufficient data for typecode {t:?}")
|
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/keys.rs#L169
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/keys.rs:169:17
|
169 | / write!(
170 | | f,
171 | | "Length mismatch: received {} bytes for typecode {:?}",
172 | | l, t
173 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/keys.rs#L162
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/keys.rs:162:46
|
162 | DecodingError::EraMismatch(e) => write!(f, "Era mismatch: actual {:?}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
162 - DecodingError::EraMismatch(e) => write!(f, "Era mismatch: actual {:?}", e),
162 + DecodingError::EraMismatch(e) => write!(f, "Era mismatch: actual {e:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/keys.rs#L158
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/keys.rs:158:44
|
158 | DecodingError::ReadError(s) => write!(f, "Read error: {}", s),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
158 - DecodingError::ReadError(s) => write!(f, "Read error: {}", s),
158 + DecodingError::ReadError(s) => write!(f, "Read error: {s}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/keys.rs#L107
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/keys.rs:107:48
|
107 | DerivationError::Transparent(e) => write!(_f, "Transparent error: {}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
107 - DerivationError::Transparent(e) => write!(_f, "Transparent error: {}", e),
107 + DerivationError::Transparent(e) => write!(_f, "Transparent error: {e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/keys.rs#L105
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/keys.rs:105:44
|
105 | DerivationError::Orchard(e) => write!(_f, "Orchard error: {}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
105 - DerivationError::Orchard(e) => write!(_f, "Orchard error: {}", e),
105 + DerivationError::Orchard(e) => write!(_f, "Orchard error: {e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/encoding.rs#L192
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/encoding.rs:192:25
|
192 | Err(format!(
| _________________________^
193 | | "Address {} is for a different network: {:?}",
194 | | address, network
195 | | ))
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/encoding.rs#L187
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/encoding.rs:187:26
|
187 | .map_err(|e| format!("{}", e))
| ^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
187 - .map_err(|e| format!("{}", e))
187 + .map_err(|e| format!("{e}"))
|
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/encoding.rs#L133
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/encoding.rs:133:49
|
133 | TransparentCodecError::Base58(e) => write!(f, "{}", e),
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
133 - TransparentCodecError::Base58(e) => write!(f, "{}", e),
133 + TransparentCodecError::Base58(e) => write!(f, "{e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/encoding.rs#L128
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/encoding.rs:128:65
|
128 | TransparentCodecError::UnsupportedAddressType(s) => write!(
| _________________________________________________________________^
129 | | f,
130 | | "Could not recognize {} as a supported p2sh or p2pkh address.",
131 | | s
132 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/encoding.rs#L70
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/encoding.rs:70:68
|
70 | Bech32DecodeError::HrpMismatch { expected, actual } => write!(
| ____________________________________________________________________^
71 | | f,
72 | | "Key was encoded for a different network: expected {}, got {}.",
73 | | expected, actual
74 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_keys/src/encoding.rs#L65
warning: variables can be used directly in the `format!` string
--> zcash_keys/src/encoding.rs:65:50
|
65 | Bech32DecodeError::Bech32Error(e) => write!(f, "{}", e),
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
65 - Bech32DecodeError::Bech32Error(e) => write!(f, "{}", e),
65 + Bech32DecodeError::Bech32Error(e) => write!(f, "{e}"),
|
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L770
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:770:21
|
770 | Err(format!("Required parameter {} not recognized", other))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
770 - Err(format!("Required parameter {} not recognized", other))
770 + Err(format!("Required parameter {other} not recognized"))
|
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L767
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:767:30
|
767 | .map_err(|e| format!("Decoded memo was invalid: {:?}", e)),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
767 - .map_err(|e| format!("Decoded memo was invalid: {:?}", e)),
767 + .map_err(|e| format!("Decoded memo was invalid: {e:?}")),
|
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L744
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:744:21
|
744 | / format!(
745 | | "Could not interpret {} as a valid Zcash address: {}",
746 | | value, err
747 | | )
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L731
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:731:34
|
731 | .map_err(|_| format!("Not a valid zat amount: {}.{}", coins, zats))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
731 - .map_err(|_| format!("Not a valid zat amount: {}.{}", coins, zats))
731 + .map_err(|_| format!("Not a valid zat amount: {coins}.{zats}"))
|
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L720
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:720:32
|
720 | Some(d) => format!("{:0<8}", d)
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
720 - Some(d) => format!("{:0<8}", d)
720 + Some(d) => format!("{d:0<8}")
|
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L491
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:491:13
|
491 | format!("{}.{:0>8}", coins, zats)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
491 - format!("{}.{:0>8}", coins, zats)
491 + format!("{coins}.{zats:0>8}")
|
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L489
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:489:13
|
489 | format!("{}", coins)
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
489 - format!("{}", coins)
489 + format!("{coins}")
|
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L472
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:472:33
|
472 | Some(i) if i > 0 => format!(".{}", i),
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
472 - Some(i) if i > 0 => format!(".{}", i),
472 + Some(i) if i > 0 => format!(".{i}"),
|
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L393
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:393:41
|
393 | Zip321Error::ParseError(format!("Error parsing query parameters: {}", e))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
393 - Zip321Error::ParseError(format!("Error parsing query parameters: {}", e))
393 + Zip321Error::ParseError(format!("Error parsing query parameters: {e}"))
|
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L382
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:382:50
|
382 | .map_err(|e| Zip321Error::ParseError(format!("Error parsing lead address: {}", e)))?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
382 - .map_err(|e| Zip321Error::ParseError(format!("Error parsing lead address: {}", e)))?;
382 + .map_err(|e| Zip321Error::ParseError(format!("Error parsing lead address: {e}")))?;
|
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L84
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:84:43
|
84 | Zip321Error::ParseError(s) => write!(f, "Parse failure: {}", s),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
84 - Zip321Error::ParseError(s) => write!(f, "Parse failure: {}", s),
84 + Zip321Error::ParseError(s) => write!(f, "Parse failure: {s}"),
|
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L82
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:82:17
|
82 | write!(f, "Payment {} is missing its recipient address", idx)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
82 - write!(f, "Payment {} is missing its recipient address", idx)
82 + write!(f, "Payment {idx} is missing its recipient address")
|
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L76
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:76:50
|
76 | Zip321Error::TransparentMemo(idx) => write!(
| __________________________________________________^
77 | | f,
78 | | "Payment {} is invalid: cannot send a memo to a transparent recipient address",
79 | | idx
80 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L60
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:60:49
|
60 | Zip321Error::MemoBytesError(err) => write!(
| _________________________________________________^
61 | | f,
62 | | "Memo exceeded maximum length or violated UTF-8 encoding restrictions: {:?}",
63 | | err
64 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L58
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:58:17
|
58 | write!(f, "Memo value was not correctly base64-encoded: {:?}", err)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
58 - write!(f, "Memo value was not correctly base64-encoded: {:?}", err)
58 + write!(f, "Memo value was not correctly base64-encoded: {err:?}")
|
|
|
variables can be used directly in the `format!` string:
components/zip321/src/lib.rs#L50
warning: variables can be used directly in the `format!` string
--> components/zip321/src/lib.rs:50:33
|
50 | Zip321Error::ParseError(format!("Address parsing failed: {}", value))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
50 - Zip321Error::ParseError(format!("Address parsing failed: {}", value))
50 + Zip321Error::ParseError(format!("Address parsing failed: {value}"))
|
|
|
variables can be used directly in the `format!` string:
zcash_proofs/src/lib.rs#L503
warning: variables can be used directly in the `format!` string
--> zcash_proofs/src/lib.rs:503:13
|
503 | / format!(
504 | | "{} failed validation:\n\
505 | | expected: {} hashing {} bytes,\n\
506 | | actual: {} hashing {} bytes from {:?}",
507 | | name, expected_hash, expected_bytes, hash, byte_count, params_source,
508 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_proofs/src/lib.rs#L452
warning: variables can be used directly in the `format!` string
--> zcash_proofs/src/lib.rs:452:13
|
452 | / format!(
453 | | "{} failed validation:\n\
454 | | expected: {} bytes,\n\
455 | | actual: {} bytes from {:?}",
456 | | name, expected_bytes, file_size, params_source,
457 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_proofs/src/lib.rs#L275
warning: variables can be used directly in the `format!` string
--> zcash_proofs/src/lib.rs:275:10
|
275 | &format!("{} + {}", params_url_1, params_url_2),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
275 - &format!("{} + {}", params_url_1, params_url_2),
275 + &format!("{params_url_1} + {params_url_2}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_proofs/src/lib.rs#L247
warning: variables can be used directly in the `format!` string
--> zcash_proofs/src/lib.rs:247:24
|
247 | let params_url_2 = format!("{}/{}.part.2", DOWNLOAD_URL, name);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
247 - let params_url_2 = format!("{}/{}.part.2", DOWNLOAD_URL, name);
247 + let params_url_2 = format!("{DOWNLOAD_URL}/{name}.part.2");
|
|
|
variables can be used directly in the `format!` string:
zcash_proofs/src/lib.rs#L245
warning: variables can be used directly in the `format!` string
--> zcash_proofs/src/lib.rs:245:24
|
245 | let params_url_1 = format!("{}/{}.part.1", DOWNLOAD_URL, name);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
245 - let params_url_1 = format!("{}/{}.part.1", DOWNLOAD_URL, name);
245 + let params_url_1 = format!("{DOWNLOAD_URL}/{name}.part.1");
|
|
|
variables can be used directly in the `format!` string:
zcash_proofs/src/downloadreader.rs#L62
warning: variables can be used directly in the `format!` string
--> zcash_proofs/src/downloadreader.rs:62:45
|
62 | ... let error = format!("download response failed: {:?}", error);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
62 - let error = format!("download response failed: {:?}", error);
62 + let error = format!("download response failed: {error:?}");
|
|
|
variables can be used directly in the `format!` string:
zcash_proofs/src/downloadreader.rs#L39
warning: variables can be used directly in the `format!` string
--> zcash_proofs/src/downloadreader.rs:39:41
|
39 | let error = Err(format!("download request failed: {:?}", error));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
39 - let error = Err(format!("download request failed: {:?}", error));
39 + let error = Err(format!("download request failed: {error:?}"));
|
|
|
variables can be used directly in the `format!` string:
zcash_proofs/src/hashreader.rs#L33
warning: variables can be used directly in the `format!` string
--> zcash_proofs/src/hashreader.rs:33:13
|
33 | write!(&mut s, "{:02x}", c).expect("writing to a string never fails");
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
33 - write!(&mut s, "{:02x}", c).expect("writing to a string never fails");
33 + write!(&mut s, "{c:02x}").expect("writing to a string never fails");
|
|
|
variables can be used directly in the `format!` string:
zcash_proofs/src/circuit/sprout/mod.rs#L243
warning: variables can be used directly in the `format!` string
--> zcash_proofs/src/circuit/sprout/mod.rs:243:33
|
243 | cs.namespace(|| format!("bit {}", i)),
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
243 - cs.namespace(|| format!("bit {}", i)),
243 + cs.namespace(|| format!("bit {i}")),
|
|
|
variables can be used directly in the `format!` string:
zcash_proofs/src/circuit/sprout/mod.rs#L158
warning: variables can be used directly in the `format!` string
--> zcash_proofs/src/circuit/sprout/mod.rs:158:43
|
158 | let cs = &mut cs.namespace(|| format!("output {}", i));
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
158 - let cs = &mut cs.namespace(|| format!("output {}", i));
158 + let cs = &mut cs.namespace(|| format!("output {i}"));
|
|
|
variables can be used directly in the `format!` string:
zcash_proofs/src/circuit/sprout/mod.rs#L98
warning: variables can be used directly in the `format!` string
--> zcash_proofs/src/circuit/sprout/mod.rs:98:43
|
98 | let cs = &mut cs.namespace(|| format!("input {}", i));
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
98 - let cs = &mut cs.namespace(|| format!("input {}", i));
98 + let cs = &mut cs.namespace(|| format!("input {i}"));
|
|
|
variables can be used directly in the `format!` string:
zcash_proofs/src/circuit/sprout/input.rs#L139
warning: variables can be used directly in the `format!` string
--> zcash_proofs/src/circuit/sprout/input.rs:139:39
|
139 | let cs = &mut cs.namespace(|| format!("bit {}", i));
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
139 - let cs = &mut cs.namespace(|| format!("bit {}", i));
139 + let cs = &mut cs.namespace(|| format!("bit {i}"));
|
|
|
variables can be used directly in the `format!` string:
zcash_proofs/src/circuit/sprout/input.rs#L109
warning: variables can be used directly in the `format!` string
--> zcash_proofs/src/circuit/sprout/input.rs:109:20
|
109 | || format!("conditionally enforce correct root for bit {}", i),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
109 - || format!("conditionally enforce correct root for bit {}", i),
109 + || format!("conditionally enforce correct root for bit {i}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_proofs/src/circuit/sprout/input.rs#L59
warning: variables can be used directly in the `format!` string
--> zcash_proofs/src/circuit/sprout/input.rs:59:43
|
59 | let cs = &mut cs.namespace(|| format!("layer {}", i));
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
59 - let cs = &mut cs.namespace(|| format!("layer {}", i));
59 + let cs = &mut cs.namespace(|| format!("layer {i}"));
|
|
|
variables can be used directly in the `format!` string:
zcash_primitives/src/transaction/fees/zip317.rs#L143
warning: variables can be used directly in the `format!` string
--> zcash_primitives/src/transaction/fees/zip317.rs:143:37
|
143 | FeeError::Balance(e) => write!(
| _____________________________________^
144 | | f,
145 | | "A balance calculation violated amount validity bounds: {}.",
146 | | e
147 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_primitives/src/transaction/builder.rs#L131
warning: variables can be used directly in the `format!` string
--> zcash_primitives/src/transaction/builder.rs:131:45
|
131 | Error::OrchardRecipient(err) => write!(f, "Could not add Orchard recipient: {}", err),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
131 - Error::OrchardRecipient(err) => write!(f, "Could not add Orchard recipient: {}", err),
131 + Error::OrchardRecipient(err) => write!(f, "Could not add Orchard recipient: {err}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_primitives/src/transaction/builder.rs#L130
warning: variables can be used directly in the `format!` string
--> zcash_primitives/src/transaction/builder.rs:130:41
|
130 | Error::OrchardSpend(err) => write!(f, "Could not add Orchard spend: {}", err),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
130 - Error::OrchardSpend(err) => write!(f, "Could not add Orchard spend: {}", err),
130 + Error::OrchardSpend(err) => write!(f, "Could not add Orchard spend: {err}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_primitives/src/transaction/builder.rs#L129
warning: variables can be used directly in the `format!` string
--> zcash_primitives/src/transaction/builder.rs:129:41
|
129 | Error::OrchardBuild(err) => write!(f, "{:?}", err),
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
129 - Error::OrchardBuild(err) => write!(f, "{:?}", err),
129 + Error::OrchardBuild(err) => write!(f, "{err:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_primitives/src/transaction/builder.rs#L126
warning: variables can be used directly in the `format!` string
--> zcash_primitives/src/transaction/builder.rs:126:30
|
126 | Error::Fee(e) => write!(f, "An error occurred in fee calculation: {}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
126 - Error::Fee(e) => write!(f, "An error occurred in fee calculation: {}", e),
126 + Error::Fee(e) => write!(f, "An error occurred in fee calculation: {e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_primitives/src/transaction/builder.rs#L125
warning: variables can be used directly in the `format!` string
--> zcash_primitives/src/transaction/builder.rs:125:34
|
125 | Error::Balance(e) => write!(f, "Invalid amount {:?}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
125 - Error::Balance(e) => write!(f, "Invalid amount {:?}", e),
125 + Error::Balance(e) => write!(f, "Invalid amount {e:?}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_primitives/src/transaction/builder.rs#L120
warning: variables can be used directly in the `format!` string
--> zcash_primitives/src/transaction/builder.rs:120:46
|
120 | Error::ChangeRequired(amount) => write!(
| ______________________________________________^
121 | | f,
122 | | "The transaction requires an additional change output of {:?} zatoshis",
123 | | amount
124 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_primitives/src/transaction/builder.rs#L115
warning: variables can be used directly in the `format!` string
--> zcash_primitives/src/transaction/builder.rs:115:49
|
115 | Error::InsufficientFunds(amount) => write!(
| _________________________________________________^
116 | | f,
117 | | "Insufficient funds for transaction construction; need an additional {:?} zatoshis",
118 | | amount
119 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
zcash_primitives/src/transaction/builder.rs#L73
warning: variables can be used directly in the `format!` string
--> zcash_primitives/src/transaction/builder.rs:73:36
|
73 | FeeError::Bundle(b) => write!(f, "Bundle structure invalid in fee calculation: {}", b),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
73 - FeeError::Bundle(b) => write!(f, "Bundle structure invalid in fee calculation: {}", b),
73 + FeeError::Bundle(b) => write!(f, "Bundle structure invalid in fee calculation: {b}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_primitives/src/transaction/builder.rs#L72
warning: variables can be used directly in the `format!` string
--> zcash_primitives/src/transaction/builder.rs:72:37
|
72 | FeeError::FeeRule(e) => write!(f, "An error occurred in fee calculation: {}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
72 - FeeError::FeeRule(e) => write!(f, "An error occurred in fee calculation: {}", e),
72 + FeeError::FeeRule(e) => write!(f, "An error occurred in fee calculation: {e}"),
|
|
|
variables can be used directly in the `format!` string:
zcash_transparent/src/address.rs#L290
warning: variables can be used directly in the `format!` string
--> zcash_transparent/src/address.rs:290:39
|
290 | let encoded = format!("{:02x}", b);
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
290 - let encoded = format!("{:02x}", b);
290 + let encoded = format!("{b:02x}");
|
|
|
variables can be used directly in the `format!` string:
components/zcash_protocol/src/memo.rs#L46
warning: variables can be used directly in the `format!` string
--> components/zcash_protocol/src/memo.rs:46:34
|
46 | Error::TooLong(n) => write!(f, "Memo length {} is larger than maximum of 512", n),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
46 - Error::TooLong(n) => write!(f, "Memo length {} is larger than maximum of 512", n),
46 + Error::TooLong(n) => write!(f, "Memo length {n} is larger than maximum of 512"),
|
|
|
variables can be used directly in the `format!` string:
components/zcash_protocol/src/memo.rs#L45
warning: variables can be used directly in the `format!` string
--> components/zcash_protocol/src/memo.rs:45:38
|
45 | Error::InvalidUtf8(e) => write!(f, "Invalid UTF-8: {}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
45 - Error::InvalidUtf8(e) => write!(f, "Invalid UTF-8: {}", e),
45 + Error::InvalidUtf8(e) => write!(f, "Invalid UTF-8: {e}"),
|
|
|
variables can be used directly in the `format!` string:
components/zcash_protocol/src/memo.rs#L25
warning: variables can be used directly in the `format!` string
--> components/zcash_protocol/src/memo.rs:25:9
|
25 | write!(f, "{:02x}", byte)?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
25 - write!(f, "{:02x}", byte)?;
25 + write!(f, "{byte:02x}")?;
|
|