-
Notifications
You must be signed in to change notification settings - Fork 196
feat(connect): support for listen address on zarf connect #3914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
brandtkeller
wants to merge
6
commits into
main
Choose a base branch
from
3913_port_forward
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandt Keller <[email protected]>
Signed-off-by: Brandt Keller <[email protected]>
Signed-off-by: Brandt Keller <[email protected]>
✅ Deploy Preview for zarf-docs canceled.
|
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
Signed-off-by: Brandt Keller <[email protected]>
Signed-off-by: Brandt Keller <[email protected]>
Signed-off-by: Brandt Keller <[email protected]>
Moving to draft - going to align to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to specify a listening address for binding the tunnel connection. This allows users to specify other addresses than the hardcoded
localhost/127.0.0.1
in such a way as to bind to all interfaces for connectivity on the zarf CLI machine.IE
zarf connect <target> --address 0.0.0.0
to bind to all interfaces.Primarily this replaces the use of
portforward.New()
which haslocalhost
hardcoded and callsportforward.NewOnAddresses()
with directly callingportfoward.NewOnAddresses()
and ensuring we pass inlocalhost
everywhere except for when overriding.Minor Note - added
ls
alias tozarf connect list
command as this follows the same patterns seen elsewhere (zarf package ls
)Related Issue
Fixes #3913
Checklist before merging