Skip to content

Fix CI #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2025
Merged

Fix CI #128

merged 1 commit into from
Jan 17, 2025

Conversation

psiinon
Copy link
Member

@psiinon psiinon commented Jan 17, 2025

No description provided.

@psiinon
Copy link
Member Author

psiinon commented Jan 17, 2025 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 32346fa1-e7d6-4dab-99b7-632639819f5c

Great job, no security vulnerabilities found in this Pull Request

@kingthorin
Copy link
Member

Oops

@kingthorin
Copy link
Member

Ugh, lemme undo that.

@dkegel-fastly
Copy link

random googling first hit has a bunch of suggestions, presumably you saw it, but if not, see https://stackoverflow.com/questions/7446187/no-module-named-pkg-resources
e.g. downgrade setuptools to before 70.0.0 ( AUTOMATIC1111/stable-diffusion-webui#15863 )

@kingthorin
Copy link
Member

Thanks! Sorry for the delay.

@psiinon
Copy link
Member Author

psiinon commented Jan 17, 2025

@dkegel-fastly thanks, but it doesnt seem to have helped

@acardnell-intruder
Copy link

Possibly this comment might be helpful / worth trying:

https://stackoverflow.com/a/76130499/22964571

poetry add --group dev setuptools

@psiinon psiinon force-pushed the fix-ci branch 3 times, most recently from 2b08449 to ee22342 Compare January 17, 2025 16:47
acardnell-intruder
acardnell-intruder reviewed Jan 17, 2025
View reviewed changes
.github/workflows/ci.yml Outdated
- run: poetry install
- run: poetry add --group dev setuptools
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need to be:

Suggested change
- run: poetry add --group dev setuptools
- run: poetry add --group dev setuptools==69.5.1

@psiinon psiinon force-pushed the fix-ci branch 2 times, most recently from 1d590df to 9e8ccc5 Compare January 17, 2025 16:51
@psiinon
Copy link
Member Author

psiinon commented Jan 17, 2025

Woohoo! Thanks @dkegel-fastly and @acardnell-intruder

@psiinon psiinon force-pushed the fix-ci branch 2 times, most recently from 74413b5 to e8339d2 Compare January 17, 2025 17:01
@kingthorin
Copy link
Member

Can go all the way to 75.3.0, after that it throws version compatibility issues:
kingthorin#2

@psiinon psiinon force-pushed the fix-ci branch 2 times, most recently from 722524b to 58f67b3 Compare January 17, 2025 17:07
@psiinon
Copy link
Member Author

psiinon commented Jan 17, 2025

Updated

@thc202
Copy link
Member

thc202 commented Jan 17, 2025

Thank you all!

@kingthorin kingthorin merged commit 352e6cc into zaproxy:main Jan 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acardnell-intruder acardnell-intruder acardnell-intruder left review comments

@thc202 thc202 thc202 approved these changes

@kingthorin kingthorin kingthorin approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@psiinon @kingthorin @dkegel-fastly @acardnell-intruder @thc202