Skip to content

Upgrade d3 version #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ Feel free to use and adapt it for your own purposes.
1. include `d3.js` and `radar.js`:

```html
<script src="https://d3js.org/d3.v4.min.js"></script>
<script src="https://zalando.github.io/tech-radar/release/radar-0.11.js"></script>
<script src="https://d3js.org/d3.v7.min.js"></script>
<script src="https://zalando.github.io/tech-radar/release/radar-0.12.js"></script>
```

2. insert an empty `svg` tag:
Expand Down
2 changes: 1 addition & 1 deletion docs/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<title>Zalando Tech Radar</title>
<link rel="shortcut icon" href="https://www.zalando.de/favicon.ico">

<script src="https://d3js.org/d3.v4.min.js"></script>
<script src="https://d3js.org/d3.v7.min.js"></script>
<script src="radar.js"></script>

<link rel="stylesheet" href="radar.css">
Expand Down
8 changes: 4 additions & 4 deletions docs/radar.js
Original file line number Diff line number Diff line change
Expand Up @@ -359,8 +359,8 @@ function radar_visualization(config) {
.text(function(d) { return d.id + ". " + d.label; })
.style("font-family", config.font_family)
.style("font-size", "11px")
.on("mouseover", function(d) { showBubble(d); highlightLegendItem(d); })
.on("mouseout", function(d) { hideBubble(d); unhighlightLegendItem(d); })
.on("mouseover", function(event, d) { showBubble(d); highlightLegendItem(d); })
.on("mouseout", function(event, d) { hideBubble(d); unhighlightLegendItem(d); })
.call(wrap_text)
.each(function() {
previousLegendHeight += d3.select(this).node().getBBox().height;
Expand Down Expand Up @@ -481,8 +481,8 @@ function radar_visualization(config) {
.append("g")
.attr("class", "blip")
.attr("transform", function(d, i) { return legend_transform(d.quadrant, d.ring, config.legend_column_width, i); })
.on("mouseover", function(d) { showBubble(d); highlightLegendItem(d); })
.on("mouseout", function(d) { hideBubble(d); unhighlightLegendItem(d); });
.on("mouseover", function(event, d) { showBubble(d); highlightLegendItem(d); })
.on("mouseout", function(event, d) { hideBubble(d); unhighlightLegendItem(d); });

// configure each blip
blips.each(function(d) {
Expand Down
Loading