gosec: fix G601 rule #2522
Merged
gosec: fix G601 rule #2522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gosec started to produce false positives "G601 (CWE-118): Implicit memory aliasing in for loop." for slices of struct pointers, see securego/gosec#966 This changes fixes G601 rule wwarnings instead of muting it. Signed-off-by: Alexander Yastrebov <[email protected]>
1 task
|
Can we somehow make gosec (and CI tests) fail in case somebody will violate this recommendation again? At the moment it seems that G601 is still a warning that could be easily ignored. |
|
@RomanZavodskikh |
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gosec started to produce false positives
"G601 (CWE-118): Implicit memory aliasing in for loop." for slices of struct pointers, see securego/gosec#966
This changes fixes G601 rule wwarnings instead of muting it.