aws: fail on ListCertificatesPages error #725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Yastrebov <[email protected]>
`getACMCertificateSummaries` did not check `ListCertificatesPages` error and returned empty `CertificateSummary` slice and no error via `filterCertificatesByTag` if `filterTag` is configured. Empty `CertificateSummary` results in empty `existingStackCertificateARNs` for each `loadBalancer` model which triggered stack update: ``` level=info msg="Updating \"internet-facing\" stack for 0 certificates / 0 ingresses" ``` and then stack deletion on the next cycle: ``` level=info msg="Deleted orphaned stack \"kube-ingress-aws-controller-aws-XXX\"" ``` due to empty certificate tags after previous update. Follow up on #658 Signed-off-by: Alexander Yastrebov <[email protected]>
|
👍 |
1 similar comment
|
👍 |
ayruslore
pushed a commit
that referenced
this pull request
May 10, 2025
ref #725 Signed-off-by: speruri <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Jun 2, 2025
Controller manages loadbalancer lifecycle based on available certificates. Prevent controller from deleting loadbalancers when there are no certificates found e.g. due to a bug like #725 or a tag filter misconfiguration (#658). Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Jun 3, 2025
Controller manages loadbalancer lifecycle based on available certificates. Prevent controller from deleting loadbalancers when there are no certificates found e.g. due to a bug like #725 or a tag filter misconfiguration (#658). Signed-off-by: Alexander Yastrebov <[email protected]>
madumalt
pushed a commit
that referenced
this pull request
Jun 16, 2025
Controller manages loadbalancer lifecycle based on available certificates. Prevent controller from deleting loadbalancers when there are no certificates found e.g. due to a bug like #725 or a tag filter misconfiguration (#658). Signed-off-by: Alexander Yastrebov <[email protected]>
madumalt
pushed a commit
to madumalt/kube-ingress-aws-controller
that referenced
this pull request
Jun 16, 2025
Controller manages loadbalancer lifecycle based on available certificates. Prevent controller from deleting loadbalancers when there are no certificates found e.g. due to a bug like zalando-incubator#725 or a tag filter misconfiguration (zalando-incubator#658). Signed-off-by: Alexander Yastrebov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getACMCertificateSummariesdid not checkListCertificatesPageserrorand returned empty
CertificateSummaryslice and no errorvia
filterCertificatesByTagiffilterTagis configured.Empty
CertificateSummaryresults in emptyexistingStackCertificateARNsfor each
loadBalancermodel which triggered stack update:and then stack deletion on the next cycle:
due to empty certificate tags after previous update.
Follow up on #658