sync with upstream #116
Merged
sync with upstream #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exposes the rocksdb_get_db_identity function, which calls DB::GetDbIdentity. It also adds a setter and accessor to Options to change the option. This function is useful to determine if two RocksDB copies originated from the same place.
This was added to the C API in RocksDB 9.7.0. The RocksDB wiki recommends setting this option to true: "We recommend to set track_and_verify_wals_in_manifest to true for production, it has been enabled in production for the entire database cluster serving the social graph for all Meta apps." See: https://github.com/facebook/rocksdb/wiki/Track-WAL-in-MANIFEST
zaidoon1
force-pushed
the
zaidoon/2024-12-11-sync
branch
from
9a698af to
356fbec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.