-
Notifications
You must be signed in to change notification settings - Fork 19
Suuport dbt-core v1.10 #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Yu Ishikawa <[email protected]>
Signed-off-by: Yu Ishikawa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the dbt-core version to 1.10 with associated changes to metadata models. Key changes include:
- Upgrading the dbt_version string and adding the new invocation_started_at field.
- Adding new optional fields (such as doc_blocks) and refactoring enum and type definitions across several parser modules.
- Renaming and adjusting type annotations (e.g. switching from specific enums to string types) to align with dbt-core v1.10 expectations.
Reviewed Changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
File | Description |
---|---|
dbt_artifacts_parser/parsers/sources/sources_v3.py | Updated dbt_version and added invocation_started_at field. |
dbt_artifacts_parser/parsers/run_results/run_results_v6.py | Updated version, added invocation_started_at, and introduced a new status "no_op". |
dbt_artifacts_parser/parsers/manifest/manifest_v12.py | Extensive updates including version upgrade, added doc_blocks, type changes (from enums to str), and renaming/refactoring of DependsOn and Freshness classes. |
dbt_artifacts_parser/parsers/catalog/catalog_v1.py | Updated dbt_version and added the invocation_started_at field. |
Files not reviewed (3)
- dbt_artifacts_parser/resources/catalog/catalog_v1.json: Language not supported
- dbt_artifacts_parser/resources/run-results/run-results_v6.json: Language not supported
- dbt_artifacts_parser/resources/sources/sources_v3.json: Language not supported
Comments suppressed due to low confidence (2)
dbt_artifacts_parser/parsers/manifest/manifest_v12.py:1384
- [nitpick] Consider using a more descriptive and consistent naming convention for the Freshness-related classes instead of relying on numeric suffixes.
class Freshness1(BaseParserModel):
dbt_artifacts_parser/parsers/manifest/manifest_v12.py:1577
- [nitpick] Consider adopting a clearer naming convention for the DependsOn classes rather than sequential numbering to enhance clarity and consistency.
class DependsOn10(BaseParserModel):
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
No description provided.