CLN: cleanup unused internal conf parameter within_pytest
#4951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
added
dead code
neutrinoceros
changed the title
within_pytest
neutrinoceros
changed the title
within_pytestwithin_pytest
neutrinoceros
force-pushed
the
tst/cleanup_dead_within_pytest
branch
from
87e5c61 to
f30fec5
Compare
Should we bump the minimum pytest version for yt testing? It's currently 6.1. |
|
No need to, 8.3.0 just added documentation for a mechanism that already existed, and which we're not using the anyway. |
chrishavlin
approved these changes
Jul 22, 2024
jzuhone
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This doesn't seem to be used anywhere and the release notes for pytest 8.3.0 make it clear that it's even redundant so we shouldn't ever actually need it.
See pytest-dev/pytest#12153