-
-
Notifications
You must be signed in to change notification settings - Fork 170
Introduce generics to splay #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sejongk Thanks for your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the lint errors, it is thought to be the lint malfunction. 🤔
I changed the Node to the same receiver name as Tree to avoid it for now.
Codecov Report
@@ Coverage Diff @@
## main #346 +/- ##
=======================================
Coverage 48.30% 48.30%
=======================================
Files 65 65
Lines 5473 5473
=======================================
Hits 2644 2644
Misses 2551 2551
Partials 278 278
Continue to review full report at Codecov.
|
@hackerwins Thanks for your edit.
I totally agree with you. I will check whether the linter is working properly and share related information if the current linter's upgrade is necessary. |
@hackerwins It seems a bug in the |
Co-authored-by: Youngteac Hong <[email protected]>
What this PR does / why we need it:
Introduce generics to splay
Which issue(s) this PR fixes:
Fixes #304
Special notes for your reviewer:
By introducing generics to splay, we don't have to use the type assertions in RGATreeSplit and RGATreeList.
If there is anything that needs improvement, please let me know. :)
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: