Skip to content

Add profile-stack example #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Add profile-stack example #38

merged 1 commit into from
Dec 21, 2022

Conversation

chacha912
Copy link
Contributor

@chacha912 chacha912 commented Dec 20, 2022

What this PR does / why we need it?

  • Add profile-stack example

image

  • When multiple users access the profile-stack example page, the number of users does not match the actual number of users who access the document because the document key is the same. Would it be better to access the example page with a new document key?
    • In the example below, two users are displayed on the page, but four are displayed in the iframe.
      image

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@@ -0,0 +1,2 @@
export const DocumentStructure = `
`;
Copy link
Member

@hackerwins hackerwins Dec 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this file is empty because Profile Stack doesn't have a document structure.

How about changing DocumentStructure to How it works and explaining how it behaves?
For that, it might be better to express it in markdown format.

@hackerwins
Copy link
Member

When multiple users access the profile-stack example page, the number of users does not match the actual number of users who access the document because the document key is the same. Would it be better to access the example page with a new document key?

It would be better to issue a new document key. For the same reason, I think liveblocks also issues keys(roomId) for each user.

Screenshot 2022-12-21 at 9 09 58 AM

@chacha912 chacha912 marked this pull request as draft December 21, 2022 01:42
@chacha912 chacha912 marked this pull request as ready for review December 21, 2022 02:34
@hackerwins hackerwins merged commit 1428b95 into main Dec 21, 2022
@hackerwins hackerwins deleted the profile-stack branch December 21, 2022 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants