Fix violations #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
| @@ -8,7 +8,7 @@ | |||
|
|
|||
|
|
|||
| final class NPathComplexityRule : Rule { | |||
| let rule = "NPathComplexity" | |||
| var rule = "NPathComplexity" | |||
S2dentik
force-pushed
the
fixViolations
branch
2 times, most recently
from
9ddb00f to
9ece84e
Compare
Add ViolationData struct This struct encapsulates some arguments passed to Violation thus reducing init arguments and increasing readability. Add TemperStatistics struct This struct encapsulates statistics about Temper class to reduce complexity and instance variables over the class. Refactor Finder class Add generic removeDuplicated() extension over array, make some functions extensions over the class. Remove violations in Scissors Make methods ExtendedComponent doesn't depend upon extensions. Refactor appendComponents(_:_:) method. Remove parent from list of parameters over ExtendedComponent and make it nil by default. Refactor NPath Complexity Add extensions on ComponentType for a more self-explaining way of calculating complexity over a component. Remove some newlines to clear the corresponding warning Refactor Temper Reduce CyclomaticComplexity of checkPair(_:_:) and updateStatistics(_:_:) methods. Refactor Caprice module Add reduceTwoElements(_:_:) function to iterate over the arguments intercepted by the module. Refactor optionObjectFromOption(_:_:) to work more generically and reduce complexity.
|
I'm going to merge it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ViolationData struct
This struct encapsulates some arguments passed to Violation thus reducing init arguments
and increasing readability.
Add TemperStatistics struct
This struct encapsulates statistics about Temper class to reduce complexity and instance variables over
the class.
Refactor Finder class
Add generic removeDuplicated() extension over array, make some functions
extensions over the class.
Remove violations in Scissors
Make methods ExtendedComponent doesn't depend upon extensions.
Refactor appendComponents(::) method.
Remove parent from list of parameters over ExtendedComponent and make it
nil by default.
Refactor NPath Complexity
Add extensions on ComponentType for a more self-explaining way of calculating
complexity over a component.
Remove some newlines to clear the corresponding warning
Refactor Temper
Reduce CyclomaticComplexity of checkPair(::) and updateStatistics(::) methods.
Refactor Caprice module
Add reduceTwoElements(::) function to iterate over the arguments intercepted by the module.
Refactor optionObjectFromOption(::) to work more generically and reduce complexity.