-
Notifications
You must be signed in to change notification settings - Fork 834
Add validation to ensure that settings.configs values are dictionaries, in order to prevent misuse #1547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ryu0118
wants to merge
23
commits into
yonaskolb:master
Choose a base branch
from
Ryu0118:validate_invalid_configs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giginet
reviewed
May 20, 2025
freddi-kit
reviewed
May 20, 2025
freddi-kit
reviewed
May 20, 2025
freddi-kit
reviewed
May 20, 2025
Could you also update |
c79e246
to
340b8e6
Compare
giginet
reviewed
May 20, 2025
Ryu0118
commented
May 20, 2025
giginet
approved these changes
May 20, 2025
freddi-kit
approved these changes
May 20, 2025
Ryu0118
commented
May 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, the following YAML is correctly detected as invalid:
settings:
configs:
invalid_key: value
However, the following YAML is not detected as invalid:
targets:
invalid_target:
settings:
configs:
invalid_key: value
targets:
valid_target1:
type: application
platform: iOS
valid_target2:
type: application
platform: iOS
aggregateTargets:
invalid_target:
targets:
- valid_target1
- valid_target2
settings:
configs:
invalid_key: value
This needs to be fixed.
…dictionary to Settings
giginet
reviewed
May 26, 2025
giginet
reviewed
May 26, 2025
giginet
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In our team, we previously encountered cases where
settings.configs
was misused by passing non-dictionary values.However, because no error was raised, the issue went unnoticed.
Proposed Solution
This PR adds validation to ensure that all values in
settings.configs
are dictionaries.For example, the following invalid configuration will now throw a
SpecParsingError.invalidConfigsFormat
during parsing:If any non-dictionary values are found, a
SpecParsingError.invalidConfigsFormat
is thrown during parsing.By introducing this validation, such misconfigurations can now be detected early.