Custom methods in Rails Form Builders do not render within Phlex components without being wrapped in `raw`

[tcannonfodder]

Hey y'all!

I've got a minimal reproduction of this here: practical-computer/phlex-form-builder-bug@167a535

In short, if you've written custom methods for a FormBuilder subclass, their output is not rendered unless you wrap it in raw(), even if you're using the @template instance to build out the buffer in the form builder

This is a gnarly regression from Phlex 1, especially if you're leveraging FormBuilders to wrap around ActiveModel & build usable form markup that is aware of form properties.

I tried to keep the reproduction as straightforward as possible, and contained into a single commit for easier debugging; let me know if there's anything I can help with!

[christopher-b]

Related: If you pass a FormBuilder into a component and try to call methods on that builder, you will not get any output unless you wrap the the calls in raw():

class Components::Test < Components::Base
  prop :form, ActionView::Helpers::FormBuilder, reader: :private

  def view_template
    # No output: 
    form.fields_for(:field, model) do |form|
      #...
    end
  end
end

[joeldrapper]

If you pass a FormBuilder into a component and try to call methods on that builder, you will not get any output unless you wrap the the calls in raw()

That’s because the form builder is entirely unadapted for Phlex. It’s just returning strings. In ERB the <%= is like calling raw. While we can probably address the main issue, I don’t think we’ll be able to address this one. 🤔

[sisodiaa]

I just updated phlex-rails from 2.0.0 to 2.2.0, and I am also facing this issue. The code snippet below from form builder was working well with 2.0.0.

  def errors_list(method, options = {})
    if self.object.errors[method].any?
      @template.content_tag(:ul, class: [ "text-xs text-error-600", options.delete(:class) ], **options) do
        self.object.errors.full_messages_for(method).map do |message|
           @template.content_tag(:li, message, class: "#{method.to_s.dasherize}-error")
        end.join.html_safe
      end
    end
  end

Using raw to circumvent this issue as of now.