Skip to content

Fix hardcoded table name, update Oracle workflow #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 1, 2023

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues

@what-the-diff
Copy link

what-the-diff bot commented Jul 27, 2023

PR Summary

  • Improved Table Name Reference in SQL Queries
    The SQL queries in CteItemTreeTraversal.php file have been updated to reference the table names dynamically. This means that the table names are no longer hardcoded and this change makes the code more flexible and much easier to maintain. If the table names change in the future, the queries will automatically pick up the new names.

@arogachev arogachev requested a review from a team July 27, 2023 10:43
@arogachev arogachev self-assigned this Jul 27, 2023
@arogachev arogachev added the type:bug Bug label Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +2.19% 🎉

Comparison is base (0951c18) 97.80% compared to head (83d5e29) 100.00%.
Report is 1 commits behind head on master.

❗ Current head 83d5e29 differs from pull request most recent head e66c53b. Consider uploading reports for the commit e66c53b to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             master       #36      +/-   ##
=============================================
+ Coverage     97.80%   100.00%   +2.19%     
- Complexity       78        85       +7     
=============================================
  Files             9         8       -1     
  Lines           455       436      -19     
=============================================
- Hits            445       436       -9     
+ Misses           10         0      -10     
Files Changed Coverage Δ
src/DbSchemaManager.php 100.00% <100.00%> (ø)
src/ItemTreeTraversal/CteItemTreeTraversal.php 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arogachev arogachev marked this pull request as draft July 27, 2023 10:56
@arogachev arogachev changed the title Fix hardcoded table name Fix hardcoded table name, update Oracle workflow Jul 27, 2023
@arogachev arogachev marked this pull request as ready for review July 30, 2023 07:25
@arogachev arogachev added the status:code review The pull request needs review. label Jul 30, 2023
@arogachev arogachev merged commit 518a745 into master Aug 1, 2023
@arogachev arogachev deleted the fix-hardcoded-table branch August 1, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review. type:bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants