Refactor data readers #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #822 +/- ##
=========================================
Coverage 99.24% 99.24%
- Complexity 1550 1554 +4
=========================================
Files 98 98
Lines 3848 3852 +4
=========================================
+ Hits 3819 3823 +4
Misses 29 29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # src/Command/AbstractCommand.php # tests/Common/CommonCommandTest.php
# Conflicts: # src/Query/BatchQueryResultInterface.php # src/Query/Query.php # src/Query/QueryInterface.php
…ctor-data-readers # Conflicts: # src/Query/BatchQueryResultInterface.php # src/Query/Query.php # src/Query/QueryInterface.php
samdark
approved these changes
Apr 5, 2025
# Conflicts: # src/Query/Query.php
vjik
approved these changes
Apr 7, 2025
Tigrov
added
status:code review
vjik
approved these changes
Apr 16, 2025
samdark
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataReaderclassDataReadertoPdoDataReaderclassBatchQueryResultDataReaderInterfaceas a result of methodQuery::each()As a result
->rewind()can be called multiple times before iteration. It allows to get access to the first row before iteration.Related PRs