Skip to content

Fix #2198 #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix #2198 #2203

wants to merge 1 commit into from

Conversation

yhirose
Copy link
Owner

@yhirose yhirose commented Aug 9, 2025

No description provided.

@yhirose yhirose mentioned this pull request Aug 9, 2025
Closed
thbeu
thbeu reviewed Aug 9, 2025
View reviewed changes
Copy link
Contributor

@thbeu thbeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the compile-time switch over this run-time switch since we know a-priori that CreateFile2 is available on MSVC and Win8.

@apocelipes
Copy link

@yhirose Thanks for watching into this issue.

This patch cannot work, because my mingw-w64 does not have CreateFile2. The code use it on runtime so compile generates compiler errors.

I think we need to introduce a macro to determine which function can be used at compiling time.

@yhirose yhirose closed this Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thbeu thbeu thbeu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yhirose @apocelipes @thbeu