Skip to content

Provide a CMake option to disable C++ exceptions #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

petrhosek
Copy link
Contributor

This allows disabling the use of C++ exceptions at CMake configure time. The value is encoded in the generated httplibTargets.cmake file and will be used by CMake projects that import it.

@yhirose
Copy link
Owner

yhirose commented Jun 5, 2023

@petrhosek I am not maintaining CMake related files in this project though, your change looks good to me. Could you please add a comment right above the change as other options have? Thanks!

This allows disabling the use of C++ exceptions at CMake configure time.
The value is encoded in the generated httplibTargets.cmake file and will
be used by CMake projects that import it.
@petrhosek
Copy link
Contributor Author

Could you please add a comment right above the change as other options have?

Done.

@yhirose yhirose merged commit 3e287b3 into yhirose:master Jun 6, 2023
@yhirose
Copy link
Owner

yhirose commented Jun 6, 2023

@petrhosek thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants