undef poll at the end if CPPHTTPLIB_USE_POLL #1427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhirose
reviewed
Nov 13, 2022
httplib.h
Outdated
| @@ -8405,4 +8405,8 @@ inline SSL_CTX *Client::ssl_context() const { | |||
|
|
|||
| } // namespace httplib | |||
|
|
|||
| #ifdef CPPHTTPLIB_USE_POLL | |||
There was a problem hiding this comment.
Could you change it to #if defined(_WIN32) && defined(CPPHTTPLIB_USE_POLL)?
|
Thanks for your contribution! |
ExclusiveOrange
pushed a commit
to ExclusiveOrange/cpp-httplib-exor
that referenced
this pull request
May 2, 2023
* undef poll at the end if CPPHTTPLIB_USE_POLL * win32 only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replacement of
pollwithWSAPollshould be reverted to avoid propagation to other source files.