Get client process id over ip/port when server runs on UNIX socket. #1418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* set FD_CLOEXEC by default * invoke `socket_options` callback if set
HTTP Request header "REMOTE_PORT" contains client process id if possible when Server works on UNIX socket.
|
@gh4ck3r yes, I think it's acceptable to use a process id for port. Thanks again for the fine contribution! |
ExclusiveOrange
pushed a commit
to ExclusiveOrange/cpp-httplib-exor
that referenced
this pull request
May 2, 2023
…hirose#1418) * handle socket options for UNIX socket same as others * set FD_CLOEXEC by default * invoke `socket_options` callback if set * Offer Client info even on UNIX socket based Server HTTP Request header "REMOTE_PORT" contains client process id if possible when Server works on UNIX socket. * retrigger checks * retrigger checks * add support macOS Co-authored-by: Changbin Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put client process id into
REMOTE_PORTin http request header when server runs on UNIX socket.The name might be awkward for process id but, I think, it's acceptable because process id can be used to address client like ip/port. As a matter of fact, process id and ip/port never coexists.
@AhnLab-OSSG