build: set soversion to major.minor #1357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 0.11 broke backwards compatibility, meaning that different cpp-httplib versions are compatible with each other only if the major and minor version numbers are the same. This patch reflects this in the build systems. See yhirose#1209 for some more context.
|
@Tachi107, thank you for the change. Yes, if only the patch version changes, it guarantees the backward compatibility. |
ExclusiveOrange
pushed a commit
to ExclusiveOrange/cpp-httplib-exor
that referenced
this pull request
May 2, 2023
Release 0.11 broke backwards compatibility, meaning that different cpp-httplib versions are compatible with each other only if the major and minor version numbers are the same. This patch reflects this in the build systems. See yhirose#1209 for some more context.
|
The comment is no more correct, it should be: |
|
@abouvier what are you referring to? Edit: got it, feel free to update it, I don't care enough about CMake to do it :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 0.11 broke backwards compatibility, meaning that different cpp-httplib versions are compatible with each other only if the major and minor version numbers are the same.
This patch reflects this in the build systems.
See #1209 for some more context.
@yhirose, is it correct that cpp-httplib only maintains backwards compatibility only if both the major and the minor version components are the same? (i.e.
0.10.3and0.10.9are compatible, but0.10.9and0.11.0are not)Cc: @sum01