-
Notifications
You must be signed in to change notification settings - Fork 305
Tags refactor #1250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tags refactor #1250
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the tagging system by deprecating the Tag Graph and replacing it with embedded tags in objects. Key changes include updating tests to work with dictionary‐based tag structures, refactoring tag-related methods in the core schemas and API endpoints, and removing obsolete graph queries.
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
tests/schemas/tag.py | Updated tests use new embedded tag format and adjust expiration assertions. |
tests/schemas/package.py | Modified tests to iterate over dictionary values for tags. |
tests/schemas/entity.py | Removed tests related to the deprecated tag graph. |
tests/helpers.py | Added a sleep delay to assist with eventual consistency in tests. |
tests/core_tests/tasks.py | Changed set assertions to count assertions for tag operations. |
tests/apiv2/* | Updated tag handling logic to use the new embedded tag representations. |
plugins/analytics/public/expire_tags.py | Refactored expiration logic to use the new embedded tag system. |
core/web/apiv2/* | Removed obsolete graph query parameters and updated tag extraction logic. |
core/schemas/tag.py | Removed an in-place normalize function in favor of the one defined in model.py. |
core/schemas/model.py | Introduced YetiTagInstance and refactored tag methods to use embedded tags. |
core/schemas/graph.py | Removed the TagRelationship definition and related logic. |
core/database_arango.py | Removed tagging methods that relied on graph queries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR! potential typo + left some comments and questions about tag
function implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go!
This PR tackles #1165. Essentially:
.tags
attribute to be a list instead of a dict.BREAKING CHANGES