Bugfix on ACLs #1242
Merged
Bugfix on ACLs #1242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tomchop
commented
Mar 27, 2025
tomchop
commented
- Return all ACLs by default (useful when checking)
- Have an option to only return default ACLs (useful when editing)
- Add a test
There was a problem hiding this comment.
Pull Request Overview
This PR fixes ACL handling by returning all ACLs by default while adding an option to retrieve only default ACLs, and includes new tests to verify the behavior.
- Updated test data and added a new test (test_get_acls) in tests/schemas/rbac.py
- Modified ACL retrieval in core/web/apiv2/rbac.py and core/schemas/model.py to support a "direct" option
- Updated dfiq logic in core/schemas/dfiq.py to initialize ACLs via rbac.set_acls
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/schemas/rbac.py | Updated user, group, and entity names; added a new test to verify ACL retrieval |
| core/web/apiv2/rbac.py | Modified get_acl_details to retrieve ACLs using the new direct parameter |
| core/schemas/model.py | Updated get_acls to support a direct parameter, affecting the traversal logic |
| core/schemas/dfiq.py | Added call to rbac.set_acls during dfiq object processing to ensure ACLs are set |
udgover
reviewed
Mar 28, 2025
| @@ -96,18 +96,19 @@ def __init__(self, **data): | |||
| def acls(self): | |||
| return self._acls | |||
|
|
|||
| def get_acls(self) -> None: | |||
| def get_acls(self, direct=False) -> None: | |||
| """Returns the permissions assigned to a user. | |||
| Args: | |||
| user: The user to check permissions for. | |||
There was a problem hiding this comment.
Looks like Args documentation are no longer relevant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.