feat: display correct symbol

[w84april]

Description

Display gauge asset symbol if "Deposit & Stake" is on

Related Issue

rossgalloway/ySHIP#46

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
yearnfi	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 27, 2025 3:17pm

[Copilot]

Pull Request Overview

This PR updates the vault staking data hooks and UI components to display the correct gauge asset symbol when "Deposit & Stake" is active. Key changes include:

• Adding a new field (stakedGaugeSymbol) to the TStakingInfo type and updating data extraction in useVaultStakingData.
• Updating the RewardsTab component to display the symbol from the newly fetched stakedGaugeSymbol.
• Modifying the QuickActionsTo component to select the correct symbol based on the auto-staking status.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
apps/vaults/hooks/useVaultStakingData.ts	Introduces stakedGaugeSymbol and adjusts data extraction logic for staking data.
apps/vaults-v3/components/details/actions/QuickActionsTo.tsx	Implements selection of the correct symbol and introduces a debug log.
apps/vaults-v3/components/details/RewardsTab.tsx	Removes redundant symbol fetching and displays the new stakedGaugeSymbol.

[rossgalloway]

I think this is good to go. pretty simple.

[murderteeth]

lg - note on multicalls. we should start using key-value maps instead of bare result arrays. the difference is in not having to document and use indexes on the results, we use readable named keys instead. maintainability+

[rossgalloway]

lg - note on multicalls. we should start using key-value maps instead of bare result arrays. the difference is in not having to document and use indexes on the results, we use readable named keys instead. maintainability+

new commit attempts to fix this. How did 04-mini do?

[Copilot]

Pull Request Overview

This PR updates the vault staking data flow to include and display the gauge asset symbol when "Deposit & Stake" is active. Key changes include:

• Adding a new property and decoding logic for stakedGaugeSymbol in the vault staking hook.
• Updating QuickActions and Rewards components to use the new stakedGaugeSymbol.
• Removing a redundant read contract call for symbol in the RewardsTab component.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
apps/vaults/hooks/useVaultStakingData.ts	Added stakedGaugeSymbol support in state and contract calls to decode it.
apps/vaults-v3/components/details/actions/QuickActionsTo.tsx	Updated quick actions to display stakedGaugeSymbol when auto-staking is enabled.
apps/vaults-v3/components/details/RewardsTab.tsx	Modified symbol display to use stakedGaugeSymbol from vaultData.

Comments suppressed due to low confidence (1)

apps/vaults/hooks/useVaultStakingData.ts:83

• Consider verifying the fallback logic at line 83; using 'foundVaultWithDisabledStaking || zeroAddress' might be redundant given the ternary condition. Reverting to the previous pattern could improve clarity.

const stakingAddress = foundVaultWithDisabledStaking ? toAddress(foundVaultWithDisabledStaking || zeroAddress) : toAddress(props.currentVault.staking.address);