Skip to content

ci: update to Node.js v18 #5051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/actions/prepare/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,17 @@ inputs:
description: 'Whether to minify the bundle'
required: false
default: 'false'
node-version:
description: 'The version of Node.js to use'
required: false
default: '18.x'

runs:
using: composite
steps:
- uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: ${{ inputs.node-version }}
check-latest: true

#region Build the standard bundle
Expand Down
21 changes: 8 additions & 13 deletions .github/workflows/e2e-preact-cli-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,29 +20,24 @@ jobs:
- uses: actions/checkout@v3

- uses: ./.github/actions/prepare
with:
# Remove when Preact CLI supports Node.js 18
node-version: 16.x

- name: 'Running the integration test'
run: |
source scripts/e2e-setup-ci.sh
git clone https://github.com/preactjs-templates/default.git default
cd default/template
touch yarn.lock
echo $(cat package.json | jq '.name = "pnp-test"') > package.json
yarn

yarn dlx preact-cli create default default-app --yarn
cd default-app
yarn build

- name: 'Running the TypeScript integration test'
run: |
source scripts/e2e-setup-ci.sh
git clone https://github.com/preactjs-templates/typescript.git default
cd default/template

# TODO: Remove once https://github.com/preactjs-templates/typescript/issues/71 is fixed
rm -rf tests

touch yarn.lock
echo $(cat package.json | jq '.name = "pnp-test"') > package.json
yarn
yarn dlx preact-cli create typescript ts-app --yarn
cd ts-app
yarn build
if: |
success() || failure()
10 changes: 4 additions & 6 deletions .github/workflows/integration-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,9 @@ jobs:
- run: |
git fetch --no-tags --unshallow origin HEAD master

- name: 'Use Node.js 16.x'
uses: actions/setup-node@v3
- uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x

- name: 'Check that the Yarn files don''t change on new installs (fix w/ "yarn install")'
run: |
Expand Down Expand Up @@ -151,10 +150,9 @@ jobs:
steps:
- uses: actions/checkout@v3

- name: 'Use Node.js 16.x'
uses: actions/setup-node@v3
- uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x

- name: 'Build bundle & plugins'
run: |
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/release-candidate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,9 @@ jobs:
- name: 'Retrieve all the relevant tags'
run: git fetch --depth=1 origin +refs/tags/*:refs/tags/*

- name: 'Use Node.js 16.x'
uses: actions/setup-node@v3
- uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x

- name: 'Build a binary for convenience'
run: |
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/sherlock-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,9 @@ jobs:
steps:
- uses: actions/checkout@v3

- name: 'Install Node'
uses: actions/setup-node@v3
- uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: 18.x

- name: 'Always use the latest sherlock'
run: |
Expand Down