Fixes e2e tests #4377
Merged
Fixes e2e tests #4377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still don't understand why the Parcel E2E doesn't pass in this PR - it's almost like the E2E are running against an out-of-date version of the build 🤔 |
|
I'll try to merge and see if it still breaks on master |
|
Somebody else also reported another problem with PnP: parcel-bundler/parcel#7999 |
|
I'm trying to reproduce it but no luck so far, even after tweaking my JSTransformer file 🤔 |
merceyz
pushed a commit
that referenced
this pull request
Jul 20, 2022
* Fixes e2e tests * Fixes typo * Triggers the Vue / Parcel workflows * Versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Attempting to fix the E2E tests
How did you fix it?
...
Checklist