fix(pnpm): pnpm linker no longer removes node_modules when nm linker is active #4206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larixer
changed the title
larixer
changed the title
This was referenced Mar 10, 2022
arcanis
reviewed
Mar 15, 2022
| await this.asyncActions.wait(), | ||
| await this.asyncActions.wait(); |
There was a problem hiding this comment.
Was this the reason for the flaky test? 🤯
arcanis
approved these changes
Mar 15, 2022
This was referenced Apr 6, 2022
dehy
added a commit
to dehy/crowd-news
that referenced
this pull request
Apr 15, 2022
merceyz
pushed a commit
that referenced
this pull request
May 12, 2022
…is active (#4206) * Fix: pnpm linker no longer removes node_modules when nm linker is active * Updates artifact cleanup code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The pnpm linker attempts to delete
node_modulesdirectory all the time, this causes install failure when Yarn has no permissions. This problem happens even whennode-moduleslinker is active.Fixes #4172
Fixes #4160
How did you fix it?
Based on the evaluation of pnpm linker finalizeInstall code, seems this behavior - to manipulate node_modules directory- was not intended. I have updated it so that this code was not run.
Checklist