Skip to content

[Bug?]: enableGlobalCache is automatically set to false on migrating #5895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
JounQin opened this issue Oct 30, 2023 · 2 comments · Fixed by #5940
Closed
1 task done

[Bug?]: enableGlobalCache is automatically set to false on migrating #5895

JounQin opened this issue Oct 30, 2023 · 2 comments · Fixed by #5940
Labels
bug Something isn't working

Comments

@JounQin
Copy link

JounQin commented Oct 30, 2023

Self-service

  • I'd be willing to implement a fix

Describe the bug

image

The following are added into .yamlrc.yml, but I didn't notice these changes mentioned in the release note: https://yarnpkg.com/blog/release/4.0

compressionLevel: mixed

enableGlobalCache: false

To reproduce

N/A

Environment

System:
    OS: macOS 14.1
    CPU: (10) arm64 Apple M1 Max
  Binaries:
    Node: 18.18.2 - ~/tmp/xfs-5dcbb7f9/node
    Yarn: 4.0.1 - ~/tmp/xfs-5dcbb7f9/yarn
    npm: 9.8.1 - ~/Library/Caches/fnm_multishells/42780_1698647724002/bin/npm
  npmPackages:
    jest: ^29.6.4 => 29.6.4

Additional context

No response

@JounQin JounQin added the bug Something isn't working label Oct 30, 2023
@arcanis
Copy link
Member

arcanis commented Oct 30, 2023

Since we changed the default settings in Yarn 4, Yarn automatically pins the old defaults when running the first install on a Yarn 3 project, so as to limit the amount of potentially breaking changes. You're free to remove those settings and re-run an install at your convenience.

@arcanis arcanis closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2023
@JounQin
Copy link
Author

JounQin commented Oct 30, 2023

@arcanis Thanks for the clarification, should these default changes be mentioned in the release note? https://yarnpkg.com/blog/release/4.0

@arcanis arcanis mentioned this issue Nov 4, 2023
3 tasks
@arcanis arcanis reopened this Nov 4, 2023
arcanis added a commit that referenced this issue Nov 4, 2023
**What's the problem this PR addresses?**
<!-- Describe the rationale of your PR. -->
<!-- Link all issues that it closes. (Closes/Resolves #xxxx.) -->

Fixes #5939
Fixes #5895

**How did you fix it?**
<!-- A detailed description of your implementation. -->

...

**Checklist**
<!--- Don't worry if you miss something, chores are automatically
tested. -->
<!--- This checklist exists to help you remember doing the chores when
you submit a PR. -->
<!--- Put an `x` in all the boxes that apply. -->
- [ ] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).

<!-- See
https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
for more details. -->
<!-- Check with `yarn version check` and fix with `yarn version check
-i` -->
- [ ] I have set the packages that need to be released for my changes to
be effective.

<!-- The "Testing chores" workflow validates that your PR follows our
guidelines. -->
<!-- If it doesn't pass, click on it to see details as to what your PR
might be missing. -->
- [ ] I will check that all automated PR checks pass before the PR gets
reviewed.
jplukas pushed a commit to jplukas/berry that referenced this issue Nov 4, 2023
**What's the problem this PR addresses?**
<!-- Describe the rationale of your PR. -->
<!-- Link all issues that it closes. (Closes/Resolves #xxxx.) -->

Fixes yarnpkg#5939
Fixes yarnpkg#5895

**How did you fix it?**
<!-- A detailed description of your implementation. -->

...

**Checklist**
<!--- Don't worry if you miss something, chores are automatically
tested. -->
<!--- This checklist exists to help you remember doing the chores when
you submit a PR. -->
<!--- Put an `x` in all the boxes that apply. -->
- [ ] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).

<!-- See
https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
for more details. -->
<!-- Check with `yarn version check` and fix with `yarn version check
-i` -->
- [ ] I have set the packages that need to be released for my changes to
be effective.

<!-- The "Testing chores" workflow validates that your PR follows our
guidelines. -->
<!-- If it doesn't pass, click on it to see details as to what your PR
might be missing. -->
- [ ] I will check that all automated PR checks pass before the PR gets
reviewed.

Outputs current release dir to prompt

Uses current release dir path, if exists

Uses current release dir path, if exists

Uses current release dir path, if exists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants